[Napoleon_be]

why do you use client_PreThink to check weither player took damage or not? Couldn't this be done with Ham_TakeDamage?

I'm also not a fan of using godmode. The way i've been doing it is like this: (KEEP IN MIND THAT I COULDN'T TEST THIS YET)

PHP Code:

new Float:fSafeTime[33] 


PHP Code:

RegisterHam(Ham_Spawn, "player", "FwPlayerSpawnPost", 1)
RegisterHam(Ham_TakeDamage, "player", "FwPlayerTakeDamagePre", 0) 


PHP Code:

public FwPlayerSpawnPost(id) {
    if(!get_pcvar_num(pCvarPlugin) || !get_pcvar_num(pCvarSpawnProtection)) {
        return HAM_SUPERCEDE
    }
    
    new Float:fProtectTime = get_pcvar_float(pCvarSpawnProtectionTime)
    fSafeTime[id] = get_gametime() + fProtectTime
    
    return HAM_IGNORED
}

public FwPlayerTakeDamagePre(id, inflictor, attacker, Float:damage, dmgbits) {
    if(get_pcvar_num(pCvarPlugin) &&  get_pcvar_num(pCvarSpawnProtection) && fSafeTime[id] >=  get_gametime()) {
        return HAM_SUPERCEDE
    }
    
    return HAM_IGNORED
} 


[Craxor]

Nice plugin man, hamlet sleeping right now so you're lucky )

For sure you should just use godmode and remove takedamge .

[HamletEagle]

I'm also not a fan of using godmode

Well, there is nothing wrong with using godmode and in fact, should be better. It sets takedamage to DAMAGE_NO. Inside CBasePlayer::TraceAttack there is a check for that field. If it's DAMAGE_NO, then TakeDamage won't be called, and this results in less code called internally. Both ways are ok, the difference is trivial.

[eyal282]

Originally Posted by Napoleon_be why do you use client_PreThink to check weither player took damage or not? Couldn't this be done with Ham_TakeDamage? I'm also not a fan of using godmode. The way i've been doing it is like this: (KEEP IN MIND THAT I COULDN'T TEST THIS YET) PHP Code: new Float:fSafeTime[33]  PHP Code: RegisterHam(Ham_Spawn, "player", "FwPlayerSpawnPost", 1) RegisterHam(Ham_TakeDamage, "player", "FwPlayerTakeDamagePre", 0)  PHP Code: public FwPlayerSpawnPost(id) {     if(!get_pcvar_num(pCvarPlugin) || !get_pcvar_num(pCvarSpawnProtection)) {         return HAM_SUPERCEDE     }          new Float:fProtectTime = get_pcvar_float(pCvarSpawnProtectionTime)     fSafeTime[id] = get_gametime() + fProtectTime          return HAM_IGNORED } public FwPlayerTakeDamagePre(id, inflictor, attacker, Float:damage, dmgbits) {     if(get_pcvar_num(pCvarPlugin) &&  get_pcvar_num(pCvarSpawnProtection) && fSafeTime[id] >=  get_gametime()) {         return HAM_SUPERCEDE     }          return HAM_IGNORED }

I use it to remove ( if you even checked LOL ) the spawn protection if the player takes a shot ( I think I could've done it with Ham_Weapon_PrimaryAttack )

[1ka]

lasermine damage? on spawn

[HamletEagle]

I've searched a bit and found no other plugin, so I'm okay with that. For approval:
1.In HamBurger_Spawn always check is_user_alive before doing anything.
2.In HamBurger_Damage firstly check if victim is still connected.
3.Remove client_PreThink for detecting IN_ATTACK and IN_ATTACK2 Switch to PrimaryAttack and SecondaryAttack with proper checks. If you want to be sure that player actually fired a bullet, go for FM_PlaybackEvent. But I think you are only interested if he press the button, so first way is good enough.

[eyal282]

Originally Posted by HamletEagle I've searched a bit and found no other plugin, so I'm okay with that. For approval: 1.In HamBurger_Spawn always check is_user_alive before doing anything. 2.In HamBurger_Damage firstly check if victim is still connected. 3.Remove client_PreThink for detecting IN_ATTACK and IN_ATTACK2 Switch to PrimaryAttack and SecondaryAttack with proper checks. If you want to be sure that player actually fired a bullet, go for FM_PlaybackEvent. But I think you are only interested if he press the button, so first way is good enough.

I also fixed a bug that allows players to shoot in the last second.

[eyal282]

Originally Posted by HamletEagle I've searched a bit and found no other plugin, so I'm okay with that. For approval: 1.In HamBurger_Spawn always check is_user_alive before doing anything. 2.In HamBurger_Damage firstly check if victim is still connected. 3.Remove client_PreThink for detecting IN_ATTACK and IN_ATTACK2 Switch to PrimaryAttack and SecondaryAttack with proper checks. If you want to be sure that player actually fired a bullet, go for FM_PlaybackEvent. But I think you are only interested if he press the button, so first way is good enough.

@HamletEagle

When exactly will you approve? All are done.

[tousif]

Originally Posted by eyal282 @HamletEagle When exactly will you approve? All are done.

When he gets time he will review the changes and if nothing more is left to modify then he may approve .

[HamletEagle]

It will be better to create only one task in plugin_init and loop all players inside it, than having 32 tasks at the same time. If you are not sure how to do that I'll show you.

Edit: Unapproved until you make the changes.