[CSS].CS Online kill message,For CS Source,overlays - Page 2

**KyleS** · 01-18-2011 , 14:18 Re: [CSS].CS Online kill message,For CS Source,overlays

Quote:

Originally Posted by siangc

I tried removing sv_cheats from it, but it didn't work and I got massive spam with this. Maybe I messed up somehow, I hope somebody can make it work without sv_cheats

L 01/18/2011 - 15:10:13: [SM] Native "IsPlayerAlive" reported: Invalid client index 0
L 01/18/2011 - 15:10:13: [SM] Displaying call stack trace for plugin "killmessage_overlays.smx":
L 01/18/2011 - 15:10:13: [SM] [0] Line 138, killmessage_overlays.sp::task_Countdown()

There's no check to see if the client is world or not. A simple check like this should suffice.

PHP Code:


			
if(attacker < 1)
{
    return Plugin_Handled;
}

EDIT: This should function flawlessly (just like TheTwistedPanda said) without modifying cheats.

siangc · *Last edited by siangc; 01-18-2011 at 14:50.*

I gave it another go, it gives me 7 warning messages when I compile about some tag mismatches, only change i did was "ServerCommand("sv_cheats 0");". Clients don't download the sounds and overlay files, tried with and without fastdl. When i installed the files and sounds manually, the sounds didn't work in game and the overlay made everything black tinted (see image below).

[IMG]http://img683.**************/img683/6987/glasswar0121.jpg[/IMG]

I have no idea if I'm doing something wrong :S
running latest stable sourcemod.

edit:
I hardly know anything about scripting, can you tell me where i should put that code kyle?

**KyleS** · *Last edited by KyleS; 01-19-2011 at 02:41.*

Not tested at all, will be removed when the author rectifies this (copy pasted the changes from the modified stock, not really sure what's going on there).

EDIT: Removed.

siangc · 01-18-2011 , 15:48 Re: [CSS].CS Online kill message,For CS Source,overlays

I just tried your version Kyle, it doesn't produce any errors in the logs, but it makes the same black tint all over the screen when a decal appears, and it doesn't play any sound, or downloads the files to the clients.
Is it only me who's got these problems?

Martin · *Last edited by Martin; 01-19-2011 at 02:42.*

Quote:

Originally Posted by Kyle12

Awesome! I can't wait to try this out once it's fixed up.

Also, just as an example:

PHP Code:


			
    if(g_killCount[attacker] == 1)
    {
        if(StrEqual(weapon,"hegrenade"))
            ShowKillMessage(attacker,kill_grenade);
        else if(StrEqual(weapon,"knife"))
            ShowKillMessage(attacker,kill_knife);
        else if(headshot)
            ShowKillMessage(attacker,kill_headshot);
        else
            ShowKillMessage(attacker,kill_1);
    }
    else if(g_killCount[attacker] == 2)
    {
        ShowKillMessage(attacker,kill_2);
    }
    else if(g_killCount[attacker] == 3)
    {
        ShowKillMessage(attacker,kill_3);
    }
    else if(g_killCount[attacker] == 4)
    {
        ShowKillMessage(attacker,kill_4);
    }

Could be:

PHP Code:


			
    new AttackerKillCount = g_killCount[attacker];
    switch(AttackerKillCount)
    {
        case 1:
        {
            if(StrEqual(weapon, "hegrenade"))
            {
                ShowKillMessage(attacker, kill_grenade);
            }
 
            else if(StrEqual(weapon,"knife"))
            {
                ShowKillMessage(attacker, kill_knife);
            }
 
            else if(headshot)
            {
                ShowKillMessage(attacker, kill_headshot);
            }
 
            else
            {
                ShowKillMessage(attacker, kill_1);
            }
        }
 
        case 2:
        {
            ShowKillMessage(attacker, kill_2);
        }
 
        case 3:
        {
            ShowKillMessage(attacker, kill_3);
        }
 
        case 4:
        {
            ShowKillMessage(attacker, kill_4);
        }
    }

Just so you're not reindexing the array (no idea if this is the proper term, sorry if it isn't) every time, caching is nice

Thanks

, because I am not used to use Switch Case.

Martin · *Last edited by Martin; 01-19-2011 at 02:49.*

Quote:

Originally Posted by Kyle12

There's no check to see if the client is world or not. A simple check like this should suffice.

PHP Code:


			
if(attacker < 1)
{
    return Plugin_Handled;
}

EDIT: This should function flawlessly (just like TheTwistedPanda said) without modifying cheats.

Thanks ，I hava edited.

**KyleS** · *Last edited by KyleS; 01-25-2011 at 21:40.*

new Handle:g_killCount[33]; - Shouldn't be a handle (This is why you're getting compilation warnings).

Instead of 33 you should be using MAXPLAYERS+1, I personally run now 7 64slot servers. This plugin would not function on them (Array errors most likely).

psychonic · 01-19-2011 , 07:46 Re: [CSS].CS Online kill message,For CS Source,overlays

Quote:

Originally Posted by Kyle12

new Handle:g_killCount[33]; - Shouldn't be a handle (This is why you're getting compilation warnings).

Instead of 33 you should be using MAXPLAYERS+2, I personally run now 7 64slot servers. This plugin would not function on them (Array errors most likely).

* MAXPLAYERS+1

siangc · 01-19-2011 , 07:57 Re: [CSS].CS Online kill message,For CS Source,overlays

I think there's a problem with the filepaths? Clients don't download the files when they join, when i installed them manually only the images worked (no sounds).

vox/ultrakill should be vox/ultrakill.wav, but should the path be "sound/vox/ultrakill.wav"?

PStar · *Last edited by PStar; 01-19-2011 at 11:50.*

Donwloadint hte files are broken, but the overly works fine if i ad the file to my game manually.

Getting this error messages in console:

Quote:

vász Kardiológus killed Orin with ak47.
FCVAR_SERVER_CAN_EXECUTE prevented server running command: speak
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
Requesting texture value from var "$normalmap" which is not a texture value (material: overlays/kill/kill_headshot)
L

And i think you shoud make the overlay brighter cause no it too dark, and make the colors more vivid.
And maybe move the kill picture to the lower right side of the screen.