[I am inevitable]

PHP Code:

#include <sourcemod>
#include <sdktools>

#pragma semicolon 1

char g_sWeapons[][] =
{
    "weapon_deagle",
    "weapon_elite"
};

public void OnPluginStart()
{
    RegConsoleCmd("sm_test", Cmd_Test);
}

public Action Cmd_Test(int iClient, int iArgs)
{
    if (IsValidClient(iClient))
    {
        char sWeapon[MAXPLAYERS + 1][5][32];
        
        int iWeapons_Size = GetEntPropArraySize(iClient, Prop_Send, "m_hMyWeapons");
        
        // loop through the clients weapons, based on the amount of slots the client has occupied
        for (int x = 0; x < iWeapons_Size; x++)
        {
            // get the weapon index based on that slot
            int iWeapon_Entity_Index = GetEntPropEnt(iClient, Prop_Send, "m_hMyWeapons", x);
            
            // and from that, get the weapon classname
            GetWeaponClassname(iWeapon_Entity_Index, sWeapon[iClient][x], sizeof(sWeapon[][]));
            
            // this will loop through the g_sWeapons array, checking if the weapon -
            // classname is equivalent to any of the ones in the array
            for (int y = 0; y < sizeof(g_sWeapons[]); y++)
            {
                if (StrEqual(sWeapon[iClient][x], g_sWeapons[y]))
                {
                    PrintToChatAll("the client has one of the weapons in the g_sWeapons array");
                }
            }
        }
    }
    
    return Plugin_Handled;
}

public void GetWeaponClassname(int iWeapon_Entity_Index, char[] sBuffer, int iBuffer_Size)
{
    switch (GetEntProp(iWeapon_Entity_Index, Prop_Send, "m_iItemDefinitionIndex"))
    {
        case 60:
            Format(sBuffer, iBuffer_Size, "weapon_m4a1_silencer");
        
        case 61:
            Format(sBuffer, iBuffer_Size, "weapon_usp_silencer");
        
        case 63:
            Format(sBuffer, iBuffer_Size, "weapon_cz75a");
        
        case 64:
            Format(sBuffer, iBuffer_Size, "weapon_revolver");
        
        default:
            GetEntityClassname(iWeapon_Entity_Index, sBuffer, iBuffer_Size);
    }
}

public bool IsValidClient(int iClient)
{
    if (!(0 < iClient <= MaxClients) || !IsClientConnected(iClient) || !IsClientInGame(iClient) || IsFakeClient(iClient))
        return false;
    
    return true;
} 


the statement at line 38 just returns false. I don't even know if this code does what I want it to, can I have a second pair of eyes, thanks.

[Whai]

Try this :

PHP Code:

#include <sourcemod>
#include <sdktools>
#include <cstrike>

#pragma semicolon 1
#pragma newdecls required

char sWeapon[MAXPLAYERS + 1][4][32];

char g_sWeapons[][] =
{
    "weapon_deagle",
    "weapon_elite"
};

public void OnPluginStart()
{
    RegConsoleCmd("sm_test", Cmd_Test);
}

public Action Cmd_Test(int iClient, int iArgs)
{
    if (IsValidClient(iClient))
    {
        // NOTE : we don't care about C4 slot (informations from cstrike.inc)
        for (int x = 0; x <= 3; x++)
        {
            // get the weapon index based on that slot
            int iWeapon_Entity_Index = GetPlayerWeaponSlot(iClient, x);

            // check if the weapon was found
            if(IsValidEntity(iWeapon_Entity_Index))
            {
                continue; // skip this
            }
            
            // and from that, get the weapon classname
            GetWeaponClassname(iWeapon_Entity_Index, sWeapon[iClient][x], sizeof(sWeapon[][])); 
            
            
            // this will loop through the g_sWeapons array, checking if the weapon -
            // classname is equivalent to any of the ones in the array
            for (int y = 0; y < sizeof(g_sWeapons[]); y++)
            {
                if (StrEqual(sWeapon[iClient][x], g_sWeapons[y]))
                {
                    PrintToChatAll("the client has one of the weapons in the g_sWeapons array");
                }
            }
        }
    }
    
    return Plugin_Handled;
}

public void GetWeaponClassname(int iWeapon_Entity_Index, char[] sBuffer, int iBuffer_Size)
{
    switch (GetEntProp(iWeapon_Entity_Index, Prop_Send, "m_iItemDefinitionIndex"))
    {
        case 60:
            Format(sBuffer, iBuffer_Size, "weapon_m4a1_silencer");
        
        case 61:
            Format(sBuffer, iBuffer_Size, "weapon_usp_silencer");
        
        case 63:
            Format(sBuffer, iBuffer_Size, "weapon_cz75a");
        
        case 64:
            Format(sBuffer, iBuffer_Size, "weapon_revolver");
        
        default:
            GetEntityClassname(iWeapon_Entity_Index, sBuffer, iBuffer_Size);
    }
}

public bool IsValidClient(int iClient)
{
    if (!(0 < iClient <= MaxClients) || !IsClientConnected(iClient) || !IsClientInGame(iClient) || IsFakeClient(iClient))
        return false;
    
    return true;
} 


[eyal282]

I think GetPlayerWeaponSlot doesn't require IsValidEntity, only requires to ensure it is not equal to -1 (minus one)

[Whai]

Yes, I firstly did that but I replaced it to be sure he will understand the code. It does not matter (or maybe there is a latence to find if it exists or not by looking for every entity id, I don't know), the code will do what he wanted

[I am inevitable]

there's nothing wrong with my code, and if you didn't notice, I marked the thread as solved way before I got responses.

[Whai]

He was talking on my code, not yours

[I am inevitable]

Originally Posted by Whai He was talking on my code, not yours

I know lol?

[Whai]

I was just answering to eyal282 to justify why I did this

[I am inevitable]

All good