[DarkGod]

Originally Posted by Jelle Also, I do use switch, but only when there is more than two if conditions.

Didn't see this before.
Only time you shouldn't use switch over if is when it's only a if or if and else. switch is always better than if and else if.

[Jelle]

Originally Posted by DarkGod Didn't see this before. Only time you shouldn't use switch over if is when it's only a if or if and else. switch is always better than if and else if.

I have always been told that two if statements is better than a switch, but using more than two, then using switch is better.

Using a switch for just one condition just seems odd.

[DarkGod]

Originally Posted by Jelle I have always been told that two if statements is better than a switch, but using more than two, then using switch is better. Using a switch for just one condition just seems odd.

Did you read what I said? lol, if is better if you have a single if or an if and an else.

[MuzzMikkel]

Originally Posted by Jelle I wasn't really aware of that, thank you. Post the whole code. Have you precached the weapon model correct?

I think so. But i also have another problem with unlimted bullets. When i have used a whole mag, it dosen't keep shooting?

Here is the whole code:

PHP Code:

/* Plugin generated by AMXX-Studio */

#include <superheromod>

new gHeroID
new gHasBones[SH_MAXSLOTS+1]
new const gBonesGalil[] = "models/shmod/Bones/Bones_v_galil.mdl"
new const gBonesDeagle[] = "models/shmod/Bones/Bones_v_deagle.mdl"
new const gBonesGalil2[] = "models/shmod/Bones/Bones_p_galil.mdl"
new const gBonesDeagle2[] = "models/shmod/Bones/Bones_p_deagle.mdl"
new const gBonesPlayer[] = "models/player/Bones/Bones.mdl"

public plugin_init()
{
    register_plugin("SUPERHERO Bones", "1.1", "MuzzMikkel")
    
    new pcvarLevel = register_cvar("Bones_level", "10")
    new pcvarHealth = register_cvar("Bones_health", "450")
    new pcvarArmor = register_cvar("Bones_armor", "500")
    new pcvarSpeed = register_cvar("Bones_speed", "850")
    new pcvarGrav = register_cvar("Bones_grav", "2.5")
    new pcvarGalilMult = register_cvar("Bones_galilmult", "3.0")
    new pcvarDeagleMult = register_cvar("Bones_deaglemult", "2.1")
    
    gHeroID = sh_create_hero("Bones", pcvarLevel)
    sh_set_hero_info(gHeroID, "Bones the superkiller!", "Get's a powerfull Galil / Dual golden deagle's")
    
    sh_set_hero_dmgmult(gHeroID, pcvarGalilMult, CSW_GALIL)
    sh_set_hero_dmgmult(gHeroID, pcvarDeagleMult, CSW_DEAGLE)
    sh_set_hero_hpap(gHeroID, pcvarHealth, pcvarArmor)
    sh_set_hero_speed(gHeroID, pcvarSpeed)
    sh_set_hero_grav(gHeroID, pcvarGrav)
    
    register_event("CurWeapon", "weapon_change", "be", "1=1")
    
}

public sh_hero_init(id, heroID, mode)
{
    if ( gHeroID != heroID ) return
    
    switch(mode)
    {
        case SH_HERO_ADD:
        {
            gHasBones[id] = true
            Bones_weapons(id)
            switch_model(id)
            Bones_morph(id)
        
        }
        
        case SH_HERO_DROP:
        {
            gHasBones[id] = false
            Bones_unmorph(id)
            if (is_user_alive(id))
            
            {
                sh_drop_weapon(id, CSW_GALIL, true)
        sh_drop_weapon(id, CSW_DEAGLE, true)
        
            }
        }
    }
}

public sh_client_spawn(id)
{
    if (gHasBones[id])
    {
        Bones_weapons(id)
    Bones_morph(id)
    }
}

public weapon_change(id)
{
    if ( !sh_is_active() || !gHasBones[id] ) return  
    
    new weaponID = read_data(2)
    if (weaponID !=CSW_GALIL) return
    if (weaponID !=CSW_DEAGLE) return
    
    switch_model(id)
    
    if (read_data(3) == 0)
    {
        sh_reload_ammo(id, 1)
    }
}

public plugin_precache()
{
    precache_model(gBonesGalil); 
    precache_model(gBonesGalil2);
    precache_model(gBonesDeagle); 
    precache_model(gBonesDeagle2);
    precache_model(gBonesPlayer)
}

Bones_weapons(id)
{
    if (sh_is_active() && is_user_alive(id) && gHasBones[id] )
    {
        sh_give_weapon(id, CSW_GALIL)
    sh_give_weapon(id, CSW_DEAGLE)
    }
}

switch_model(id)
{
    if (!sh_is_active() || !is_user_alive(id) || !gHasBones[id] ) return
    
if ( get_user_weapon(id) == CSW_GALIL) 
{
        set_pev(id, pev_viewmodel2, gBonesGalil)
    set_pev(id, pev_weaponmodel2, gBonesGalil2)
}

else if ( get_user_weapon(id) == CSW_DEAGLE )
{
    set_pev(id, pev_viewmodel2, gBonesDeagle)
    set_pev(id, pev_weaponmodel2, gBonesDeagle2)
    }
}

Bones_morph(id)
{
    cs_set_user_model(id, "Bones")
}

Bones_unmorph(id)
{
    cs_reset_user_model(id)
} 


[DarkGod]

if (weaponID !=CSW_GALIL) return
if (weaponID !=CSW_DEAGLE) return

You can't have both up at the same time.

[MuzzMikkel]

Originally Posted by DarkGod if (weaponID !=CSW_GALIL) return if (weaponID !=CSW_DEAGLE) return You can't have both up at the same time.

How should i do then?

[DarkGod]

Originally Posted by MuzzMikkel How should i do then?

if(weaponID == CSW_GALIL || weaponID == CSW_DEAGLE)
       //stuff 

[Fr33m@n]

in if condition, else if :
|| = OR
&& = AND
!= is different to
== is strictly equal to

!something = contrary of something
example

PHP Code:

if ( !is_user_alive(id) )
{
    //if the user is NOT alive, do this code.
} 


basic useful condition.

[Jelle]

Originally Posted by DarkGod Did you read what I said? lol, if is better if you have a single if or an if and an else.

I thought you meant else if and not just else. I can see how if and else would be much better than a switch, and I normally do use it that way.

I also use else if, if I am checking something where what happens depends on two different conditions which can be more than two different things.

[MuzzMikkel]

Worked 100% thank you guys

Here's some bacon
The guys who helped me must ;)

Jelle:
Fr33m@n:
DarkGod:

-------------------------------------------------------------

The guys who helped me less ;)

RollerBlades:

PROBLEM SOLVED!!