hook player id

lexzor · **Author**

Hello again! i hope u all are happy and healthy,

anyway, I have a plugin that sets the skins at each starting round using cs_set_user_model (id), but my server is running CSGO Remake mode and after 16 rounds the teams change. After this change, the plugin no longer sets the skin in the first round. Now I use spawn player to hook, but I would like another method. I tried at one point with a "hudreset" command, but as far as I can remember it didn't work very well. However, my question is if I can hook the player id using "round start" or do you know other methods for the plugin to work properly?

that's the code.

PHP Code:


			

public init() RegisterHam(Ham_Spawn, "player", "skincheck", 1)

public skincheck(id){    
    if(is_user_alive(id)){
        if ( (cs_get_user_team(id) == CS_TEAM_T) && (is_user_logged(id) == 1) ){            
            switch(checkT[id]){                
                case 1:{                    
                    cs_set_user_model(id, "isis")                
                    checkPS[id] = 1                    
                }
                
                case 2:{                    
                    cs_set_user_model(id, "alqaeda")                    
                    checkPS[id] = 2                    
                }
                
                case 3:{
                    cs_set_user_model(id, "pro_loudmouth")
                    checkPS[id] = 3
                }
                case 4:{
                    if(get_user_flags(id) & VIP_FLAG){
                        cs_set_user_model(id, "pro_miamy")
                        checkPS[id] = 4
                        }else{
                        cs_reset_user_model(id)
                        checkPS[id] = 0
                    }
                }
            }            
            } else if( (cs_get_user_team(id) == CS_TEAM_CT) && (is_user_logged(id) == 1)){            
            switch(checkCT[id]){                
                case 1:{                    
                    cs_set_user_model(id, "fbi")                    
                    checkPS[id] = 5                    
                }
                
                case 2:{                    
                    cs_set_user_model(id, "sias")                    
                    checkPS[id] = 6                    
                }
                
                case 3:{
                    cs_set_user_model(id, "swat_bombson")
                    checkPS[id] = 7
                }
                
                case 4:{
                    if(get_user_flags(id) & VIP_FLAG){
                        cs_set_user_model(id, "st6_blueberries")
                        checkPS[id] = 8
                        } else{
                        cs_reset_user_model(id)
                        checkPS[id] = 0
                    }
                }
            }
        } else cs_reset_user_model(id)
    }
}

Black Rose · 01-23-2021 , 05:40 Re: hook player id

In a not so far distant future.
One (wo)man on a quest for answers.
Little did (s)he know how it all would end...

Suddenly, a helpful character emerges from the darkness...

Helpful character: There's no forward called "init()". You have loads of undeclared variables.

You: That's not my actual code. I made psuedocode and removed things that isn't the issue.

Helpful character: *rolls eyes* I can tell. But since you ask for help here you don't know what the issue is and isn't qualified to make those decisions. My guess is checkT[id]/checkCT[id] isn't set to what you are expecting since team change might be forced (?) and the variable is set by choice?

You: Can you help me or not?

Helpful character: Not until you share the actual code you want help with.

You: bump

*Helpful character dissapears back into the darkness never to be seen again*

You: bump

You: bump

*thread slowly rolls over to page 2 of the forum section*

GAME OVER
Retry?
(y/n)
Waiting for input...

Natsheh · 01-23-2021 , 06:30 Re: hook player id

Lmao, I got to say that's a pretty deep story and correct.

lexzor · 01-23-2021 , 09:18 Re: hook player id

Nice story.

PHP Code:


			
/* Plugin generated by AMXX-Studio */

#include <amxmodx>
#include <amxmisc>
#include <cstrike>
#include <hamsandwich>
#include <ColorChat>
#include <fakemeta>
#include <nvault>



#define PLUGIN "Secondary Menu"
#define VERSION "1.1"
#define AUTHOR "lexzor"

#define VIP_FLAG ADMIN_LEVEL_H

#define HudTask 3213

new const tag[ ]= "[CSGO Classy]^1"
new const nVaultName[ ] = "csgoagents";

static key = MENU_KEY_1|MENU_KEY_2|MENU_KEY_3|MENU_KEY_4|MENU_KEY_5|MENU_KEY_6|MENU_KEY_7|MENU_KEY_8|MENU_KEY_9|MENU_KEY_0;

static checkCT[MAX_PLAYERS + 1],
checkT[MAX_PLAYERS + 1],
checkPS[MAX_PLAYERS + 1],
g_szAuthID[ MAX_PLAYERS + 1 ][ 34 ] ,
vaultdata[1024],
nVault

new playerskins[][] = {
    "sias",
    "fbi",
    "isis",
    "alqaeda",
    "pro_loudmouth",
    "swat_bombson"
}

public plugin_init() {
    register_plugin(PLUGIN, VERSION, AUTHOR)

    register_clcmd("amx_agents", "playerskin")    
    register_menu("playerskin", key, "playerskin_handler")

    RegisterHam(Ham_Spawn, "player", "skincheck", 1)

    nVault = nvault_open(nVaultName)
    
    if (nVault == INVALID_HANDLE)
        set_fail_state("[SECONDARYMENU] Plugin can't open nVault file!")
}

public plugin_precache(){
    static playermodels[256]
    
    for (new i = 0; i < sizeof(playerskins); i++){    
        formatex(playermodels, charsmax(playermodels), "models/player/%s/%s.mdl", playerskins[i], playerskins[i])    
        precache_model(playermodels)    
    } 
    
}

public cmdSave(id){
    formatex( vaultdata, charsmax(vaultdata), "^"%d^" ^"%d^" ^"%d^" ^"%d^"", checkPS[id], checkT[id], checkCT[id], hudon[id] )
    nvault_set(nVault, g_szAuthID[ id ], vaultdata)
}

public cmdGet(id){
    new checkps[10], checkt[10], checkct[10], hud[10], iTS
    if(nvault_lookup(nVault, g_szAuthID[ id ], vaultdata, charsmax(vaultdata),iTS)){
        parse(vaultdata, checkps, charsmax(checkps), checkt, charsmax(checkt), checkct, charsmax(checkct), hud, charsmax(hud))
        checkPS[id] = str_to_num(checkps)
        checkT[id] = str_to_num(checkt)
        checkCT[id] = str_to_num(checkct)
        hudon[id] = str_to_num(hud)    
    }
}

public client_disconnected(id){    
    cmdSave(id)
    remove_task()    
}

public client_authorized(id)    get_user_authid( id , g_szAuthID[ id ] , charsmax( g_szAuthID[] ) ); 


public client_putinserver(id)    cmdGet(id)

    

public playerskin(id){
    
    static szMenu2[650], ilen    
    ilen = 0
    
    ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r[CSGO Classy]\y Skin Menu^n^n")            
    ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r1.\y Default Skin - %s^n^n",  checkPS[id] == 0 ? "\y[ON]" : "\r[OFF]")
    
    if (cs_get_user_team(id) == CS_TEAM_T || cs_get_user_team(id) == CS_TEAM_UNASSIGNED || cs_get_user_team(id) == CS_TEAM_SPECTATOR){
        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r2.\w ISIS Killer - %s^n", checkPS[id] == 1 ? "\y[ON]" : "\r[OFF]")    
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r3.\w aL-Qaeda Hitman - %s^n", checkPS[id] == 2 ? "\y[ON]" : "\r[OFF]")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r4.\w Crazy Assassin - %s^n^n", checkPS[id] == 3 ? "\y[ON]" : "\r[OFF]")    
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r5.\w FBI Agent -\d [CT ONLY]^n")        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r6.\w SIAS Specialist -\d [CT ONLY]^n")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r7.\w Lt. Johnson John -\d [CT ONLY]^n^n")
        
        }else if ( cs_get_user_team(id) == CS_TEAM_CT || cs_get_user_team(id) == CS_TEAM_UNASSIGNED || cs_get_user_team(id) == CS_TEAM_SPECTATOR){
        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r2.\w ISIS Killer -\d [T ONLY]^n")        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r3.\w aL-Qaeda Hitman -\d [T ONLY]^n")    
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r4.\w Crazy Assassin - \d [T ONLY]^n^n")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r5.\w FBI Agent - %s^n", checkPS[id] == 4 ? "\y[ON]" : "\r[OFF]")        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r6.\w SIAS Specialist - %s^n", checkPS[id] == 5 ? "\y[ON]" : "\r[OFF]")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r7.\w Lt. Johnson John - %s^n^n", checkPS[id] == 6 ? "\y[ON]" : "\r[OFF]")
    }
    
    ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r0.\y Back")
    
    show_menu(id, key, szMenu2, -1, "playerskin")
    
}

public playerskin_handler(id, key){
    
    if (!(is_user_alive(id))){
        ColorChat(id, GREEN, "%s You must be^4 alive^1 to use this menu!", tag)
        menuVIP(id)
        return PLUGIN_HANDLED    
        }
    
    switch(key){
        
        case 0: {            
            checkPS[id] = 0;    
            checkCT[id] = 0;    
            checkT[id] = 0;
            cs_reset_user_model(id)
            ColorChat(id, GREEN, "%s You choose^4 default^1 skin!", tag)            
        }
        
        case 1:{            
            if (cs_get_user_team(id) == CS_TEAM_T){                
                checkT[id] = 1                
                checkPS[id] = 1                            
                cs_set_user_model(id, "isis")                
                ColorChat(id, GREEN, "%s You choose^4 ISIS Killer^1 skin!", tag)                                
                } else if (cs_get_user_team(id) == CS_TEAM_CT){                
                ColorChat(id, GREEN, "%s You can't choose this skin!", tag)                        
            }        
            playerskin(id)        
        }
        
        case 2:{            
            if (cs_get_user_team(id) == CS_TEAM_T){        
                checkT[id] = 2                
                checkPS[id] = 2                            
                cs_set_user_model(id, "alqaeda")                
                ColorChat(id, GREEN, "%s You choose^4 aL-Qaeda Hitman^1 skin!", tag)    
                playerskin(id)            
                } else if (cs_get_user_team(id) == CS_TEAM_CT){                
                ColorChat(id, GREEN, "%s You can't choose this skin!", tag)            
                playerskin(id)            
            }        
        }
        
        case 3:{            
            if (cs_get_user_team(id) == CS_TEAM_T){                
                checkT[id] = 3                
                checkPS[id] = 3                            
                cs_set_user_model(id, "pro_loudmouth")                
                ColorChat(id, GREEN, "%s You choose^x04 Crazy Assassin^x01 skin!", tag)                
                playerskin(id)                
            }
            if (cs_get_user_team(id) == CS_TEAM_CT){                
                ColorChat(id, GREEN, "%s You can't choose this skin!", tag)                
                playerskin(id)                
            }        
        }
        
        case 4:{            
            if (cs_get_user_team(id) == CS_TEAM_CT){                
                checkCT[id] = 1                
                checkPS[id] = 4                            
                cs_set_user_model(id, "fbi")                
                ColorChat(id, GREEN, "%s You choose^x04 FBI Agent^x01 skin!", tag)                
                playerskin(id)                
            }
            if (cs_get_user_team(id) == CS_TEAM_T){                
                ColorChat(id, GREEN, "%s You can't choose this skin!", tag)                
                playerskin(id)                
            }        
        }
        
        case 5:{            
            if (cs_get_user_team(id) == CS_TEAM_CT){                
                checkCT[id] = 2                
                checkPS[id] = 5                        
                cs_set_user_model(id, "sias")                
                ColorChat(id, GREEN, "%s You choose^4 SIAS Specialist^1 skin!", tag)                
                playerskin(id)
                
            }
            if (cs_get_user_team(id) == CS_TEAM_T){                
                ColorChat(id, GREEN, "%s You can't choose this skin!", tag)                
                playerskin(id)                
            }            
        }
        
        case 6:{            
            if (cs_get_user_team(id) == CS_TEAM_CT){                
                checkCT[id] = 3                
                checkPS[id] = 6                        
                cs_set_user_model(id, "swat_bombson")                
                ColorChat(id, GREEN, "%s You choose^4 Lt. Johnson John^1 skin!", tag)                
                playerskin(id)
                
            }
            if (cs_get_user_team(id) == CS_TEAM_T){                
                ColorChat(id, GREEN, "%s You can't choose this skin!", tag)                
                playerskin(id)                
            }            
        }
        
        case 9: menuVIP(id)    
    }
}





public skincheck(id){    
    if(is_user_alive(id)){        
        if ( cs_get_user_team(id) == CS_TEAM_T ){            
            switch(checkT[id]){                
                case 1:{                    
                    cs_set_user_model(id, "isis")                
                    checkPS[id] = 1                    
                }
                
                case 2:{                    
                    cs_set_user_model(id, "alqaeda")                    
                    checkPS[id] = 2                    
                }
                
                case 3:{
                    cs_set_user_model(id, "pro_loudmouth")
                    checkPS[id] = 3
                }
            }            
            } else if( cs_get_user_team(id) == CS_TEAM_CT ){            
            switch(checkCT[id]){                
                case 1:{                    
                    cs_set_user_model(id, "fbi")                    
                    checkPS[id] = 4                    
                }
                
                case 2:{                    
                    cs_set_user_model(id, "sias")                    
                    checkPS[id] = 5                    
                }
                
                case 3:{
                    cs_set_user_model(id, "swat_bombson")
                    checkPS[id] = 6
                }
            }
        } else cs_reset_user_model(id)
    }
}

Black Rose · 01-23-2021 , 10:05 Re: hook player id

So yeah. So you have a couple of options.

If we take this code here:

Code:

        if ( cs_get_user_team(id) == CS_TEAM_T ){
            switch(checkT[id]){
                case 1:{
                    cs_set_user_model(id, "isis")
                    checkPS[id] = 1
                }

                case 2:{
                    cs_set_user_model(id, "alqaeda")
                    checkPS[id] = 2
                }

                case 3:{
                    cs_set_user_model(id, "pro_loudmouth")
                    checkPS[id] = 3
                }
            }            
        }

So first off, add a check if no custom T skin was chosen by adding a default ("else" in switches) to the switch.

Code:

        if ( cs_get_user_team(id) == CS_TEAM_T ){
            switch(checkT[id]){
                //...
                default:{
                }
            }            
        }

Then perhaps check if they had selected a custom CT skin. That might mean they are interested in chosing a custom T skin as well.

Code:

                default:{
                    if ( checkCT[id] ){
                        
                    }
                }

So then you have two choices. Either you just set their skin to the T equivalent.

Code:

                default:{
                    if ( checkCT[id] ){
                        checkT[id] = checkCT[id]; // This can only be used if the number of skins are equal on both teams.
                        skincheck(id) // Lazy way of calling the function again from within itself. Be careful you don't end up in an endless loop.

                    }
                }

If they don't have a selection, call the menu?

Code:

                default:{
                    if ( ! checkCT[id] ){
                        playerskin(id);
                    }
                }

Put it all together...

Code:

        if ( cs_get_user_team(id) == CS_TEAM_T ){
            switch(checkT[id]){
                case 1:{
                    cs_set_user_model(id, "isis")
                    checkPS[id] = 1
                }

                case 2:{
                    cs_set_user_model(id, "alqaeda")
                    checkPS[id] = 2
                }

                case 3:{
                    cs_set_user_model(id, "pro_loudmouth")
                    checkPS[id] = 3
                }
                default:{
                    if ( checkCT[id] ){
                        checkT[id] = checkCT[id];
                        skincheck(id);
                    }
                    else
                        playerskin(id);
                }
            }            
        }

Do the same thing for CT.

Also some small things.

checkPS[id] is pretty useless. You can do the same thing using checkT and checkCT.

Code:

    if (cs_get_user_team(id) == CS_TEAM_T || cs_get_user_team(id) == CS_TEAM_UNASSIGNED || cs_get_user_team(id) == CS_TEAM_SPECTATOR){
        //...
        }else if ( cs_get_user_team(id) == CS_TEAM_CT || cs_get_user_team(id) == CS_TEAM_UNASSIGNED || cs_get_user_team(id) == CS_TEAM_SPECTATOR){
        //...

cs_get_user_team(id) == CS_TEAM_UNASSIGNED || cs_get_user_team(id) == CS_TEAM_SPECTATOR is completely useless in the second if statement.
The first one reads:
if ( user is on team T OR unassigned OR spectator )
// ...
else ( the only thing left here is CT so... )

Perhaps this is more suitable?

Code:

    if (cs_get_user_team(id) == CS_TEAM_T){
        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r2.\w ISIS Killer - %s^n", checkPS[id] == 1 ? "\y[ON]" : "\r[OFF]")    
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r3.\w aL-Qaeda Hitman - %s^n", checkPS[id] == 2 ? "\y[ON]" : "\r[OFF]")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r4.\w Crazy Assassin - %s^n^n", checkPS[id] == 3 ? "\y[ON]" : "\r[OFF]")    
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r5.\w FBI Agent -\d [CT ONLY]^n")        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r6.\w SIAS Specialist -\d [CT ONLY]^n")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r7.\w Lt. Johnson John -\d [CT ONLY]^n^n")
        
    }else if ( cs_get_user_team(id) == CS_TEAM_CT){
        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r2.\w ISIS Killer -\d [T ONLY]^n")        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r3.\w aL-Qaeda Hitman -\d [T ONLY]^n")    
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r4.\w Crazy Assassin - \d [T ONLY]^n^n")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r5.\w FBI Agent - %s^n", checkPS[id] == 4 ? "\y[ON]" : "\r[OFF]")        
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r6.\w SIAS Specialist - %s^n", checkPS[id] == 5 ? "\y[ON]" : "\r[OFF]")
        ilen += formatex(szMenu2[ilen], charsmax(szMenu2), "\r7.\w Lt. Johnson John - %s^n^n", checkPS[id] == 6 ? "\y[ON]" : "\r[OFF]")
    }
    else{
        return;
    }

Natsheh · 01-23-2021 , 10:14 Re: hook player id

i hate to break it to you but such a plugin is already existed, even its 100times better than this crappy one.

lexzor · 01-23-2021 , 10:42 Re: hook player id

I have not found anything. can you leave me a link?

thanks blackrose, i will try it later i m not at pc in this moment

LondoN · 01-23-2021 , 11:47 Re: hook player id

Code:

#include < amxmodx >
#include < amxmisc >
#include < cstrike >

new const g_szTerroModelNames [ ] =
{
	"model 1",
	"model 2",
	"model 3"
};

new const g_szCTModelNames [ ] =
{
	"model 1",
	"model 2",
	"model 3"
};

new const g_szMenuItems [ ] = 
{
	"tero 1",	
	"tero 2",
	"tero 3",
	"ct 1",
	"ct 2",
	"ct 3"
};

public plugin_init ( )	register_clcmd ( "say /skin", "pCmd_SkinMenu" );
public plugin_precache ( )
{
	static pModelName [ 128 ], i;
	
	for ( i = 0; i < sizeof g_szTerroModelNames; i++ )
	{
		formatex ( pModelName, charsmax ( pModelName ), "models/player/%s/%s.mdl", g_szTerroModelNames [ i ], g_szTerroModelNames [ i ] );
		precache_model ( pModelName );
	}

	for ( i = 0; i < sizeof g_szCTModelNames; i++ )
	{
		formatex ( pModelName, charsmax ( pModelName ), "models/player/%s/%s.mdl", g_szCTModelNames [ i ], g_szCTModelNames [ i ] );
		precache_model ( pModelName );
	}
}

public pCmd_SkinMenu ( id )
{
	new iMenu = menu_create ( "Choose Skins", "pMenu_Handler" );

	new i;

	switch ( get_user_team ( id ) )
	{
		case 1:
		{
			for ( i = 0; i < 3; i++ )
				menu_additem ( iMenu, g_szMenuItems [ i ] );
		}

		case 2:
		{
			for ( i = 3; i < 6; i++ )
				menu_additem ( iMenu, g_szMenuItems [ i ] );
		}
	}

	menu_setprop ( iMenu, MPROP_EXIT, MEXIT_ALL );
	menu_display ( id, iMenu, 0 );
}

public pMenu_Handler ( id, iMenu, iKey )
{
	if ( iKey == MENU_EXIT )
	{
		menu_destroy ( iMenu );
		return 1;
	}

	if ( !is_user_alive ( id ) )
		return 1;

	switch ( get_user_team ( id ) )
	{
		case 1:	cs_set_user_model ( id, g_szTerroModelNames [ iKey ] );
		case 2:	cs_set_user_model ( id, g_szCTModelNames [ iKey ] );
	}

	return 1;
}

probably this helps you, just an example

lexzor · 01-23-2021 , 13:41 Re: hook player id

PHP Code:


			
public skincheck(id){    
    if(is_user_alive(id) && (is_user_logged(id) == 0) && (checkCT[id] || checkT[id])){
        if (cs_get_user_team(id) == CS_TEAM_T){            
            switch(checkT[id]){                
                case 1:    cs_set_user_model(id, "isis")                
                    
                case 2:    cs_set_user_model(id, "alqaeda")                    
                    
                case 3:    cs_set_user_model(id, "pro_loudmouth")
                    
                case 4:{
                    if(get_user_flags(id) & VIP_FLAG)    cs_set_user_model(id, "pro_miamy")
                    else
                    {
                        cs_reset_user_model(id)
                        checkT[id] = 0
                    }
                }
                
                default: cs_reset_user_model(id)
            }            
            } else if(cs_get_user_team(id) == CS_TEAM_CT){            
            switch(checkCT[id]){                
                case 1:    cs_set_user_model(id, "fbi")                    
                    
                case 2:    cs_set_user_model(id, "sias")                    
                    
                case 3:    cs_set_user_model(id, "swat_bombson")
                    
                case 4:{
                    if(get_user_flags(id) & VIP_FLAG)    cs_set_user_model(id, "st6_blueberries")
                    else
                    {
                        cs_reset_user_model(id)
                        checkCT[id] = 0
                    }
                }
                default: cs_reset_user_model(id)
}}}else cs_reset_user_model(id)
}

it is better now ?

i won't waste time to use new menus, it's working now and that is what that plugin need

thanks london, i saved this link in my bookmarks!