[Wliu]

Specifically, I'd like to be able to tell when the Half-Zatoichi (TF2) is sheathed so that I can do some custom logic based on whether a kill was made or not.

Also, while we're here, is there an easy way to tell if a weapon is a reskin or not? Preferably just the collection-type ones, but all reskins are fine too.

[Powerlord]

Originally Posted by Wliu Specifically, I'd like to be able to tell when the Half-Zatoichi (TF2) is sheathed so that I can do some custom logic based on whether a kill was made or not.

SDKHooks. Specifically SDKHook_WeaponSwitch.

Originally Posted by Wliu Also, while we're here, is there an easy way to tell if a weapon is a reskin or not? Preferably just the collection-type ones, but all reskins are fine too.

The collection-type items all have item definition indexes >= 15000. Right now, that's 15000 through 15158.

There used to be template items starting with 16000, but those have since been removed from the schema.

[Chdata]

You can use TF2Attributes to check if they have the skin wear attribute, probably.

That SDKHook works, but not that returning Plugin_Handled to block it won't be client predicted so it'll look glitchy to them.

[Wliu]

Great, thanks!

Chdata: That's a pretty good idea (and actually is directly related to what I want to do with them), so thanks.

[Chdata]

Another idea is to just check the item definition index, put all non-stock weapons in an empty switch case, and then default will cover all the sniper rifle reskins and any new ones that are added to the game.

However if something like the star shooter is added which is actually a Machina reskin, you'll have to update it. However it will still cover the majority of these new weapon skins for the future going forward.

[friagram]

Originally Posted by Chdata Another idea is to just check the item definition index, put all non-stock weapons in an empty switch case, and then default will cover all the sniper rifle reskins and any new ones that are added to the game. However if something like the star shooter is added which is actually a Machina reskin, you'll have to update it. However it will still cover the majority of these new weapon skins for the future going forward.

This is similar to what I do.

You could make a secondary plugin that uses a native to get stock index, and have that do the switching so you don't have to edit all your plugins. Read it from a config or hard coded, you'll have to update by hand.

The sdkhooks weapon switch is not always accurate! Sometimes lunchbox items and such screw with it.
A more reliable method is to check on a timer, preferably comparing active weapon netprop of the client vs the sword. The timer will die out along with the item if you use an entref. Just pass a data timer with client serial and weapon entref.

[Chdata]

^ I really need to make some fockin natives more often.

Oh yeah, when I was working on taunt crits and making something that prevents keeping tauntcrit buff after a weapon switch I noticed the lunchbox items thing. I believe it also happens with custom taunts like high five and all that stuff.

Rather than a timer you can track whether or not a weapon switch occured because someone used a taunt item. Any taunt item that sets m_iTauntItemDefIndexWhateverYouCallIt to something other than -1 will cause a weaponswitch call.

PHP Code:

static g_iTauntItemDefIndex[TF_MAX_PLAYERS] = {-1,...};

public OnClientPostAdminCheck(iClient)
{
    g_iTauntItemDefIndex[iClient] = -1;
    SDKHook(iClient, SDKHook_WeaponSwitchPost, OnWeaponSwitch);
}

//static bool:g_bNoTauntCrits[TF_MAX_PLAYERS] = {false,...};
public Action:OnWeaponSwitch(iClient, iWeapon)
{
    if (g_iTauntItemDefIndex[iClient] == -1)
    {
        g_iTauntStatus[iClient] = TStat_None;
        RequestFrame(OnWeaponSwitchFrame, GetClientUserId(iClient)); // We do it a frame later because... uh...?
        //SDKUnhook(iClient, SDKHook_WeaponSwitchPost, OnWeaponSwitch);
    }
    else
    {
        g_iTauntItemDefIndex[iClient] = -1; // This will happen if someone is using a taunt item such as high five, which fires OnWeaponSwitch once after the taunt is done.
    }
    
    return Plugin_Continue;
}

public OnWeaponSwitchFrame(any:UserId)
{
    new iClient = GetClientOfUserId(UserId);
    if (iClient && IsClientInGame(iClient))
    {
        TF2_RemoveCondition(iClient, TFCond_Buffed);
        TF2_RemoveCondition(iClient, TFCond_CritCanteen);
        s_bTauntCritBuffed[iClient] = false;
        g_iTauntStatus[iClient] = TStat_None;
    }
}

public TF2_OnConditionAdded(iClient, TFCond:iCond)
{
    if (iCond == TFCond_Taunting)
    {
        g_iTauntItemDefIndex[iClient] = GetEntProp(iClient, Prop_Send, "m_iTauntItemDefIndex");
    }
} 


I've had no problems with it for a long time, though I recently stopped unhooking/hooking weaponswitch when I need it so whenever someone does their first tauntcrit after a reconnect, for some reason their taunt crit doesn't work. But every consecutive one will.

I believe it has something to do with the fact that WeaponSwitch is also called when you are equipped with a weapon after spawning and maybe at other times too.

Since soldier doesn't have lunchbox stuff you should be good with the taunt item fix tho.