Raised This Month: $32 Target: $400
 8% 

CSS BRush


Post New Thread Reply   
 
Thread Tools Display Modes
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 01-07-2013 , 23:16   Re: CSS BRush
Reply With Quote #91

Bug I found :

ClientTimer[something] is used by many different timer. If you take ProcessTeam (issued on round end), it creates Timer_ProcessCT. And while a user change team, it also creates a timer, using the same variable (with Timer_HandleTeamSwitch this time).

I really do believe it is an unintended behaviour. i.e. take this scenario :
  • Round end
  • Timer_HandleTeamSwitch starts (user want to switch)
  • ProcessTeam's timer start (due to round end earlier)
  • user crash.
  • PROFITError.

User crashing triggered the ClearTimer on the one created in ProcessTeam, but the one created by Timer_HandleTeamSwitch isn't in any variable (since the variable was shared between different callbacks). Therefore, when executing the function SwitchPlayerTeam (entered via L526, 533 or 538 ), you'll have an invalid client, and then get an error.

So my point is still valid above (and I can't approve this plugin =( ).
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work

Last edited by RedSword; 01-07-2013 at 23:20.
RedSword is offline
TnTSCS
AlliedModders Donor
Join Date: Oct 2010
Location: Undisclosed...
Old 01-08-2013 , 09:30   Re: CSS BRush
Reply With Quote #92

no problem... again, thanks for the time you've dedicated to this plugin... I should have an updated code that does not use ClientTimer[client] but instead passes ClientSerial and then validates the ClientSerial inside the timer code.

I think I learned a good lesson to not use the ClientTimer[client] to handle timers as everyone can see, it can easily get confusing.
__________________
View my Plugins | Donate
TnTSCS is offline
TeamKiller_TK
Junior Member
Join Date: Apr 2009
Old 01-14-2013 , 00:37   Re: CSS BRush
Reply With Quote #93

This is really great plugin! I was using it for a while and i have few suggestions or requests.
  • When T wins the round and players swaps you must restart the round so everyone will have 800 again.
  • After CT's wins 8 rounds not scramble teams, but automatically call a vote for next map !votemap de_inferno de_dust2 de_cbble

Is it possible to make these changes?
TeamKiller_TK is offline
TnTSCS
AlliedModders Donor
Join Date: Oct 2010
Location: Undisclosed...
Old 01-14-2013 , 09:28   Re: CSS BRush
Reply With Quote #94

I can easily implement the 1st one... I'll have to look into an automatic map vote.
__________________
View my Plugins | Donate
TnTSCS is offline
TeamKiller_TK
Junior Member
Join Date: Apr 2009
Old 01-14-2013 , 14:53   Re: CSS BRush
Reply With Quote #95

Quote:
Originally Posted by TnTSCS View Post
I can easily implement the 1st one... I'll have to look into an automatic map vote.
It would be great if you can make these two changes, so players can play on server 24/7 without admin in different maps.

Also it seems like brush.live.cfg is not working or it's just me?

I try to put these settings in cfg file:

Code:
mp_restartgame "1"
mp_startmoney "1000"
sv_alltalk "0"
mp_friendlyfire "0"
mp_roundtime "1"
mp_buytime "2.5"
Brush starts automatically when 8 players join server, but cfg seems not loading cause mp_startmoney remains 800 as server default.
TeamKiller_TK is offline
Lordearon
Member
Join Date: Jan 2013
Location: Vietnam
Old 01-16-2013 , 20:37   Re: CSS BRush
Reply With Quote #96

any chances this gets ported to CS:GO?

what about cspromod?
Lordearon is offline
Dumjaevl
Member
Join Date: Jan 2012
Location: Sweden
Old 03-08-2013 , 18:37   Re: CSS BRush
Reply With Quote #97

When Ts win the round and get switched to CT the money don't change to 800, they have the same money as the last round. Make so the switch involves Death or an restart.
Dumjaevl is offline
TnTSCS
AlliedModders Donor
Join Date: Oct 2010
Location: Undisclosed...
Old 03-10-2013 , 12:11   Re: CSS BRush
Reply With Quote #98

You want both teams to reset back to mp_startmoney amount?
__________________
View my Plugins | Donate
TnTSCS is offline
TnTSCS
AlliedModders Donor
Join Date: Oct 2010
Location: Undisclosed...
Old 03-10-2013 , 12:29   Re: CSS BRush
Reply With Quote #99

I don't have time to test until later today or tomorrow... but if you want to give this one a try and let me know if you notice anything it's up to you.

Change Log:
Code:
0.0.2.4	+	Added fast round restart option with configurable time
* 
0.0.2.5	*	Code adjustment from RedSword's comments in forums.
* 	-	Removed set_random_model to make this plugin CS:GO capable
* 
0.0.2.6	-	Removed waiting list feature
* 	*	Fixed timer to use ClientSerial instead of client value
* 
0.0.2.7	+	Added ability to reset player's cash to mp_startmoney when Ts win
There is a new config file with a few new CVars. I don't think I made any changes to the translation file.

If you use Updater, set the CVar to 0 otherwise this version will be overwritten by the 0.0.2.3.
__________________
View my Plugins | Donate

Last edited by TnTSCS; 10-22-2013 at 10:18.
TnTSCS is offline
TnTSCS
AlliedModders Donor
Join Date: Oct 2010
Location: Undisclosed...
Old 03-17-2013 , 12:03   Re: CSS BRush
Reply With Quote #100

eh - I found some issues with management of bots - I'll work on the bugs and post a new version as soon as I can.
__________________
View my Plugins | Donate
TnTSCS is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 12:19.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode