[nikhilgupta345]

Fixed. I updated what you meant by players[i], and what I thought you meant by the countries[id] is to copy it to another array and use that instead of calling countries[id] every time.

[ConnorMcLeod]

Ok, to be honest, i'm not really sure of what is better, cache countries[id] and then need to send copy native, or not cache it and save 1 native.
Chat is not often called so it's not really important.

Code is ok now, approved.

You could consider using charsmax (doesn't change plugin performances at all, but if you change array size one day you will thanks me) :

PHP Code:

    get_user_ip( id, ips[id], 30 );
    geoip_country( ips[id], countries[id], 45 );
}

public cmdSay( id )
{
    
    if( !equali( countries[id], "error" ) )
    {
        new message2[200];
        read_args( message2, 199 ); 


->

PHP Code:

    get_user_ip( id, ips[id], charsmax(ips[]) );
    geoip_country( ips[id], countries[id], charsmax(countries[]) );
}

public cmdSay( id )
{
    
    if( !equali( countries[id], "error" ) )
    {
        new message2[200];
        read_args( message2, charsmax(message2) ); 


[nikhilgupta345]

K will fix that, but usually too lazy to type charsmax out

EDIT: Fixed

[ConnorMcLeod]

When i write plugins, i sometimes put a macro at top of sma, same as charsmax macro :

#define cm(%0) ( sizeof(%0) - 1 )


If i plain to release the plugin i do replace all cm -> charsmax and delete macro ;)

[nikhilgupta345]

Never thought of that. That's a good idea

I'll use that next time I use charsmax. Thanks

[nikhilgupta345]

I was thinking of adding languages to this plugin since that many people from different countries speak the same language, but I would like to know what languages you would like placed in there.