[Craxor]

You didn't make all the changes, also HasFlags macross should have more tabulations in order to be arranged like all ( also Ham_Player_ResetSpeed require some tabulations in plus ).

You didn't make make the '1'.

Also i see you have lot of variables with size '33' you can make an enum and insert size with Max Players + 1, check my Heart Health to see 'how' to do that.

Also you should remove all 'stock' from all your stocks , like you done with Save and Load functions, just look all the same.

Also you should test by yourself because is your plugin and the most important: do not post the realease until you test and see by yourself everything is working.

Just copy them from here:

#define TASK_CHECK 			200020
#define TASK_KILLME 			200021
#define TASK_COUNTDOWN 			200022
#define TASK_COUNTDOWNINVIS 		200023
#define TASK_SHOWLMS 			200024

#define HasFlags(%1)        		(get_user_flags(%1) & ACCESS)

#define Ham_Player_ResetMaxSpeed 	Ham_Item_PreFrame

#define fm_cs_set_weapon_ammo(%1,%2)	set_pdata_int(%1, OFFSET_CLIPAMMO, %2, OFFSET_LINUX_WEAPONS)

#define cmx(%1) 			(sizeof(%1) - 1)
#define play_sound(%1,%2,%3) 		emit_sound(%1,CHAN_ITEM,%2,VOL_NORM,ATTN_NORM,0,%3)

#define INVALID_WEAPONS 		((1<<CSW_KNIFE)|(1<<CSW_HEGRENADE)|(1<<CSW_FLASHBANG)|(1<<CSW_SMOKEGRENADE)|(1<<CSW_C4))
#define SPRITE_LASER 			"sprites/lgtning.spr"

#define MAX_COLORS	 		6

const m_pPlayer = 			41
const OFFSET_LINUX_WEAPONS =		4
const m_pActiveItem =			373
const OFFSET_CLIPAMMO =			51

new const szPrefix[]  = 		"!g[LaserMod]!y:"

[EFFx]

I already have tested it by myself. But others peoples can get bugs...

Originally Posted by Craxor You didn't make all the changes, also HasFlags macross should have more tabulations in order to be arranged like all ( also Ham_Player_ResetSpeed require some tabulations in plus ).

What tabulations are u meaning?

[Craxor]

Just copy mine to be exactly like as they should be arranged.

[EFFx]

You mean removing the ACCESS ?

PHP Code:

#define HasFlags(%1) (get_user_flags(%1) & ADMIN_CVAR) 


[Craxor]

no man , i'm talking only about indentation.

Read again my replies an try to understand them, where you can't understand ask my again.

[EFFx]

Man, I already have readed all your replies. I'll post my new code again, if you have some edits for tell me to make, please, say it.

[Craxor]

1. I find again some of them who are not-arranged, copy them again from here:

new const PLUGIN[] = "Laser"
new const VERSION[] =  "1.3"
new const AUTHOR[] =  "EFFx"

#define HasFlags(%1)       		(get_user_flags(%1) & ADMIN_CVAR)
#define fm_cs_set_weapon_ammo(%1,%2)	set_pdata_int(%1, OFFSET_CLIPAMMO, %2, OFFSET_LINUX_WEAPONS)
#define cmx(%1) 			(sizeof(%1) - 1)
#define play_sound(%1,%2,%3) 		emit_sound(%1,CHAN_ITEM,%2,VOL_NORM,ATTN_NORM,0,%3)

const Ham:Ham_Player_ResetMaxSpeed =	Ham_Item_PreFrame
const MAX_COLORS =	 		6
const m_pPlayer = 			41
const OFFSET_LINUX_WEAPONS =		4
const m_pActiveItem =			373
const OFFSET_CLIPAMMO =			51
const TASK_CHECK =			200020
const TASK_KILLME = 			200021
const TASK_COUNTDOWN = 			200022
const TASK_COUNTDOWNINVIS = 		200023
const TASK_SHOWLMS = 			200024
const INVALID_WEAPONS = 		( (1 << CSW_KNIFE ) | ( 1 << CSW_HEGRENADE ) | ( 1 << CSW_FLASHBANG ) | ( 1 << CSW_SMOKEGRENADE ) | ( 1 << CSW_C4 ) )
const MaxPlayers = 			32

new const SPRITE_LASER[] = 		"sprites/lgtning.spr"
new const sound_laseron[] = 		"items/nvg_on.wav"
new const sound_buy[] = 		"items/gunpickup2.wav"
new const sound_jump[] = 		"weapons/rocketfire1.wav"
new const sound_fallen[] =		"player/pl_pain4.wav"

new const szPrefix[]  = 		"!g[LaserMod]!y:"

2. open the vault in plugin_init insteand of calling plugin_cfg, anyway it is the same thing but i may prefer there.

3. About szAuthId, not like that, your variable declaration should look like that:

PHP Code:

new szAuthId[33][34] 


And usage:

PHP Code:

SaveLms( id ) 
{ 
    get_user_authid( id, szAuthid[id], cmx( szAuthid ) ) 
    
    new szData[11];
    num_to_str( get_user_lm(id) , szData, cmx( szData ) )

    nvault_set( nVaultSaveLM, szAuthid[id], szData ) 
} 

LoadLms( id ) 
{ 
    get_user_authid( id, szAuthid[id], cmx( szAuthid ) ) 

    set_user_lm(id, 0, nvault_get( nVaultSaveLM, szAuthid[id] ) )
} 


4.
Here:

PHP Code:

menu_additem(iMenu,"Orange") 


You could make a const list:

PHP Code:

new const szColors[] [] = 
{
    "Orange",
    "Green",
    "Blue",
    "White",
    "Purple",
    "Yellow"

} 


Then make a loop to create all the items with the items from the list:

PHP Code:

    if(is_user_alive(id))
    {
        new iMenu = menu_create("Laser Color \w( \r/lcmenu \w)","laser_colors_handler")
        
        for( new i = 0 ; i < sizeof szColors; i++ )
        {
            menu_additem( iMenu, szColors[i] )
        }
        
        menu_display(id,iMenu)
    } 


5. In the public laser_colors_handler(id,menu,item) at the end you're re-creating the menu once calling the public OpenLcMenu(id) at the end , better use menu_display( ) again.

6. in shot_laser(ent), you're doing that:

PHP Code:

for(new player = 1;player <= iMaxPlayers;player++)
    { 


To touch al the players ids, don't do that, use get_players() ( the same problem at CheckBug() public ).

7. Make an enum also for szAuthid, lm and count downs variables, they have the same size no ?

PHP Code:

enum _:PlayerPrivateDatas
{
    Lm,
    CountDown,
    CountDOwnInvis,
    szAuthId[34]
}
new PrivatePlayerData[PlayerPrivateDatas][MaxPlayers+1] 


also szAuthId is 34 not 32.

8. If you take the user auth id steam in the client_authorized, don't do that also in Load or save functions, that's the point of szAuthId variable, to take steamid just once, not in all your publics:

PHP Code:

SaveLms( id ) 
{     
    new szData[11];
    num_to_str( get_user_lm(id) , szData, cmx( szData ) )

    nvault_set( nVaultSaveLM, szAuthid[id], szData ) 
} 

LoadLms( id ) 
{  
    set_user_lm(id, 0, nvault_get( nVaultSaveLM, szAuthid[id] ) )
} 


[EFFx]

1.

PHP Code:

const Ham_Player_ResetMaxSpeed =    Ham_Item_PreFrame 


It should be #define

Welcome to the AMX Mod X 1.8.1-300 Compiler.
Copyright (c) 1997-2013 ITB CompuPhase, AMX Mod X Team

Warning: Tag mismatch on line 20
Warning: Tag mismatch on line 160
Header size:           3432 bytes
Code size:            28580 bytes
Data size:            23604 bytes
Stack/heap size:      16384 bytes; estimated max. usage=781 cells (3124 bytes)
Total requirements:   72000 bytes

2 Warnings.
Done.

All things updated

8. I should do it or the 3?

[Craxor]

Sorry, should be like this:

PHP Code:

const Ham:Ham_Player_ResetMaxSpeed =    Ham_Item_PreFrame 


[Craxor]

Forgot about 3, i just posted to show you're using wrong szAuthid, should be szAuthid[id], anyway, better take in consideration 7 and 8.