[micapat]

Well, here is the big question .

To check for example the player state (Alive or dead) or cvars values in "heavy" functions (OnGameFrame, OnPlayerRunCmd, Timer100ms,...), is it better to remember the value using a global variable (+ Some hooks to detect when the real value has changed) or to use directly the natives (IsPlayerAlive, ...)?

I'm mainly talking in terms of performance (Memory shouldn't be an issue) and in case of a complex server using multiple plugins (Like a zombie mode for example).

------------
Under Amxmodx, lot of developpers were doing like above using global variables, even for "light" functions (OnTakeDamage, OnWeaponSwitch,...), but is it the same for SourceMod?

[ddhoward]

In general, you shouldn't worry about it. Just use the functions.

[micapat]

Even for OnGameFrame? With a loop on all the players?

[Neuro Toxin]

Yes

[ddhoward]

Unless you're doing something absolutely insane, like creating and filling thousands of arrays per frame.

[Timocop]

Globals/Statics are always faster. But replacing natives with cached values are not always optimal and not realy necessary. If you use arrays like strings in fequent loops or calls (like OnGameFrame()) you may want to use "static" instead of the standart declaration, because it doesnt need to initalize everytime. Which will save some CPU but increases memory and file size.

Well, just stick to natives instead of caching values. Unless you realy need to, like caching an entity reference because you need it later.

Switch to globals/statics (only non-recursive functions!):

PHP Code:

public void OnGameFrame()
{
    static i;
    for(i = 0; i < 2048; i++)
    {
        //...
        static char classname[64];
        GetEntityClassname(i, classname, sizeof classname);
        //...
    }
} 


Variable first, rest second. Use variables first in statements, dont do unessescary calls.

PHP Code:

for(int i = 0; i < 2048; i++)
{
    if(!g_bIsCustomCar[i] || !IsEntityValid(i))
        continue;
    //...
} 


[micapat]

Ok, thanks!

Btw, is there not something like this for SourceMod: https://wiki.alliedmods.net/Optimizi...d_X_Scripting) ?
It could be nice to have something similar to give the "good pratices".

[Timocop]

https://wiki.alliedmods.net/Optimizi...Mod_Scripting)

[headline]

Originally Posted by micapat Ok, thanks! Btw, is there not something like this for SourceMod: https://wiki.alliedmods.net/Optimizi...d_X_Scripting) ? It could be nice to have something similar to give the "good pratices".

Here's some good ones:

• Avoid using OnGameFrame.
• If you're looping players in OnGameFrame, see if you can use OnPlayerRunCmd instead.
• Avoid looping all entities, use FindEntityByClasname if applicable.

[ddhoward]

Originally Posted by Timocop https://wiki.alliedmods.net/Optimizi...Mod_Scripting)

A lot of that is outdated. decl, for example, doesn't exist in the new syntax.