[deprale]

PHP Code:

//AMXX 1.8.2
#define TAG "PASS"
new emptypass;

public plugin_init()
{
    //pass check
    emptypass = get_cvar_pointer( "sv_password" );
}

public client_disconnect(id)
{
set_task(5.0, "aremovepass", _, _, _, "a", 1);
}

public aremovepass()
{
    new curpass[32];
    get_pcvar_string(emptypass, curpass, 31);
    if((get_playersnum() == 0) && (strlen(curpass)<1)) 
    {
        set_cvar_string("sv_password","");
        ColorChat(0, RED, "%s Password has been removed.", TAG);
    }
} 


My objective: Setting cvar sv_password to "" when the last player has disconnected from a password protected server!

I tried learning from some old sources, but I failed miserably each time, I tried also with get_players() and getting players from CT/T/SPECTATOR/UNASSIGNED, created a variable summing all the 4 teams up. The same result, the password does NOT get removed.


Any tips are appreciated, thanks!

UMM(EDIT): I also tried using client_remove

[HamletEagle]

What is the point of strlen(curpass) < 1?

[Bugsy]

PHP Code:

#include <amxmodx>

#define TAG "PASS"

new emptypass;

public plugin_init()
{
    emptypass = get_cvar_pointer( "sv_password" );
}

public client_disconnect( id )
{
    //if you need a task to execute one time then you do not need any flags.
    //set_task(5.0, "aremovepass", _, _, _, "a", 1);
    set_task( 5.0 , "aremovepass" );
}

public aremovepass()
{
    new curpass[ 32 ];
    get_pcvar_string( emptypass , curpass , charsmax( curpass ) );
    
    //If you want to set the password from something to nothing, then you need to check if the len is currently > 0, not less than 1.
    //An alternative way, avoiding a native call, is to just check if the first character is null.
    //if((get_playersnum() == 0) && (strlen(curpass)<1)) 
    
    //If
    // No players currently connnected
    // AND
    // current password is not ""
    if ( ( get_playersnum() == 0 ) && ( curpass[ 0 ] != EOS ) )
    {
        set_cvar_string("sv_password","");
        ColorChat(0, RED, "%s Password has been removed.", TAG);
    }
} 


[deprale]

Originally Posted by HamletEagle What is the point of strlen(curpass) < 1?

To check if there is a password > execute code.
Otherwise just save memory, I guess?

[deprale]

Originally Posted by Bugsy PHP Code: #include <amxmodx> #define TAG "PASS" new emptypass; public plugin_init() {     emptypass = get_cvar_pointer( "sv_password" ); } public client_disconnect( id ) {     //if you need a task to execute one time then you do not need any flags.     //set_task(5.0, "aremovepass", _, _, _, "a", 1);     set_task( 5.0 , "aremovepass" ); } public aremovepass() {     new curpass[ 32 ];     get_pcvar_string( emptypass , curpass , charsmax( curpass ) );          //If you want to set the password from something to nothing, then you need to check if the len is currently > 0, not less than 1.     //An alternative way, avoiding a native call, is to just check if the first character is null.     //if((get_playersnum() == 0) && (strlen(curpass)<1))           //If     // No players currently connnected     // AND     // current password is not ""     if ( ( get_playersnum() == 0 ) && ( curpass[ 0 ] != EOS ) )     {         set_cvar_string("sv_password","");         ColorChat(0, RED, "%s Password has been removed.", TAG);     } }

Thank you very much, I'm gonna test it right now, I love how you commented everything.
I suppose EOS means End Of String? If so, it makes sense because if current pass DOES NOT EQUAL to nothing then it goes forwards, thanks, just learned something new!

P.S: Sorry for double-posting, won't happen again, I thought I was editing the reply above! Woops

EDIT: Doesn't work Compiles just fine, after I type disconnect in console after setting up a password it just won't set it to nothing!

EDIT2: FIXED. Everything was fine before. Thanks everyone!

[Bugsy]

Yeah, your original code was pretty much good, except for the len check.

if((get_playersnum() == 0) && (strlen(curpass)<1))

[deprale]

Thanks again Bugsy, you've been of great help!

[HamletEagle]

Originally Posted by deprale To check if there is a password > execute code. Otherwise just save memory, I guess?

No. You are checking if the password is empty(strlen < 1 means the string has 0 characters) => no password. The check should be reversed, meaning strlen >= 1 or simply check if first char is not EOS, as suggested before.

This:

PHP Code:

set_cvar_string("sv_password",""); 


Should be

PHP Code:

set_pcvar_string(emptypass, ""); 


You already got the cvar pointer, so no reason to use the slow set_cvar_* natives.

PHP Code:

 ColorChat(0, RED, "%s Password has been removed.", TAG); 


Isn't this totally useless? It will be displayed when the server is empty - no one can see the message.

[deprale]

Originally Posted by HamletEagle No. You are checking if the password is empty(strlen < 1 means the string has 0 characters) => no password. The check should be reversed, meaning strlen >= 1 or simply check if first char is not EOS, as suggested before. This: PHP Code: set_cvar_string("sv_password","");  Should be PHP Code: set_pcvar_string(emptypass, "");  You already got the cvar pointer, so no reason to use the slow set_cvar_* natives. PHP Code:  ColorChat(0, RED, "%s Password has been removed.", TAG);  Isn't this totally useless? It will be displayed when the server is empty - no one can see the message.

1. Wow, thanks, I've put emptypass instead of sv_password
2. Yeah, I removed the ColorChat line as well, it was just for debugging purposes, edited it into being a console (and log) message.

Thanks, HamletEagle!