Raised This Month: $51 Target: $400
 12% 

Bomb Real Timer


Post New Thread Reply   
 
Thread Tools Display Modes
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 08-23-2022 , 05:28   Re: Bomb Real Timer
Reply With Quote #11

Quick suggestions:
1. The entire code (including comments) must be in English.
2. Configuration options must not be hardcoded inside the plugin. Use cvars instead of defines.
3. Do not use fm_* macros, use the fakemeta functions directly.
4. 41/* m_pPlayer */ do not use magic numbers, properly name the offsets. Create a definition for it as you did for the other offsets (for example m_flC4Blow)
5. Indent the code properly.
6. "stock" should never be used in sma files, only in include files. stock means optional, but everything that is in a plugin source file should be used.
7. Inside get_loguser_index use new, not static.
__________________

Last edited by HamletEagle; 08-23-2022 at 05:31.
HamletEagle is offline
MayroN
Senior Member
Join Date: Aug 2017
Location: Kyiv
Old 09-04-2022 , 17:23   Re: Bomb Real Timer
Reply With Quote #12

Quote:
Originally Posted by HamletEagle View Post
Quick suggestions:
1. The entire code (including comments) must be in English.
2. Configuration options must not be hardcoded inside the plugin. Use cvars instead of defines.
3. Do not use fm_* macros, use the fakemeta functions directly.
4. 41/* m_pPlayer */ do not use magic numbers, properly name the offsets. Create a definition for it as you did for the other offsets (for example m_flC4Blow)
5. Indent the code properly.
6. "stock" should never be used in sma files, only in include files. stock means optional, but everything that is in a plugin source file should be used.
7. Inside get_loguser_index use new, not static.
Everything is done according to the requirements.
Updated the first post.
__________________
МультиМод CS 83.222.97.124:27015


Last edited by MayroN; 09-10-2022 at 20:24.
MayroN is offline
Send a message via ICQ to MayroN Send a message via Skype™ to MayroN
MayroN
Senior Member
Join Date: Aug 2017
Location: Kyiv
Old 09-12-2022 , 09:47   Re: Bomb Real Timer
Reply With Quote #13

UP
__________________
МультиМод CS 83.222.97.124:27015

MayroN is offline
Send a message via ICQ to MayroN Send a message via Skype™ to MayroN
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 06:32.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode