[Silvers]

Originally Posted by finishlast Strange, when I change g_timer = CreateTimer(0.1, gate, _, TIMER_REPEAT | TIMER_FLAG_NO_MAPCHANGE); to g_timer = CreateTimer(0.1, gate, _, TIMER_REPEAT); it would still run after changing map to same map. ***** Just to not get confused, when I have another plugin that uses a g_timer, that wouldn't interfear bc of the same name or? ***** Is there a function for checking valid client indexes?! My wife would yell now RTFM, I guess she is right

Wouldn't interfere. Do "delete g_timer" in OnMapEnd to stop it. Or if you use the TIMER_FLAG_NO_MAPCHANGE flag set "g_timer = null" in OnMapEnd.

[finishlast]

That's what I was trying with:

PHP Code:

public void OnPluginStart()
{
    HookEvent("round_freeze_end", event_round_freeze_end, EventHookMode_PostNoCopy);
    HookEvent("round_end", event_round_end, EventHookMode_PostNoCopy);
}

public void OnMapEnd()
{
delete g_timer;
}

public void event_round_end(Event event, const char[] name, bool dontBroadcast)
{
delete g_timer;
} 


wonder what is wrong

I updated the script in second post

When I remove TIMER_FLAG_NO_MAPCHANGE it just keeps running.

[Silvers]

Duplicate plugin running?

[finishlast]

I put it on a server without those plugins but it still shows the behavior.

I put a

PrintToChatAll ("DELETE");

to see if it reaches the delete part

PHP Code:

public void OnMapEnd()
{
PrintToChatAll ("DELETE1");
delete g_timer;
}

public void event_round_end(Event event, const char[] name, bool dontBroadcast)
{
PrintToChatAll ("DELETE2");
delete g_timer;
} 


When I start the event and !slay @all

It reads DELETE2

When the game resets the lift is still going up.

[azalty]

Originally Posted by finishlast I put it on a server without those plugins but it still shows the behavior. I put a PrintToChatAll ("DELETE"); to see if it reaches the delete part PHP Code: public void OnMapEnd() { PrintToChatAll ("DELETE1"); delete g_timer; } public void event_round_end(Event event, const char[] name, bool dontBroadcast) { PrintToChatAll ("DELETE2"); delete g_timer; }  When I start the event and !slay @all It reads DELETE2 When the game resets the lift is still going up.

You're setting the timer's handle to null while asking it to continue inside the timer's function.

In that case, deleting g_timer won't do anything since g_timer is null. The timer is still going though.

g_timer = null;
return Plugin_Continue;

change to

return Plugin_Continue;

Only set the timer handle to null when you're killing the timer.

- In short: -
Inside the timer's function:

g_timer = null;
return Plugin_Stop;

Outside of the timer's function:

delete g_timer;

[finishlast]

Oh, now I see, I understood it wrong.

Now it is working as intended without TIMER_FLAG_NO_MAPCHANGE.

Thanks a lot guys, you are great.

[HarryPotter]

I usually delete timer when
1. OnMapEnd()
2. round end

PHP Code:

    HookEvent("round_end", evtRoundEnd); //round end, trigger when versus mode first round & second round end
    HookEvent("map_transition", evtRoundEnd); //mission complete in coop/realism, won't trigger "round_end"
    HookEvent("mission_lost", evtRoundEnd); //mission failed in coop/realism, will trigger "round_end"
    HookEvent("finale_vehicle_leaving", evtRoundEnd); //final rescue vehicle leaving, won't trigger "round_end" 


[azalty]

Originally Posted by HarryPotter I usually delete timer when 1. OnMapEnd() or you can use TIMER_FLAG_NO_MAPCHANGE 2. OnPluginEnd() 3. round end PHP Code:     HookEvent("round_end", evtRoundEnd); //round end, trigger when versus mode first round & second round end     HookEvent("map_transition", evtRoundEnd); //mission complete in coop/realism, won't trigger "round_end"     HookEvent("mission_lost", evtRoundEnd); //mission failed in coop/realism, will trigger "round_end"     HookEvent("finale_vehicle_leaving", evtRoundEnd); //final rescue vehicle leaving, won't trigger "round_end"

Do not use TIMER_FLAG_NO_MAPCHANGE if you save the timer handle in a variable, because that will cause you to store a handle pointing to nothing, which could cause errors

When the plugin is unloaded, any variable that it registered, any handle (and the object they are pointing to) created by the plugin is deleted, and the memory the plugin uses is freed automatically. This means timers will be automatically killed too, there is no need to do anything inside OnPluginEnd() in 99,9% cases

[HarryPotter]

Originally Posted by azalty When the plugin is unloaded, any variable that it registered, any handle (and the object they are pointing to) created by the plugin is deleted, and the memory the plugin use is freed automatically. This means timers will be automatically killed too, there is no need to do anything inside OnPluginEnd() in 99,9% cases

Oh, I see, thank you