[Miu]

just swap the arrays around when they reconnect? o.o

[aexi0n]

Alright threw together some semi-psuedo code as to implementing the ADT Trie things. Am I using them correctly?

PHP Code:

//Example Player Data Variables
enum Player
{
    Level,
    XP
}

new g_info[MAXPLAYERS+1][Player];
new g_mapchange[MAXPLAYERS+1][Player];

// Handle to my trie. 
new Handle:MapChangeTrie;

//Hook Scoreboard Event To Save Data Prior To Mapchange
HookEvent("cs_win_panel_match", event_endmap, EventHookMode_Pre);

//Create Trie
OnPluginStart()
{
    MapChangeTrie = CreateTrie();
}

//Map Is About To Change, Store Player Data In Trie
public Action:event_endmap(Handle:event, const String:name[], bool:dontBroadcast)
{
    decl String:steamid[64];
    
    for(new i = 1; i <= MaxClients; i++)
    {
        if(!IsFakeClient(i))
        {
            //Get Player SteamID for Trie Name
            GetClientAuthString(i, steamid, sizeof(steamid));
            
            //Store Player Data
            g_mapchange[i][Level] = g_info[client][Level];
            g_mapchange[i][XP] = g_info[client][XP];
            
            //Save Name To Index
            SetTrieValue(MapChangeTrie, steamid, i);
        }
    }
}

//Client Re-Connecting From Map Change, Restore Data From Trie
public OnClientPostAdminCheck(client)
{
    new TrieIndex = -1;
    
    decl String:steamid[64];
    
    GetTrieValue(MapChangeTrie, steamid, TrieIndex);
    
    if(TrieIndex >= 0)
    {
        g_info[client][Level] = g_mapchange[TrieIndex][Level];
        g_info[client][XP] = g_mapchange[TrieIndex][XP];
    }
    else
    {
        LoadPlayerData(client);
    }
} 


[WildCard65]

Originally Posted by aexi0n Alright threw together some semi-psuedo code as to implementing the ADT Trie things. Am I using them correctly? PHP Code: //Example Player Data Variables enum Player {     Level,     XP } new g_info[MAXPLAYERS+1][Player]; new g_mapchange[MAXPLAYERS+1][Player]; // Handle to my trie.  new Handle:MapChangeTrie; //Hook Scoreboard Event To Save Data Prior To Mapchange HookEvent("cs_win_panel_match", event_endmap, EventHookMode_Pre); //Create Trie OnPluginStart() {     MapChangeTrie = CreateTrie(); } //Map Is About To Change, Store Player Data In Trie public Action:event_endmap(Handle:event, const String:name[], bool:dontBroadcast) {     decl String:steamid[64];          for(new i = 1; i <= MaxClients; i++)     {         if(!IsFakeClient(i))         {             //Get Player SteamID for Trie Name             GetClientAuthString(i, steamid, sizeof(steamid));                          //Store Player Data             g_mapchange[i][Level] = g_info[client][Level];             g_mapchange[i][XP] = g_info[client][XP];                          //Save Name To Index             SetTrieValue(MapChangeTrie, steamid, i);         }     } } //Client Re-Connecting From Map Change, Restore Data From Trie public OnClientPostAdminCheck(client) {     new TrieIndex = -1;          decl String:steamid[64];          GetTrieValue(MapChangeTrie, steamid, TrieIndex);          if(TrieIndex >= 0)     {         g_info[client][Level] = g_mapchange[TrieIndex][Level];         g_info[client][XP] = g_mapchange[TrieIndex][XP];     }     else     {         LoadPlayerData(client);     } }

Your forgetting to get the client's steamid before calling GetTrieValue. Also GetTrieValue returns a bool(true on success, false if key isn't found/value at key is a string or an array).

[dilalmon]

asherkin mentioned the client indexes can change before, but I have never experienced this.

I made a little fail-safe measure where it would store client's SteamID in a cache (string) and check after every map change (OnPostAdminCheck) if their current SteamID is the same as the cache.
The cache is only cleared at player_disconnect.
If the check ever fails, it would log in a specified log file. I never got this.

So if client indexes ever change, I think it still fires player_disconnect.

[psychonic]

Do not rely on client indexes not changing. Them staying the same is not an API guarantee and there are indeed cases where they can change.

Additionally, don't rely on the player_disconnect event being available, as not only are there corner cases in the engine where it will not fire, but plugin can also completely block other plugins from seeing it (by returning Plugin_Stop in a pre-hook on the event).

[dilalmon]

Any example cases where they could change?

[Disowned]

Originally Posted by asherkin It doesn't any more. That entire section was very wrong.

Any possibility we could get accurate information on this then? I thought that a userid will stay consistent across maps, as you will find servers well into the hundreds of userid numbers. Or is this only accurate per map?

[Powerlord]

Originally Posted by Disowned Any possibility we could get accurate information on this then? I thought that a userid will stay consistent across maps, as you will find servers well into the hundreds of userid numbers. Or is this only accurate per map?

userids don't change until a client disconnects.

userids can repeat if your server is up long enough without rebooting. This is because they are stored as a 16-bit number, meaning they go from 0 (never used) to 65535... and then repeat.

I do vaguely remember hearing that they only went up to 32767 rather than 65535, but I've never tested that to check.