[Potato Uno]

Originally Posted by Peace-Maker This should be validated in the VM.

This is a horrible idea. I don't want my server to be wasting CPU time (at the location where it matters the absolute most) validating binaries during bytecode execution just because a minority < 1% of smx files ever made were purposely malformed.

[WildCard65]

Originally Posted by Potato Uno This is a horrible idea. I don't want my server to be wasting CPU time (at the location where it matters the absolute most) validating binaries during bytecode execution just because a minority < 1% of smx files ever made were purposely malformed.

You posted your opinion a little to late I'm afraid (It was already merged into SP which will eventually be merged into SM 1.9): https://github.com/alliedmodders/sou...2b398e620634ce

[Potato Uno]

Well it looks like I am not upgrading to 1.9 unless Valve does something that really breaks 1.8 for good.

The paused plugin spam is bad enough but avoidable. The VM wasting CPU cycles pointlessly trying to break plugins I will never run is even worse. It probably will only get worse from now on as they continue to bolt in more validation to the JIT just to break like 0.1% of smx files ever made.

If license violators are smart enough to still break Lysis to this day, they will be smart enough to thwart anything the SM teams put in the VM. It's a cat and mouse situation that only will end up hurting everybody who uses SM. The real solutions (and not monkey patches) is to ditch the smx format and make the server compile source code every time it starts up.

[asherkin]

You are over reacting, the method verifier is not expensive and only run once with the rest of the verification checks (which have been there a long time). It is necessary to protect against corrupt plugins just as much as intentional tampering.

I can assure you that compiling from source at runtime will take a lot longer that some basic static analysis. Loading from source was ruled out a long time ago until we have spcomp2.

[Danyas1337]

Hello again, i need some help with decompile.
EventWeaponFire wont decompilling, wanna to see what in this function

[Maxximou5]

Originally Posted by Danyas1337 Hello again, i need some help with decompile. EventWeaponFire wont decompilling, wanna to see what in this function

See https://forums.alliedmods.net/showpo...&postcount=338

[Bara]

Originally Posted by Maxximou5 Decompiled with SPEdit. Edit: You should download SPEdit so you can do this yourself, since you've asked a few times now. https://forums.alliedmods.net/showthread.php?t=259917

That's useless...

} /* ERROR! Unable to cast object of type 'Lysis.DJump' to type 'Lysis.DJumpCondition'. */ function "EventWeaponFire" (number 42) /* ERROR! Unable to cast object of type 'Lysis.DJump' to type 'Lysis.DJumpCondition'. */ function "OnPlayerRunCmd" (number 43) public int OnPreThinkPost(int client)

[Peace-Maker]

The version of the C# implementation of Lysis in SPEdit is from a really old version of Lysis and shouldn't be called "improved". Why did you post that output which explicitly lacks the function he asked for and defend it?

PHP Code:

public Action:EventWeaponFire(Handle:event, String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    new var1;
    if (IsAdmin[client] && g_iNoFlash[client])
    {
        SetEntDataFloat(client, g_iFlashAlpha, 0.5, false);
    }
    new m_Offset = FindSendPropOffs("CCSPlayer", "m_iTeamNum");
    new Float:angles[3] = 0.0;
    new var5 = view_angles[client];
    angles = var5;
    if (Aimbot[client])
    {
        new i;
        while (AimbotMulti[client] >= i)
        {
            new cnt = 1;
            while (cnt <= MaxClients)
            {
                new t1;
                new t2;
                if (IsClientInGame(cnt))
                {
                    t1 = GetEntData(client, m_Offset, 4);
                    t2 = GetEntData(cnt, m_Offset, 4);
                    if (!(IsClientObserver(cnt)))
                    {
                        if (IsPlayerAlive(cnt))
                        {
                            if (!(t2 == t1))
                            {
                                new var2;
                                if (!(t2 == 2 || t2 == 3))
                                {
                                    if (!(client == cnt))
                                    {
                                        new Float:p1[3] = 0.0;
                                        new Float:p2[3] = 0.0;
                                        new Float:p3[3] = 0.0;
                                        GetClientEyePosition(client, p1);
                                        GetClientEyePosition(cnt, p2);
                                        TR_TraceRayFilter(p1, p2, 33636363, RayType:0, TraceRayDontHitSelf, client);
                                        new var3;
                                        if (!(TR_GetFraction(Handle:0) < 1064682127 && cnt != TR_GetEntityIndex(Handle:0) && AimT[client]))
                                        {
                                            new Float:delta[3] = 0.0;
                                            delta[0] = p1[0] - p2[0];
                                            delta[1] = p1[1] - p2[1];
                                            delta[2] = p1[2] - p2[2];
                                            new Float:hyp = SquareRoot(delta[0] * delta[0] + delta[1] * delta[1]);
                                            p3[0] = ArcTangent(delta[2] / hyp) * 180 / 3.141;
                                            p3[1] = ArcTangent(delta[1] / delta[0]) * 180 / 3.141;
                                            p3[2] = 0.0;
                                            if (delta[0] >= 0.0)
                                            {
                                                p3[1] += 180.0;
                                            }
                                            new var4;
                                            if (!(FloatAbs(p3[0] - angles[0]) > aFov[client] || FloatAbs(p3[1] - angles[1]) > aFov[client]))
                                            {
                                                if (Aimbot[client] == 2)
                                                {
                                                    new int:dmgt = 2;
                                                    aimbot_event = cnt;
                                                    if (GetRandomFloat(0.0, 1.0) > HeadChance[client])
                                                    {
                                                        HeadChanceF[client] = 0;
                                                    }
                                                    else
                                                    {
                                                        HeadChanceF[client] = 1;
                                                    }
                                                    if (!(AimChance[client] < GetRandomFloat(0.0, 1.0)))
                                                    {
                                                        SDKHooks_TakeDamage(cnt, client, client, GetDmg(client, cnt), dmgt, -1, NULL_VECTOR, NULL_VECTOR);
                                                        i++;
                                                    }
                                                    cnt++;
                                                }
                                            }
                                            cnt++;
                                        }
                                        cnt++;
                                    }
                                    cnt++;
                                }
                                cnt++;
                            }
                            cnt++;
                        }
                        cnt++;
                    }
                    cnt++;
                }
                cnt++;
            }
            i++;
        }
    }
    return Action:0;
} 


Something like this.

[Maxximou5]

Originally Posted by Peace-Maker The version of the C# implementation of Lysis in SPEdit is from a really old version of Lysis and shouldn't be called "improved". Why did you post that output which explicitly lacks the function he asked for and defend it?

You're right. I did not fully realize that, my mistake. However, I did not defend state such a thing or make such a claim towards it being "improved".

[Peace-Maker]

Originally Posted by Maxximou5 You're right. I did not fully realize that, my mistake. However, I did not defend state such a thing or make such a claim towards it being "improved".

Yes, it just says that the decompiler is "improved" in SPEdit's thread. Just wanted to make this clear, since you use it.
You kinda defended your output in the response to Bara, which you deleted now. But nevermind.