[klippy]

Originally Posted by PRoSToTeM@ But natives don't support returning arrays, it can be done only with workarounds.

https://forums.alliedmods.net/showthread.php?p=2379856
Unless you are referring to that as a workaround.

However, returning arrays should be avoided in most cases as it introduces copies of the whole array, of course affecting performance, especially for large arrays.

[Craxor]

Because is to lazy to use charsmax

[PRoSToTeM@]

Originally Posted by KliPPy https://forums.alliedmods.net/showthread.php?p=2379856 Unless you are referring to that as a workaround.

I mean plugin natives.

Originally Posted by KliPPy However, returning arrays should be avoided in most cases as it introduces copies of the whole array, of course affecting performance, especially for large arrays.

It works without copying if it is inlined like this:

server_print("%s", GetPlayerName(player));

[klippy]

Originally Posted by PRoSToTeM@ It works without copying if it is inlined like this: server_print("%s", GetPlayerName(player));

To me it looks like it still copies 1 time (out of the called function), just tried it. When assigning it copies 2 times. Try using amxxdump and check it out. It's always faster to just pass a reference.

[CrazY.]

Originally Posted by Craxor Because is to lazy to use charsmax

Ah haha

[Craxor]

He say 'it works' not that is the better way to do that.

[PRoSToTeM@]

Originally Posted by KliPPy To me it looks like it still copies 1 time (out of the called function)

Yes if it is a plugin function, but fmt writes directly to this array.

Originally Posted by KliPPy When assigning it copies 2 times.

Yes, we need to introduce an optimization for this.

GetPlayerName without copying:

#include <amxmodx>

#if !defined MAX_NAME
const MAX_NAME = 32;
#endif
const MaxNameLength = MAX_NAME - 1;

public client_connect(player) {
    server_print("%s connecting", GetPlayerName(player));
}

native get_user_name2(a, b, c) = get_user_name;
GetPlayerName(player) {
    static returnStringAddr;
#emit LOAD.S.PRI 0x10
#emit STOR.PRI returnStringAddr
    
    get_user_name2(player, returnStringAddr, MaxNameLength);
#emit RETN
    
    new name[MaxNameLength + 1];
    return name;
}

[fysiks]

Basically, if you are not an advanced programmer who know how the back end of the language works then you should never return an array or a string. So, in general, always do arrays by reference as arguments of the function.

There is a reason that ALL AMX Mod X functions that "return" a string use the string as an argument and not a return value.

[HamletEagle]

I will quote fysiks about returning arrays.

Originally Posted by fysiks Basically, if you are not an advanced programmer who know how the back end of the language works then you should never return an array or a string. So, in general, always do arrays by reference as arguments of the function. There is a reason that ALL AMX Mod X functions that "return" a string use the string as an argument and not a return value.