[JPTRON]

Hello,

I'm trying to code my own KillReward plugin and I want to register the user points inside individuals .txt files.

#pragma semicolon 1

#define DEBUG

#define PLUGIN_AUTHOR "JPTRON"
#define PLUGIN_VERSION "1.00"

#include <sourcemod>
#include <sdktools>
#include <files>
#include <string>

#pragma newdecls required

public Plugin myinfo = 
{
	name = "KillReward",
	author = PLUGIN_AUTHOR,
	description = "Receive points when killing someone.",
	version = PLUGIN_VERSION,
	url = ""
};

public void OnPluginStart()
{
	HookEvent("player_death", Event_PlayerDeath);
}


public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast) {

    int victim = event.GetInt("userid");
    int attacker = event.GetInt("attacker");
    char str[40], attackerStr[40];
    
	 IntToString(attacker, attackerStr, sizeof(attackerStr));
	Format(str, sizeof(str), "/players/%s.txt", attackerStr);

    
    if(victim == attacker || attacker == 0){	
  		return;
  	}


	Handle attackerFile = OpenFile(str, "r+");
    
  	if(!attackerFile){
  		WriteFileLine(attackerFile, "10");
 	}
  
    CloseHandle(attackerFile);     
    
    attackerFile = OpenFile(str, "w+");
    
    int attackerPoints;
    
    attackerPoints = ReadFileLine(attackerFile, attackerStr, sizeof(attackerStr));
    
    attackerPoints += 10;
    
    IntToString(attackerPoints, attackerStr, sizeof(attackerStr));
    
    WriteFileLine(attackerFile, attackerStr);
    
    CloseHandle(attackerFile); 
    
}

L 06/06/2020 - 09:40:57: "JPTRON<2><STEAM_1:0:151314112><CT>" [1514 -126 -148] killed "Matt<11><BOT><TERRORIST>" [1575 -116 -84] with "taser"
L 06/06/2020 - 09:40:57: [SM] Exception reported: invalid handle 0 (error: 4)
L 06/06/2020 - 09:40:57: [SM] Blaming: points.smx
L 06/06/2020 - 09:40:57: [SM] Call stack trace:
L 06/06/2020 - 09:40:57: [SM]   [0] WriteFileLine
L 06/06/2020 - 09:40:57: [SM]   [1] Line 53, C:\Users\joaopf\AppData\Roaming\spedit\sourcepawn\scripts\points.sp::Event_PlayerDeath

[Kellan123]

PHP Code:

if(attackerFile == INVALID_HANDLE) return; 


is missing

[eyal282]

attacker is the CLIENT INDEX of the person who made the kill.

A client index is a slot of an entity that is reserved for online players only, and once a client leaves, his client index can be reused by the next player to join. Your code will not save how you want it to.

[JPTRON]

Originally Posted by eyal282 attacker is the CLIENT INDEX of the person who made the kill. A client index is a slot of an entity that is reserved for online players only, and once a client leaves, his client index can be reused by the next player to join. Your code will not save how you want it to.

Yhea, you're right.

I changed my code to this:

PHP Code:

public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast) {

    int victim = GetClientOfUserId(event.GetInt("userid"));
    int attacker = GetClientOfUserId(event.GetInt("attacker"));
    int assist = GetClientOfUserId(event.GetInt("assister"));
    char str[40], str2[40], attackerStr[40], assistStr[40], victimName[40], attackerName[40], assistName[40];
    
    GetClientName(victim, victimName, sizeof(victimName));
    GetClientName(attacker, attackerName, sizeof(attackerName));
    GetClientName(assist, assistName, sizeof(assistName));
    
    IntToString(attacker, attackerStr, sizeof(attackerStr));
    Format(str, sizeof(str), "/players/%s.txt", attackerStr);
    
    
    if(victim == attacker || attacker == 0){    
          return;
      }

    Handle attackerFile = OpenFile(str, "r");   

    if(attackerFile == INVALID_HANDLE) return;  
       
      if(!attackerFile){
          CloseHandle(attackerFile);
          attackerFile = OpenFile(str, "w");
          WriteFileLine(attackerFile, "0");
     }
       
    CloseHandle(attackerFile);      
    attackerFile = OpenFile(str, "w+");   
    
    int attackerPoints;      
    attackerPoints = ReadFileLine(attackerFile, attackerStr, sizeof(attackerStr));    
    attackerPoints += 10;
    
    IntToString(attackerPoints, attackerStr, sizeof(attackerStr));
       
    WriteFileLine(attackerFile, attackerStr);
       
    CloseHandle(attackerFile); 
    
    
    PrintToChatAll("#%s killed #%i | Points: #%i", attackerName, victimName, attackerPoints);

    if(assist){
        IntToString(assist, assistStr, sizeof(assistStr));
        Format(str2, sizeof(str2), "/players/%s.txt", assistStr);
        
        Handle assistFile = OpenFile(str2, "r");
        
        if(assistFile == INVALID_HANDLE) return;
        
        if(!assistFile){
        CloseHandle(assistFile);
        assistFile = OpenFile(str2, "w");
          WriteFileLine(assistFile, "0");          
         }
         
         CloseHandle(assistFile);        
         assistFile = OpenFile(str2, "w+");
         
         int assistPoints;        
         assistPoints = ReadFileLine(assistFile, assistStr, sizeof(assistStr));         
         assistPoints += 2;
         
         IntToString(assistPoints, assistStr, sizeof(assistStr));
         WriteFileLine(assistPoints, assistStr);
         CloseHandle(assistFile); 
         
         PrintToChatAll("#%s helped killing #%s | Points: #%i", assistName, victimName, assistPoints);
    }
} 


No errors, but don't create any file and don't print the message :/

[Silvers]

"w+"

[DJ Tsunami]

This system with files is going to be a mess, you should use Client Preferences to store client information across connections.

[JPTRON]

Originally Posted by DJ Tsunami This system with files is going to be a mess, you should use Client Preferences to store client information across connections.

Thank you very much dude!! I didn't think about using cookies... So, again, I changed my code to this and it's working:

PHP Code:

Handle g_hPointCookie;
int messagePoints;

public void OnPluginStart()
{
    HookEvent("player_death", Event_PlayerDeath);
    g_hPointCookie = RegClientCookie("give_points", "Give Points", CookieAccess_Protected);
}


public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast) {

    int victim = GetClientOfUserId(event.GetInt("userid"));
    int attacker = GetClientOfUserId(event.GetInt("attacker"));
    int assist = GetClientOfUserId(event.GetInt("assister"));
    char victimName[40], attackerName[40], assistName[40];
    
    GetClientName(victim, victimName, sizeof(victimName));
    GetClientName(attacker, attackerName, sizeof(attackerName));
    GetClientName(assist, assistName, sizeof(assistName));
    
  
    if(victim == attacker || attacker == 0){    
          return;
      }
    
    GivePoints(attacker, 10);

    PrintToChatAll("%s killed %s | Points: %i", attackerName, victimName, messagePoints);

    if(assist){
        GivePoints(assist, 2);
         PrintToChatAll("%s helped killing %s | Points: %i", assistName, victimName, messagePoints);
    }    
}

public void GivePoints(int targetID, int points) {
    
    if (AreClientCookiesCached(targetID))
    {
    
        char sCookieValue[12];
        GetClientCookie(targetID, g_hPointCookie, sCookieValue, sizeof(sCookieValue));
        int Points = StringToInt(sCookieValue);
        Points += points;
        
         messagePoints = Points;
 
        IntToString(Points, sCookieValue, sizeof(sCookieValue));
 
        SetClientCookie(targetID, g_hPointCookie, sCookieValue);
    }
} 


Love you guys ;)