[Grey83]

Cthulhu88, better in this way:

PHP Code:

static const char prefixes[][] = {
    "☆",
    "★"
};

// Can replace this with a LUT (lookup table), depending on the conditions required
int prefix = (owners) ? 0 : (uppers) ? 1 : -1;

if(prefix >= 0)
{
    char name[MAX_NAME_LENGTH];
    GetClientName(client, name, sizeof(name));
    // http://www.sourcemod.net/new-api/string/ReplaceString
    // Return Value
    //     Number of replacements that were performed.
    if(ReplaceString(name, sizeof(name), prefixes[0], "") || ReplaceString(name, sizeof(name), prefixes[1], ""))
    {
        // need to use Format, not FormatEx, if the string buffers overlap
        Format(name, sizeof(name), "%s %s", prefixes[prefix], name);
        SetClientName(client, name);
    }
} 


[Cthulhu88]

Four issues here:

• ReplaceString will replace ALL occurences, not just the first.
• ReplaceString will look for the substring anywhere in the string, not just the beginning.
• You need for it to replace "prefix ", rather than "prefix", else an extra whitespace will be appended before the real name.
• ReplaceString is O(N), where N is the length of the string. The function has to traverse the whole string comparing it against the substring. The strncmp approach is O(3) at worst as both prefixes encode to 3 bytes (UTF-8).

EDIT: You are also not adding the prefix, if neither of the prefixes are found.
EDIT: Fixed my post to check for a zero return value from strncmp (equal), rather than non zero (not equal).

[Grey83]

Originally Posted by Cthulhu88 ReplaceString will replace ALL occurences, not just the first.

http://www.sourcemod.net/new-api/string/ReplaceStringEx

[Grey83]

Originally Posted by Cthulhu88 You need for it to replace "prefix ", rather than "prefix", else an extra whitespace will be appended before the real name.

http://www.sourcemod.net/new-api/string/TrimString

[Cthulhu88]

I never said there aren't other ways around it. I merely pointed the problems with the solution you gave as "better".

All those rmw string operations will be much slower than just passing the offset to where the actual name starts (random/direct access, once we know where the actual name starts). In x86, this can translate to a simple:

lea eax,[eax+ecx] // eax == string pointer, ecx == offset
push eax // to Format call

Even then, messing with strings, especially when a client can edit them, is not ideal. The ideal approach was my second example.

[Grey83]

With removing all invalid prefixes before name (like "★☆ ★☆☆ ★★☆")

[doublejz]

Thanks for all the input/help here "guys"

Originally Posted by Grey83 With removing all invalid prefixes before name (like "★☆ ★☆☆ ★★☆")

I can't seem to get this to add a prefix. It strips it regardless if I have no admin flag, custom admin flag 5 or 6

[101]

Shared ONLY for public benefit and develepment :
https://forums.alliedmods.net/showthread.php?t=350943