[shavit]

Here's the error I get:

L 10/10/2016 - 08:27:02: [SM] Plugin "javit.smx" encountered error 23: Native detected error
L 10/10/2016 - 08:27:02: [SM] Invalid timer handle 9c5863b4 (error 3) during timer end, displayed function is timer callback, not the stack trace
L 10/10/2016 - 08:27:02: [SM] Unable to call function "Timer_DeagleToss" due to above error(s).

And here's all the related code in my plugin to the Timer_DeagleToss callback:

// global
Handle gLR_DeagleTossTimer = null;

// somewhere in my code, can happen multiple times a round - but only if the handle is null
gLR_DeagleTossTimer = CreateTimer(0.5, Timer_DeagleToss, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);

// whenever the mini-game ends: when a player dies or round ends
void EndMinigame()
{
	if(gLR_DeagleTossTimer != null)
	{
		delete gLR_DeagleTossTimer;
		gLR_DeagleTossTimer = null;
	}
}

public Action Timer_DeagleToss(Handle Timer)
{
	if(some_condition)
	{
		/* code here is creating a timer (which is not bound to any variable) to kill the mini-game loser in 3.0 seconds, unrelated */

		gLR_DeagleTossTimer = null; // notice how i set this to null

		return Plugin_Stop; // and stop the timer, yet i still get errors - even though i safely kill it at round end/EndMinigame()..
	}

	return Plugin_Continue;
}

I'm honestly not sure what's wrong here.. does anyone have an idea?

[xines]

Tried switching from delete to killtimer?

PHP Code:

void EndMinigame()
{
    if (gLR_DeagleTossTimer != null)
    {
        KillTimer(gLR_DeagleTossTimer);
        gLR_DeagleTossTimer = null;
    }
} 


Wild idea:

else try

PHP Code:

public Action Timer_DeagleToss(Handle Timer) 


to

PHP Code:

public Action Timer_DeagleToss(Handle timer) 


[shavit]

Originally Posted by xines Tried switching from delete to killtimer? PHP Code: void EndMinigame() {     if (gLR_DeagleTossTimer != null)     {         KillTimer(gLR_DeagleTossTimer);         gLR_DeagleTossTimer = null;     } }  Wild idea: else try PHP Code: public Action Timer_DeagleToss(Handle Timer)  to PHP Code: public Action Timer_DeagleToss(Handle timer)

But KillTimer is the same as delete (which is a CloseHandle alias) basically for me, because I don't need the autoClose argument that KillTimer has.

I'm a bit confused about the second idea: I didn't try yet - because I can't figure out how to replicate the error myself, I just check my error logs daily and I find this one very often. What would it change? I don't use the timer handle anyways in the code block

[ThatOneGuy]

Alternately, you can just have a global integer used for timer validation. Pass the integer as data, and compare it to the current global value in the top of the callback. If different, return Plugin_Stop. Increment the global variable when the timer is supposed to be killed, and it will be killed by your check on next callback. Any new timers would use the new (incremented) value in their validation. This prevents those errors, and you dont have to play with KillTimer, delete, or even handles at all.

[Timocop]

CreateTimer(0.5, Timer_DeagleToss, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);

Remove TIMER_FLAG_NO_MAPCHANGE and close the timer manualy on OnMapEnd.
When this flag is set, it kills the timer on map change, but doesnt set your gLR_DeagleTossTimer to null.
Never ever use TIMER_FLAG_NO_MAPCHANGE when saving the timer handle into variables for later use.

[Dr!fter]

Originally Posted by Timocop CreateTimer(0.5, Timer_DeagleToss, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE); Remove TIMER_FLAG_NO_MAPCHANGE and close the timer manualy on OnMapEnd. When this flag is set, it kills the timer on map change, but doesnt set your gLR_DeagleTossTimer to null. Never ever use TIMER_FLAG_NO_MAPCHANGE when saving the timer handle into variables for later use.

The better solution is to just set the variable to null in OnMapStart

[Peace-Maker]

This can happen when you do some action in your timer callback that triggers an event in the engine you hooked. Like slaying a player in the timer callback and having player_death hooked, in which you kill the timer. Your event hook would execute after the force suicide call and your timer callback would continue afterwards. When the timer callback exits then, the timer handle was closed in the event hook causing that error.
Same for slaying the last alive player or terminating the round or similar.

[shavit]

Originally Posted by ThatOneGuy Alternately, you can just have a global integer used for timer validation. Pass the integer as data, and compare it to the current global value in the top of the callback. If different, return Plugin_Stop. Increment the global variable when the timer is supposed to be killed, and it will be killed by your check on next callback. Any new timers would use the new (incremented) value in their validation. This prevents those errors, and you dont have to play with KillTimer, delete, or even handles at all.

Will try this solution, thanks!

Originally Posted by Timocop CreateTimer(0.5, Timer_DeagleToss, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE); Remove TIMER_FLAG_NO_MAPCHANGE and close the timer manualy on OnMapEnd. When this flag is set, it kills the timer on map change, but doesnt set your gLR_DeagleTossTimer to null. Never ever use TIMER_FLAG_NO_MAPCHANGE when saving the timer handle into variables for later use.

Will try to use OnMapStart instead as Dr!fter suggested, thanks!

Originally Posted by Peace-Maker This can happen when you do some action in your timer callback that triggers an event in the engine you hooked. Like slaying a player in the timer callback and having player_death hooked, in which you kill the timer. Your event hook would execute after the force suicide call and your timer callback would continue afterwards. When the timer callback exits then, the timer handle was closed in the event hook causing that error. Same for slaying the last alive player or terminating the round or similar.

But.. I'm not instantly slaying the player, I'm creating a timer that slays the player in 3 seconds.

[Timocop]

You can try

PHP Code:

public Action Timer_DeagleToss(Handle Timer)
{
    if(some_condition)
    {
        gLR_DeagleTossTimer = null; // Set to null, so it wont kill the timer in the player_death event when its fired by your kill code below.
                
        /* Kill Code here e.g KillClient(client); // which fires player_death where your KillTimer code is located for example */

        return Plugin_Stop;
    }

    return Plugin_Continue;
} 


you can also do it like this i guess:

PHP Code:

public Action Timer_DeagleToss(Handle Timer)
{
    if(some_condition)
    {
        /* Code */

        gLR_DeagleTossTimer = null;
        /* Kill Client Code. Fires player_death but ignores KillTimer because its null now */
        gLR_DeagleTossTimer = Timer; //player_death already fired now, set the timer handle again

        /* Code */

        gLR_DeagleTossTimer = null;
        return Plugin_Stop;
    }

    return Plugin_Continue;
} 


[shavit]

Originally Posted by Timocop You can try PHP Code: public Action Timer_DeagleToss(Handle Timer) {     if(some_condition)     {         gLR_DeagleTossTimer = null; // Set to null, so it wont kill the timer in the player_death event when its fired by your kill code below.                          /* Kill Code here e.g KillClient(client); // which fires player_death where your KillTimer code is located for example */         return Plugin_Stop;     }     return Plugin_Continue; }  you can also do it like this i guess: PHP Code: public Action Timer_DeagleToss(Handle Timer) {     if(some_condition)     {         /* Code */         gLR_DeagleTossTimer = null;         /* Kill Client Code. Fires player_death but ignores KillTimer because its null now */         gLR_DeagleTossTimer = Timer; //player_death already fired now, set the timer handle again         /* Code */         gLR_DeagleTossTimer = null;         return Plugin_Stop;     }     return Plugin_Continue; }

The solution won't work simply because I kill the player within a 3.0 seconds timer, not during this timer callback