[Psyk0tik]

Rate this plugin

Donate to Motivate

No Friendly-Fire

Table of contents

• About
• Credits
• Requirements
• Notes
• Features
• ConVars
• Changelog
• Installation
• Uninstalling/Upgrading to Newer Versions
• Disabling
• Third-party Revisions Notice
• Download

About

Disables friendly fire.

Credits

cravenge - For the original source code; fixing all the errors and converting the original source code into the new syntax in this post.

Lux/LuxLuma - For the previous source code; showed me a better and simpler way of handling friendly fire.

Silvers (Silvershot) - For the code that allows users to enable/disable the plugin in certain game modes and for blocking damage after idle/spectator team change and player disconnects.

Kr3m, WhatsAnName - For reporting an issue.

SourceMod Team - For continually updating/improving SourceMod.

Requirements

1. SourceMod 1.9 or higher
2. Recommended: Left 4 DHooks Direct

Notes

1. I do not provide support for listen/local servers but the plugin should still work properly on them.
2. I will not help you with installing or troubleshooting problems on your part.
3. If you get errors from SourceMod itself, that is your problem, not mine.
4. MAKE SURE YOU MEET ALL THE REQUIREMENTS AND FOLLOW THE INSTALLATION GUIDE PROPERLY.

Features

1. Block friendly-fire for survivors.
2. Block friendly-fire for special infected.
3. Filter which damage types to allow/block.

ConVars

Spoiler

// Block explosive damage?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_blockexplosions "1"

// Block fire damage?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_blockfires "1"

// Block bullet damage?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_blockguns "1"

// Block melee damage?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_blockmelee "1"

// Disable the No Friendly-Fire in these game modes.
// Game mode limit: 16
// Character limit for each game mode: 32
// Empty: None
// Not empty: Disabled in these game modes.
// -
// Default: ""
nff_disabledgamemodes ""

// Enable the plugin?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_enable "1"

// Enable the No Friendly-Fire in these game modes.
// Game mode limit: 16
// Character limit for each game mode: 32
// Empty: None
// Not empty: Enabled in these game modes.
// -
// Default: ""
nff_enabledgamemodes ""

// Enable the No Friendly-Fire in these game mode types.
// 0 OR 15: ALL
// 1: Co-op
// 2: Versus
// 3: Survival
// 4: Scavenge
// -
// Default: "0"
// Minimum: "0.000000"
// Maximum: "15.000000"
nff_gamemodetypes "0"

// Disable Infected team friendly-fire?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_infected "1"

// Only block friendly-fire when all survivors are still inside the saferoom.
// Requires "Left 4 DHooks Direct": https://forums.alliedmods.net/showthread.php?t=321696
// 0: OFF
// 1: ON
// -
// Default: "0"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_saferoomonly "0"

// Disable Survivors team friendly-fire?
// 0: OFF
// 1: ON
// -
// Default: "1"
// Minimum: "0.000000"
// Maximum: "1.000000"
nff_survivors "1"

Changelog

Spoiler

Version 10.0 (June 1, 2022)

1. Bug fixes:

- Fixed compilation errors on "SM 1.10" regarding "Left 4 DHooks Direct".
- Fixed "OnMapEnd" not triggering due to a typo.
- Added notification flag to the "nff_disabledgamemodes" convar.
- Added notification flag to the "nff_enabledgamemodes" convar.

2. Changes:

- The "nff_saferoomonly" convar is now only available when "Left 4 DHooks Direct" is installed.

Version 9.5 (February 20, 2022)

1. Bug fixes:

- Fixed issues where certain special infected cannot suicide because of the friendly-fire block. (Thanks to "WhatsAnName" for testing and reporting!)

Version 9.0 (October 10, 2021)

1. Bug fixes:

- Fixed game mode changes not being hooked and cached.

2. Changes:

- Added notification flags to each convar.
- Made the "nff_pluginversion" convar unchangeable outside of the source code.

Version 8.5 (September 3, 2021)

1. Bug fixes:

- Fixed late-load error regarding invalid entities. (Thanks to "Kr3m" for reporting!)

2. Changes:

- Improved logic to catch possible exploits with gascan friendly-fire.

Version 8.0 (December 9, 2020)

1. Bug fixes:

- Fixed damage from infected to survivors being blocked due to team check even if attacker was never on survivor team.

2. Changes:

- Added the "nff_saferoomonly" convar. (Requested by "lunatixxx".)

Version 7.5 (October 25, 2020)

1. Changes:

- Added multiple settings to determine which damage types to block and which teams to block friendly-fire for.

Version 7.0 (October 14, 2020)

1. Changes:

- No longer relies on convars to block friendly-fire.
- Fire damage is now blocked without blocking all fires. (Thanks to "Silvers" for the code!)
- Blocked idle/spectator team change and player disconnect exploits. (Thanks to "Silvers" for the code!)
- Added the "nff_gamemodetypes" convar. (Thanks to "Silvers" for the code!)

Version 6.5 (June 21, 2018)

1. Changes:

- Optimized code a bit.

Version 6.0 (June 18, 2018)

1. Bug fixes:

- Fixed the "nff_enabledgamemodes" and "nff_disabledgamemodes" convars not working properly.

Version 5.5 (June 16, 2018)

1. Bug fixes:

- Fixed the "nff_enabledgamemodes" and "nff_disabledgamemodes" convars not working properly.

Version 5.0 (June 10, 2018)

1. Major code optimization.
2. Hid the "nff_pluginversion" convar.

Version 4.0 (January 12, 2018)

1. Added support for other game modes.
2. Code optimization.
3. Renamed the source code and ".cfg" files.

Version 3.0 (December 8, 2017)

1. Used a completely different code.
2. Added a check for game mode.

Version 2.0 (November 25, 2017)

1. Implemented cravenge's entity reference check and explosive barrel check.
2. Removed cvar "l4d_friendlyfire_fire".
3. Hid cvar "l4d_friendlyfire_version" and renamed it to "l4d_nff_version".
4. Renamed cvar "l4d_friendlyfire" to "l4d_nff".
5. Fire from explosive barrels no longer damage players (but the explosion still does).
6. Molotovs thrown by players that then switch teams or disconnect no longer do damage.

Version 1.0 (November 12, 2017)

Initial Release.

Installation

1. Delete files from old versions of the plugin.
3. Place "no_friendly-fire.smx" in the "addons/sourcemod/plugins" folder.
4. Place "no_friendly-fire.sp" in the "addons/sourcemod/scripting" folder.

Uninstalling/Upgrading to Newer Versions

1. Delete "no_friendly-fire.sp" from the "addons/sourcemod/scripting" folder.
2. Delete "no_friendly-fire.smx" from the "addons/sourcemod/plugins" folder.
4. Follow the Installation guide above. (Only for upgrading to newer versions.)

Disabling

1. Move "no_friendly-fire.smx" to the "plugins/disabled" folder.
2. Unload "No Friendly-Fire" by typing "sm plugins unload no_friendly-fire" in the server console.

Third-party Revisions Notice

If you would like to share your own revisions of this plugin, please rename the files so that there is no confusion for users.

Download

Source | Latest Version | All Official Releases

[Lux]

I see an issue from reading the code.
Mastermind did the same thing as you forget about people throwing a molotov and changing team or leaving the server will cause damage to people.

You should consider saving an entity reference of the fire and check it to stop that from happening

[Psyk0tik]

Originally Posted by Lux I see an issue from reading the code. Mastermind did the same thing as you forget about people throwing a molotov and changing team or leaving the server will cause damage to people. You should consider saving an entity reference of the fire and check it to stop that from happening

How would I go about doing that? I read the wiki but I'm not exactly sure how to integrate it into the plugin.

Also thanks for the information!

[Psyk0tik]

Originally Posted by cravenge Here, Crasher. I added a check for explosive barrels and for players who disconnect or changes team but I'm not sure if it's accurate. Just post feedback/bugs as I can't test it right now.

When it comes to damaging other survivors, everything works. When it comes to damaging infected, they seem to be invincible and I get the errors in the attached log file.

The errors have to do with line 40:

PHP Code:

        if ((IsSurvivor(victim) && IsSurvivor(attacker)) || (attacker != 0 && (!IsClientInGame(attacker) || GetClientTeam(attacker) != GetClientTeam(victim)))) 


EDIT: I was able to figure out how I was getting those errors as well as how to fix them.

I changed line 40 to:

PHP Code:

        if((IsSurvivor(victim) && IsSurvivor(attacker)) || (attacker != 0 && (!IsClientInGame(attacker) || (IsInfected(attacker) || IsSpectator(attacker))))) 


I also changed line 51 from:

PHP Code:

        if (!pFFBarrel.BoolValue && StrContains(sInflictorClass, "prop_fuel_barrel", false) != -1 && (IsSurvivor(attacker) || (attacker != 0 && (!IsClientInGame(attacker) || GetClientTeam(attacker) != GetClientTeam(victim))))) 


to this:

PHP Code:

        if(!pFFBarrel.BoolValue && StrContains(sInflictorClass, "prop_fuel_barrel", false) > 0 && (IsSurvivor(attacker) || (attacker != 0 && (!IsClientInGame(attacker) || (IsInfected(attacker) || IsSpectator(attacker)))))) 


However, this still generated errors when I turned on 1 of the cvars. I found out that turning on the explosive barrels cvar would not work or would give errors if the other 2 cvars were off. The same thing happened when setting l4d_friendlyfire_fire to 1 while l4d_friendlyfire was 0.

To solve this issue, I simply hooked all 3 checks to just 1 cvar since it seems that all 3 need each other to function properly. This now gives the whole "disable firendly fire completely" feeling.

TL;DR:
Your version:
1. SI are invincible.
2. Errors in the logs.
3. Explosive barrels do not recognize bots and the check does not work properly.

Your version with my revisions:
1. SI are killable.
2. No errors in the logs.
3. Explosive barrels now detect bots and the check works properly.


You can see exactly what I did once I update the source code in the main post.

[Psyk0tik]

Version 2.0 is out!

Changes

1. Implemented cravenge's entity reference check and explosive barrel check.
2. Removed cvar l4d_friendlyfire_fire.
3. Hid cvar l4d_friendlyfire_version and renamed it to l4d_nff_version.
4. Renamed cvar l4d_friendlyfire to l4d_nff.
5. Fire from explosive barrels no longer damage players (but the explosion still does).
6. Molotovs thrown by players that then switch teams or disconnect no longer do damage.

Please redownload the plugin from the first post and delete your l4d_nofriendlyfire.cfg file!

[Psyk0tik]

Originally Posted by cravenge Okay, Crasher. Seen your changes and d(^_^)b. Here I played with some stuff for the explosive barrel explosion, optimized your code changes, and a check for the convar in case it changes so players won't notice something strange like enabling it and finding out the plugin doesn't work unless they vote for a campaign restart. Please test it.

The plugin cannot compile because "HookSingleEntityOutput" and "UnhookSingleEntityOutput" are not defined.

[cravenge]

Whoops, my bad! Here you go, I forgot including SDKTools before posting.

[Psyk0tik]

Originally Posted by cravenge Whoops, my bad! Here you go, I forgot including SDKTools before posting.

Okay it compiled. I'll test it out tonight. Thanks man!

[Psyk0tik]

Originally Posted by cravenge Whoops, my bad! Here you go, I forgot including SDKTools before posting.

Here's what I've observed (keep in mind that I tested this on a local server with bots).

1. When the difficulty is set to Normal and l4d_nff is set to 0.
- Bots still take damage.
- My character doesn't take damage.
- Logs are filled with errors about invalid client indices.

2. When the difficulty is set to Advanced or Expert and l4d_nff is set to 0.
- Bots still take damage.
- My character takes damage.
- Logs are filled with errors about invalid client indices.

3. When the difficulty is set to Normal and l4d_nff is set to 1.
- Bots take damage.
- My character doesn't take damage.
- No log errors.

4. When the difficulty is set to Advanced or Expert and l4d_nff is set to 1.
- Bots take damage.
- My character takes damage.
- No log errors.

[Lux]

I use these cvars on my server to disable friendly fire, it's a simple way for all survivors not to kill each other.

Thought i would share

PHP Code:

#include <sourcemod>
#include <sdktools>

public Plugin:myinfo =
{
    name = "RemoveFF",
    author = "Lux",
    description = "",
    version = "",
    url = ""
};

public OnPluginStart()
{
    HookEvent("round_start", RoundStart);
    HookEvent("round_end", RoundStart);
}

public Action:RoundStart(Handle:event, const String:name[], bool:dontBroadcast) 
{
    SetConVarString(FindConVar("survivor_friendly_fire_factor_easy"), "0");
    SetConVarString(FindConVar("survivor_friendly_fire_factor_expert"), "0");
    SetConVarString(FindConVar("survivor_friendly_fire_factor_hard"), "0");
    SetConVarString(FindConVar("survivor_friendly_fire_factor_normal"), "0");
    SetConVarString(FindConVar("grenadelauncher_ff_scale"), "0");
    SetConVarString(FindConVar("survivor_burn_factor_easy"), "0");
    SetConVarString(FindConVar("survivor_burn_factor_normal"), "0");
    SetConVarString(FindConVar("survivor_burn_factor_hard"), "0");
    SetConVarString(FindConVar("survivor_burn_factor_expert"), "0");
} 


Note the cvars stop self damage from explosive ammo too