[deprale]

Originally Posted by Natsheh Can you explain how this is related to the thread topic?

Just tried to help(chime in some "useful" info), because people can still shoot each other after roundend, and the damage won't be accurate if you display it as soon as CT or T wins, killing players who are saving guns or are still fighting is a thing in PUG mods (which this request is for). Using a task to get all alive players health won't really work in all scenarios, at least it didn't work the way I wanted it to.

Originally Posted by Bugsy 1. I didn't consider the scenario where someone could hurt someone before round start. I personally still consider it as damage issued in the round. 2. clamp() would only make sense if you want to enforce damage within a range (eg. 50-100). I do not need a lower boundary for damage since all damage counts, we just want to limit the max. Please provide your argument for using clamp(). 3. My goal is to only call get_user_health() on alive players, and only call it once per alive player per round. I updated the code here to avoid redundant calls. 4. I added max() to limit the damage to 100 since you requested it here:

I really don't know why I chose clamp instead of min,max, I guess preference.
Your third point is actually good as well, I guess I resorted to using eventhealth just because I couldn't find a working way of properly gathering all player's health the instant before newround.

[Bugsy]

Try this:

PHP Code:


#include <amxmodx>
#include <hamsandwich>
#include <fakemeta>

new const Version[] = "0.8";

#define MAX_PLAYERS 32
#define MAX_NAME_LENGTH 32

enum PlayerStats
{
    Shots,
    DamageGiven,
    HealthBeforeDamage
}

new g_pzStats[ MAX_PLAYERS + 1 ][ MAX_PLAYERS + 1 ][ PlayerStats ];
new g_HealthAtRoundEnd[ MAX_PLAYERS + 1 ];
new HamHook:g_hTakeDamagePre , HamHook:g_hTakeDamagePost; 
new bool:g_bRoundDamageShown;
new g_pEnabled;

public plugin_init() 
{
    register_plugin( "Round Damage" , Version , "bugsy" );
    
    RegisterHam( Ham_Spawn , "player" , "HamSpawn_Post" , true );
    DisableHamForward( g_hTakeDamagePre = RegisterHam( Ham_TakeDamage , "player" , "HamTakeDamage_Pre" , false ) );
    DisableHamForward( g_hTakeDamagePost = RegisterHam( Ham_TakeDamage , "player" , "HamTakeDamage_Post" , true ) );
    register_logevent( "RoundStart" , 2 , "1=Round_Start" ); 
    register_logevent( "RoundEnd" , 2 , "1=Round_End" );
    register_event( "HLTV" , "NewRound" , "a" , "1=0" , "2=0" );
    
    g_pEnabled = register_cvar( "rd_enabled" , "1" );
}

public RoundStart()
{
    ClearArray();
    EnableHamForward( g_hTakeDamagePre );
    EnableHamForward( g_hTakeDamagePost );
}

public RoundEnd()
{
    new iPlayers[ 32 ] , iNum;
    
    get_players( iPlayers , iNum , "ah" );
    
    for ( new i = 0 ; i < iNum ; i++ )
    {
        g_HealthAtRoundEnd[ iPlayers[ i ] ] = get_user_health( iPlayers[ i ] );
    }
}

public NewRound()
{
    g_bRoundDamageShown = false;
    DisableHamForward( g_hTakeDamagePre );
    DisableHamForward( g_hTakeDamagePost );
}

public HamTakeDamage_Pre( victim , inflictor , attacker , Float:fDamage , bitDamage ) 
{
    if ( get_pcvar_num( g_pEnabled ) )
    {
        g_pzStats[ attacker ][ victim ][ HealthBeforeDamage ] = get_user_health( victim );
    }
}

public HamTakeDamage_Post( victim , inflictor , attacker , Float:fDamage , bitDamage ) 
{
    if ( get_pcvar_num( g_pEnabled ) )
    {
        g_pzStats[ attacker ][ victim ][ Shots ]++;
        g_pzStats[ attacker ][ victim ][ DamageGiven ] += clamp( g_pzStats[ attacker ][ victim ][ HealthBeforeDamage ] - get_user_health( victim ) , 0 , g_pzStats[ attacker ][ victim ][ HealthBeforeDamage ] );    
    }
}

public HamSpawn_Post( id )
{
    if ( g_bRoundDamageShown == true )
        return;

    if ( is_user_alive( id ) )
    {
        new iPlayers[ 32 ] , iNum , iPlayer , iOtherPlayer , iDamageGiven , iDamageTaken , szName[ MAX_PLAYERS + 1 ][ 32 ];
        
        get_players( iPlayers , iNum );
    
        for ( new i = 0 ; i < iNum ; i++ )
        {
            iPlayer = iPlayers[ i ];
            
            for ( new p = 0 ; p < iNum ; p++ )
            {
                iOtherPlayer = iPlayers[ p ];
                
                if ( ( i != p ) && ( g_pzStats[ iPlayer ][ iOtherPlayer ][ DamageGiven ] || g_pzStats[ iOtherPlayer ][ iPlayer ][ DamageGiven ] ) )
                {
                    iDamageGiven = g_pzStats[ iPlayer ][ iOtherPlayer ][ DamageGiven ];
                    iDamageTaken = g_pzStats[ iOtherPlayer ][ iPlayer ][ DamageGiven ];
                
                    if ( iDamageGiven || iDamageTaken )
                    {
                        if ( szName[ iOtherPlayer ][ 0 ] == EOS )
                            get_user_name( iOtherPlayer , szName[ iOtherPlayer ] , charsmax( szName[] ) );
                            
                        client_print( iPlayer , print_chat , "(%d with %d) damage, (%d with %d) taken, %s (%dHP)" , iDamageGiven , g_pzStats[ iPlayer ][ iOtherPlayer ][ Shots ] , iDamageTaken , g_pzStats[ iOtherPlayer ][ iPlayer ][ Shots ] , szName[ iOtherPlayer ] , g_HealthAtRoundEnd[ iOtherPlayer ] );
                    }
                }
            }
        }
        
        g_bRoundDamageShown = true;
    }
}

ClearArray()
{
    arrayset( g_HealthAtRoundEnd , 0 , sizeof( g_HealthAtRoundEnd ) );
    for ( new i = 1 ; i <= MAX_PLAYERS ; i++ )
    {
        for ( new p = 1 ; p <= MAX_PLAYERS ; p++ )
        {
            g_pzStats[ i ][ p ][ Shots ] = 0;
            g_pzStats[ i ][ p ][ DamageGiven ] = 0;
            g_pzStats[ i ][ p ][ HealthBeforeDamage ] = 0;
        }
    }
} 


[Bugsy]

@deprale - I think your comment regarding damage happening during freeze time is valid. I'm not sure why Natsheh thought otherwise. If the OP wants to exclude damage during this time window, I can make an edit.

I too used to always use clamp, not realizing there was a min/max native for a 'one-sided' clamp.

[deprale]

Originally Posted by Bugsy Try this: PHP Code: #include <amxmodx> #include <hamsandwich> #include <fakemeta> new const Version[] = "0.3"; #define MAX_PLAYERS 32 #define MAX_NAME_LENGTH 32 enum PlayerStats {     Shots,     DamageGiven } new g_pzStats[ MAX_PLAYERS + 1 ][ MAX_PLAYERS + 1 ][ PlayerStats ]; new g_pEnabled; public plugin_init()  {     register_plugin( "Round Damage" , Version , "bugsy" );          RegisterHam( Ham_TakeDamage , "player" , "HamTakeDamage" , true );     register_logevent( "RoundEnd" , 2 , "1=Round_End" );           g_pEnabled = register_cvar( "rd_enabled" , "1" ); } public HamTakeDamage( victim , inflictor , attacker , Float:fDamage , bitDamage )  {          if ( get_pcvar_num( g_pEnabled ) )     {         new iActualDamage = pev( victim , pev_dmg_take );          g_pzStats[ attacker ][ victim ][ Shots ]++;         g_pzStats[ attacker ][ victim ][ DamageGiven ] += iActualDamage;     } } public RoundEnd() {     set_task( 0.1 , "DelayRoundEnd" ); } public DelayRoundEnd() {     new iPlayers[ 32 ] , iNum , iPlayer , iOtherPlayer , iDamageGiven , iDamageTaken , iHealth[ MAX_PLAYERS + 1 ] , szName[ MAX_PLAYERS + 1 ][ 32 ];     get_players( iPlayers , iNum );     for ( new i = 0 ; i < iNum ; i++ )     {         iPlayer = iPlayers[ i ];                  for ( new p = 0 ; p < iNum ; p++ )         {             iOtherPlayer = iPlayers[ p ];                          if ( ( i != p ) && g_pzStats[ iPlayer ][ iOtherPlayer ][ DamageGiven ] || g_pzStats[ iOtherPlayer ][ iPlayer ][ DamageGiven ] )             {                 iDamageGiven = min( g_pzStats[ iPlayer ][ iOtherPlayer ][ DamageGiven ] , 100 );                 iDamageTaken = min( g_pzStats[ iOtherPlayer ][ iPlayer ][ DamageGiven ] , 100 );                              if ( iDamageGiven || iDamageTaken )                 {                     if ( !iHealth[ iOtherPlayer ] )                         iHealth[ iOtherPlayer ] = is_user_alive( iOtherPlayer ) ? get_user_health( iOtherPlayer ) : 0;                                              if ( szName[ iOtherPlayer ][ 0 ] == EOS )                         get_user_name( iOtherPlayer , szName[ iOtherPlayer ] , charsmax( szName[] ) );                                              client_print( iPlayer , print_chat , "(%d with %d) damage, (%d with %d) taken, %s (%dHP)" , is_user_alive( iOtherPlayer ) ? iDamageGiven : 100 , g_pzStats[ iPlayer ][ iOtherPlayer ][ Shots ] , iDamageTaken , g_pzStats[ iOtherPlayer ][ iPlayer ][ Shots ] , szName[ iOtherPlayer ] , iHealth[ iOtherPlayer ] );                                      }             }         }     }     ClearArray(); } ClearArray() {     for ( new i = 1 ; i <= MAX_PLAYERS ; i++ )     {         for ( new p = 1 ; p <= MAX_PLAYERS ; p++ )         {             g_pzStats[ i ][ p ][ Shots ] = 0;             g_pzStats[ i ][ p ][ DamageGiven ] = 0;         }     } }

Originally Posted by Bugsy @deprale - I think your comment regarding damage happening during freeze time is valid. I'm not sure why Natsheh thought otherwise. If the OP wants to exclude damage during this time window, I can make an edit. I too used to always use clamp, not realizing there was a min/max native for a 'one-sided' clamp.

Regarding the delay, wouldn't it make more sense to make a cvar pointer for mp_round_restart_delay and subtract 0.1 from it then execute this so it happens RIGHT before a newround? Putting it to 0.1 is still not enough IMO, since there's like 4.9 more seconds for people to damage each other.

[Bugsy]

I did not add that for excluding freeze time damage. I found that ham take damage on the very last victim was not registering correctly without a delay.

Edit: I think I added that while debugging, I don't think it's needed.

[theuser]

Originally Posted by Bugsy Try this: PHP Code: #include <amxmodx> #include <hamsandwich> #include <fakemeta> new const Version[] = "0.3"; #define MAX_PLAYERS 32 #define MAX_NAME_LENGTH 32 enum PlayerStats {     Shots,     DamageGiven } new g_pzStats[ MAX_PLAYERS + 1 ][ MAX_PLAYERS + 1 ][ PlayerStats ]; new g_pEnabled; public plugin_init()  {     register_plugin( "Round Damage" , Version , "bugsy" );          RegisterHam( Ham_TakeDamage , "player" , "HamTakeDamage" , true );     register_logevent( "RoundEnd" , 2 , "1=Round_End" );           g_pEnabled = register_cvar( "rd_enabled" , "1" ); } public HamTakeDamage( victim , inflictor , attacker , Float:fDamage , bitDamage )  {          if ( get_pcvar_num( g_pEnabled ) )     {         new iActualDamage = pev( victim , pev_dmg_take );          g_pzStats[ attacker ][ victim ][ Shots ]++;         g_pzStats[ attacker ][ victim ][ DamageGiven ] += iActualDamage;     } } public RoundEnd() {     new iPlayers[ 32 ] , iNum , iPlayer , iOtherPlayer , iDamageGiven , iDamageTaken , iHealth[ MAX_PLAYERS + 1 ] , szName[ MAX_PLAYERS + 1 ][ 32 ];     get_players( iPlayers , iNum );     for ( new i = 0 ; i < iNum ; i++ )     {         iPlayer = iPlayers[ i ];                  for ( new p = 0 ; p < iNum ; p++ )         {             iOtherPlayer = iPlayers[ p ];                          if ( ( i != p ) && g_pzStats[ iPlayer ][ iOtherPlayer ][ DamageGiven ] || g_pzStats[ iOtherPlayer ][ iPlayer ][ DamageGiven ] )             {                 iDamageGiven = min( g_pzStats[ iPlayer ][ iOtherPlayer ][ DamageGiven ] , 100 );                 iDamageTaken = min( g_pzStats[ iOtherPlayer ][ iPlayer ][ DamageGiven ] , 100 );                              if ( iDamageGiven || iDamageTaken )                 {                     if ( !iHealth[ iOtherPlayer ] )                         iHealth[ iOtherPlayer ] = is_user_alive( iOtherPlayer ) ? get_user_health( iOtherPlayer ) : 0;                                              if ( szName[ iOtherPlayer ][ 0 ] == EOS )                         get_user_name( iOtherPlayer , szName[ iOtherPlayer ] , charsmax( szName[] ) );                                              client_print( iPlayer , print_chat , "(%d with %d) damage, (%d with %d) taken, %s (%dHP)" , is_user_alive( iOtherPlayer ) ? iDamageGiven : 100 , g_pzStats[ iPlayer ][ iOtherPlayer ][ Shots ] , iDamageTaken , g_pzStats[ iOtherPlayer ][ iPlayer ][ Shots ] , szName[ iOtherPlayer ] , iHealth[ iOtherPlayer ] );                                      }             }         }     }     ClearArray(); } ClearArray() {     for ( new i = 1 ; i <= MAX_PLAYERS ; i++ )     {         for ( new p = 1 ; p <= MAX_PLAYERS ; p++ )         {             g_pzStats[ i ][ p ][ Shots ] = 0;             g_pzStats[ i ][ p ][ DamageGiven ] = 0;         }     } }

In this case, a maximum of 100 is printed.
But you forgot:
A player's damage is 70 and I shoot him with an awp arrow, 100 damages are printed in chat, while 70 damages should be printed.

[Bugsy]

Ah ok, yes I have a condition where if they are dead, print 100..I'll fix

[theuser]

Originally Posted by Bugsy Ah ok, yes I have a condition where if they are dead, print 100..I'll fix

so tnx +karma

[Bugsy]

Try this

https://forums.alliedmods.net/showpo...8&postcount=22

[theuser]

Originally Posted by Bugsy Try this https://forums.alliedmods.net/showpo...8&postcount=22

The problem is still visible

"A player's damage is 70 and I shoot him with an awp arrow, 100 damages are printed in chat, while 70 damages should be printed."