[QuantumToast]

Hello to you all. I just started learning how to write a plugin for my server, since I could not seem to find anything that met my needs. It's in its very early stages, and I don't have that much experience with the SourcePawn language, but seeing as it's very similar in structure to C++/Java, I have been not having too much issue. I'm going to post a link to what I have so far, since it's a little lengthy: https://pastebin.com/VkuKxuGW
Here's my mental map for what Infractions is supposed to accomplish:

• Allow admins to stack "infractions" on players who break rules (and print a warning message to them in chat)
• Also allow admins to possibly add a "reason" with an infraction, so others know why the player has infractions
• Upon reaching certain amounts of infractions, a defined action is taken against the player, such as kicking or banning
• Possibly, allow infractions to slowly decrease over time
• Hook into certain commands like sm_kick, sm_ban, etc, to increment infractions
• A sm_infractions.cfg file (name subject to change) that is created and populated with players and their SteamIDs or other sources of identification as they have infractions stacked against them

I have some basic functionality in place, namely that the plugin does hook into the commands I specified in the code, as all it does now is print a message in console that something was "done". I also successfully registered all the cvars I've deemed necessary so far.
However, at this point I seem to be suffering from a combination of writer's block and confusion, and have a few questions that may help guide me:

1. How do I process arguments for a command like sm_kick or sm_ban?
2. Branching off the previous question, can I process the target of one command and use them as the target for another?
3. How do I create a structured file like I described above?
4. Are there any features you'd like to see implemented other than the aforementioned?

Thanks all for your wonderful help!

(PS, Mods/Admins who noticed that I posted this in the AMX scripting section first by mistake, I apologise )

[hmmmmm]

Nice idea!

You can use GetCmdArg in the listener callback just like you would in a regular command, and get the target/process whatever you'd like in there. If you wanna know exactly how target is found from the name, you can check how the stock sourcemod functions do it as an example.

More info: https://sm.alliedmods.net/new-api/co...ommandListener

As for creating the file you can use the file class: https://sm.alliedmods.net/new-api/files/File
Lets you read and write whatever you'd like, for examples I'd take a look at how other plugins do it.

[headline]

Originally Posted by QuantumToast How do I process arguments for a command like sm_kick or sm_ban?

Use GetCmdArg, but you can review specifically how sm_kick handles targeting here, but keep in mind it uses a different method from what I show below.

If you don't care to support multiple client targeting like @ct or @t then I'd just use FindTarget like I do here.

Originally Posted by QuantumToast Branching off the previous question, can I process the target of one command and use them as the target for another?

I don't think I understand your question well enough to answer it 100%, but if you're saying what I think you are saying then you'd just pass the client index to the function that does stuff.

Originally Posted by QuantumToast How do I create a structured file like I described above?

Writing everyone's information to a file can be resource expensive. Using an SQL database would be more practical.

[QuantumToast]

Originally Posted by Headline I don't think I understand your question well enough to answer it 100%, but if you're saying what I think you are saying then you'd just pass the client index to the function that does stuff.

I think you answered my question, but I'll reword it - just to be safe.
If an admin runs, for example, sm_mute MicSpammer, I'd like to be able to use the "MicSpammer" part of the command as an argument for stacking infractions on them. Whether or not it's by using their username, user ID, SteamID, whatever, just...something unique to them. When I write the file, though, using SteamID would definitely make the most sense, as to prevent punishment dodging via name-changing.

Originally Posted by Headline Writing everyone's information to a file can be resource expensive. Using an SQL database would be more practical.

While I do understand the advantages of SQL, I have several reasons why I would prefer not to use it if I can help it, in this case:

1. (Of course, this is only if possible), The file will only ever be populated with clients that have infractions stacked against them. In a perfect world, when a client loses all stacks, their entry will be removed. The file will not contain a list of every connected client.
2. I don't really see my server growing to the point that there could be so many users with infractions that the filesize grows to ridiculous amounts. On top of that, the "cooldown" period I'm considering making a feature will help aid this, preventing players who have effectively left the server from clogging up the file.
3. I'd like to not have to pay to get the means to have an SQL database host set up on my server - at the moment, I just have the server and a FastDL server set up, nothing more. My knowledge of SQL as a whole is minimal and I've really not had much success with it, either.

However, I do appreciate you both responding, and I'll be sure to post an update or a problem, if I come across one.

[hmmmmm]

To get the targetting to work same as sourcemod stock functions I'd just copy paste their targetting code since it all applies to yours. I'd use this as reference instead of kick since it takes multiple arguments, which most of the commands you're hooking will be: https://github.com/alliedmodders/sou...n.sp#L266-L305

[QuantumToast]

Originally Posted by hmmmmm To get the targetting to work same as sourcemod stock functions I'd just copy paste their targetting code since it all applies to yours.

Currently working on that. Another question, not sure if you know the answer:
If I have my own command, say, sm_infractions_increment, which will force an increment of a set amount to a player, and also a hook to sm_kick, sm_ban, etc. - should I just have both the command hook callback AND the actual "custom" command call the same function, say, Command_IncrementInfraction? To me, it would seem silly to have to have two different functions that do the same thing, just with different inputs(?), but that may be an oversight on my part.

[hmmmmm]

Yea you can hook them all to the same listener since they all take target as first argument I think but you'd have to figure out which command it came from and how many infractions to give them accordingly.

[headline]

Originally Posted by QuantumToast I think you answered my question, but I'll reword it - just to be safe. If an admin runs, for example, sm_mute MicSpammer, I'd like to be able to use the "MicSpammer" part of the command as an argument for stacking infractions on them. Whether or not it's by using their username, user ID, SteamID, whatever, just...something unique to them. When I write the file, though, using SteamID would definitely make the most sense, as to prevent punishment dodging via name-changing.

Definitely write SteamIDs as the unique identifer for each client, but when you use FindTarget it'll give you the client index which will allow you to do whatever to them.

Originally Posted by QuantumToast While I do understand the advantages of SQL, I have several reasons why I would prefer not to use it if I can help it, in this case: (Of course, this is only if possible), The file will only ever be populated with clients that have infractions stacked against them. In a perfect world, when a client loses all stacks, their entry will be removed. The file will not contain a list of every connected client. I don't really see my server growing to the point that there could be so many users with infractions that the filesize grows to ridiculous amounts. On top of that, the "cooldown" period I'm considering making a feature will help aid this, preventing players who have effectively left the server from clogging up the file. I'd like to not have to pay to get the means to have an SQL database host set up on my server - at the moment, I just have the server and a FastDL server set up, nothing more. My knowledge of SQL as a whole is minimal and I've really not had much success with it, either.

Well, if you're set on using a file to write these client's information, I'd suggest reading information on OnMapStart and then write to it on OnMapEnd. Maybe something like this will start you off.

• Create a KeyValues file structured like below
• OnMapStart use FileToKeyValues to load KeyValues in
• Cache KeyValues handle globally to allow us to lookup client info
• OnClientPostAdminCheck search the tree for their steamid, if it exists set some boolean somewhere to true so we know they have some infraction count.

Spoiler

"Infractions"
{
	"STEAM_1:01"
	{
		"name" "Gaben"
		"count" "1"
	}
	"STEAM_1:02"
	{
		"name" "Someone else"
		"count" "5"
	}
}

EDIT: Give me a few minutes I'll give you some code

Here's some inspiration

PHP Code:

KeyValues kvDatabase;

void LoadKvFile()
{
    char path[PLATFORM_MAX_PATH];
    BuildPath(Path_SM, path, sizeof(path), "configs/infractions.txt");
    
    if (!FileExists(path))
    {
        SetFailState("Configuration file not found! (%s)", path);
        return;
    }
    
    if(!FileToKeyValues(kvDatabase, path))
    {
        SetFailState("Improper structure for configuration file %s!", path);
        return;
    }
}

void SaveKvFile()
{
    char path[PLATFORM_MAX_PATH];
    BuildPath(Path_SM, path, sizeof(path), "configs/infractions.txt");

    KeyValuesToFile(kvDatabase, path);
}

// Description: Returns infraction count (-1 if invalid client or not found in kv file)
int GetClientInfractionCount(int client)
{
    if (!IsClientInGame(client))
    {
        return -1;
    }
    
    int count;
    bool found = false;
    char needle[64];

    GetClientAuthId(client, AuthId_Steam2, needle, sizeof(needle));
    
    if(KvGotoFirstSubKey(kvDatabase)) // If there even is one to start on
    {
        do
        {
            char haystack[32];
            char num[32];
            
            KvGetSectionName(kvDatabase, haystack, sizeof(haystack));    // get name of section (aka steamid)
            
            if (StrEqual(needle, haystack)) // if steamid = current client's steamid
            {
                found = true; // stop while loop
            }
    
            KvGetString(kvDatabase, "count", sBuffer, sizeof(sBuffer));
            count = StringToInt(num);
        }
        while(!found && KvGotoNextKey(kvDatabase, false));
        
        KvGoBack(kvDatabase); // go back
    }
    else
    {
        return -1; // no first subkey
    }
    
    return (found)?count:-1; // return count if found, else -1
} 


[hmmmmm]

EDIT: im big dumbo, nevermind

[Peace-Maker]

You could have a look at this plugin which does most of what you want. I know you do this for learning purposes, but maybe you want to extend that plugin and add the other features you had in mind.
https://forums.alliedmods.net/showthread.php?t=197853