[DJ Data]

Hello.
Im going back through my plugins that i made a while back when i wasnt this "more experienced" in Pawn.
My main trouble is my AutoMember plugin. (I know there are a bunch of risks in this code, like misuse of ServerCommand(Ex). Please ignore them )

PHP Code:

#include <sourcemod>
#include <colors>
 
public Plugin:myinfo =
{
    name = "AutoMember",
    author = "Danian de Leeuw",
    description = "Adds members automatically",
    version = "1.0",
    url = "http://www.databasegaming.com"
};

public OnPluginStart()
{
    LoadTranslations("common.phrases");
    PrintToServer("Booting AutoMember v2.0");
    RegConsoleCmd("sm_register", register);
}

public Action:register(client, args)
{
    decl String:steamid[64];
    GetClientAuthString(client, steamid, sizeof(steamid));

    decl String:name[32];
    GetClientName(client, name, sizeof(name));
    
    new String:szFile[256];
    BuildPath(Path_SM, szFile, sizeof(szFile), "configs/admins_simple.ini");
    
    new Handle:File = OpenFile(szFile, "a");
    WriteFileLine(File, "\"%s\" \"1:@members\"     //&s", steamid, client);
    CloseHandle(File);
    
    ServerCommand("wait 50; sm_reloadadmins; wait 80; sm plugins reload custom-chatcolors");
    FakeClientCommandEx(client, "say /subscribe");

    CPrintToChatAll("{green}[AutoMember]{blue} %s{default} has just applied for Member!", name);

    return Plugin_Handled;
} 


As of right now, it adds people properly and gives them the flag (it works how its supposed to).
One downside is that it doesnt check if people were already added. So im getting tons of useless duplicates. From about 50-200 member sign ups per day, 45% of those are duplicates.
I read up on ReadFileLine but i dont get how it works.

Also, is there any way that i can check if someone is part of a steam group, so that they have to join it to get the member perks?

Thanks!

[KissLick]

If I understand you right, you want to loop throw whole file and read it by lines?

This code do it:

PHP Code:

new Handle:fileHandle = OpenFile( path, "r" );

while( !IsEndOfFile( fileHandle ) && ReadFileLine( fileHandle, fileLine, sizeof( fileLine ) ) )
{
    TrimString( fileLine );
    
    // CODE
}

CloseHandle( fileHandle ); 


nothing hard..

EDIT: For the steam group, try to use SteamTools, but I might heard something that it's not working properly with CS:S

[DJ Data]

I dont know what what loop throw means ^_^*

What i want it to do is:
When someone !register 's it should check if that person is already in the file. So it would have to check if their steamid is already in there, and if it is, return <code>.
Else, <code> (already done this part)

[KissLick]

PHP Code:

new Handle:fileHandle = OpenFile( path, "r" );

decl String:steamid[64], String:LineSteamID[ 16 ];
GetClientAuthString(client, steamid, sizeof(steamid));

while( !IsEndOfFile( fileHandle ) && ReadFileLine( fileHandle, fileLine, sizeof( fileLine ) ) )
{
    TrimString( fileLine );
    
    // here you get file line - on every loop next line
    // if the lines are in format like shit
    // "STEAMID" "1:@members"    // PLAYER_NAME
    // you can "parse" the steam id and test it
    
    ReplaceStringEx( fileLine, sizeof( fileLine ), "\"", "" ); // remove first " from line -> STEAMID" "1:@members"    // PLAYER_NAME
    strcopy( LineSteamID, FindCharInString( fileLine, "\"" ), fileLine ); // FindCharInString( fileLine, "\"" ) = until first " is found
    // now you have steam id from file in LineSteamID
    // so compare LineSteamID to steamid
    
    if( StrEqual( LineSteamID, steamid ) )
    {
        // Player is already in file..
    }
}

CloseHandle( fileHandle ); 


EDIT: a little mistake in code..

[Marcus_Brown001]

You shouldn't loop through the file every time someone does a command. You should loop through the file one time when the client connects, and cache the results into an array for that client. Then simply check the array for what it is you are looking for.

[asherkin]

You should never write into SourceMod's admin config files - just write your own storage and give people access directly.

[Marcus_Brown001]

Originally Posted by asherkin You should never write into SourceMod's admin config files - just write your own storage and give people access directly.

Oops. I didn't look to see what file you were opening.

[KissLick]

I guess simple KV file of SQLite is better choice (depends on number of members).. And give player admin access via sm functions is peasy -> CreateAdmin -> AdminInheritGroup

EDIT: And one little thing, if player is already in "configs/admins_simple.ini", he has an admin access, so you can just test if player is admin or not.. (GetUserAdmin)

[DJ Data]

I think im gonna keep how it is right now then. I need to develop more understanding to what all the "File" commands do.