[MPNumB]

Originally Posted by arkshine - new iOldName[27], iNewName[27]; Should be 32. - Instead of check_flags() function, If you want to test something like : get_user_flags(id) & ADMIN_KICK && get_user_flags(id) & ADMIN_BAN, should not be enough to do just : if ( !( get_user_flags( id ) & ~( ADMIN_KICK | ADMIN_BAN ) ) ) ? It would be better. - Why did you use client_command() when you can directly register via register_clmd() ? It would be better and it will avoid unnecessary calls. - What's the purpose of get_chat_viewer_access() when the level is hardcoded ? Just do a #define so user will have to change just one line. - Message_SayText() ; It would be more appropriate to try to do an effort to use severals switch instead of if() elseif()[..] , checking each time the string. Also, while+contain+replace = replace_all(), what's wrong with replace_all() ?

Len: max name lengh is 26 chars.

Flags: didn't knew that function. But what about support for 'y' ADMIN_ADMIN flag?

Cmd registering: supports not only "/chatviewer" but also ".chatviewer" and also supports a<->A (big ladders to small).

Else if vs. if: we need to check all chars so I'm using if (not else if).

replace_all vs. while( contain ) replace(): replace_all uses more cpu cuz scans number of replaces + has backup checkup + uses not static variables (function is fast repeating). In other words replace_all uses more CPU and more RAM.

// edit:

Originally Posted by ConnorMcLeod Originally Posted by arkshine what's wrong with replace_all() ? It's too much readable for NumB.

Rofl. Love you.

[Arkshine]

Len: max name lengh is 26 chars.

Max name length is limited to 32 characters. I tried just now to be sure.

Flags: didn't knew that function. But what about support for 'y' ADMIN_ADMIN flag?

I think I have misunderstood what you wanted to do. What I gave is to check if there are only theses flags. But if you want to check if theses flags are presents (not only one flags, all provided flags), you should do just : if ( i_Flags & ( ADMIN_KICK | ADMIN_BAN ) == ( ADMIN_KICK | ADMIN_BAN ) )

Cmd registering: supports not only "/chatviewer" but also ".chatviewer" and also supports a<->A (big ladders to small).

It would be more efficient to use severals register_clcmd() (/ .). client_command is called often. The support of 'a<->A' is for me not really necessary here ( I mean not enough useful to be prioritized on efficiency ). Well do what you want. Edit: if you still want to use equali(), register at least say and say_team instead of using client_command which will be called often others than chat messages.

Else if vs. if: we need to check all chars so I'm using if (not else if).

No, just few letters should be enough ; It will be more faster and efficient. ( It's always better to check only one character than using equal() and checking the whole string + switch() against if~elseif' )

replace_all vs. while( contain ) replace(): replace_all uses more cpu cuz scans number of replaces + has backup checkup + uses not static variables (function is fast repeating). In other words replace_all uses more CPU and more RAM.

More Cpu/ram ? Not really, prove it. :p. it's just cells.. For that, it would more appropriate to use a safe method. Just my opinion.

[Miko000000]

GJ and nice work

[SnoW]

Originally Posted by Miko000000 GJ and nice work

GW and nice job

[Speed!]

Originally Posted by arkshine Max name length is limited to 32 characters. I tried just now to be sure. I think I have misunderstood what you wanted to do. What I gave is to check if there are only theses flags. But if you want to check if theses flags are presents (not only one flags, all provided flags), you should do just : if ( i_Flags & ( ADMIN_KICK | ADMIN_BAN ) == ( ADMIN_KICK | ADMIN_BAN ) ) It would be more efficient to use severals register_clcmd() (/ .). client_command is called often. The support of 'a<->A' is for me not really necessary here ( I mean not enough useful to be prioritized on efficiency ). Well do what you want. Edit: if you still want to use equali(), register at least say and say_team instead of using client_command which will be called often others than chat messages. No, just few letters should be enough ; It will be more faster and efficient. ( It's always better to check only one character than using equal() and checking the whole string + switch() against if~elseif' ) More Cpu/ram ? Not really, prove it. :p. it's just cells.. For that, it would more appropriate to use a safe method. Just my opinion.

in one hand you are telling him to fix minor things that actually may not fix bugs, just may improve in a way that wont be even noticeble.
in the other hand you are telling him that a method is better, but not thaaat better.
i think plugins may be done in more than 1 way, and in many ways will be working and with equal perfonmance
and everyone has his owns methods scripting, he may use his methods (that actually works) for his plugins, and you for your plugins (that are actually pretty the same)
take it good, i think its just a bit excesive to correct things that do not have difference, its just "to be used to that method"
just an opinion

[Exolent[jNr]]

How is efficiency an opinion or scripting style?
arkshine has been scripting for a long time now, and he knows what he is talking about.

[Arkshine]

just an opinion

I think we have to create efficient code when we can. The purpose is to do quality plugin. Safe code sometimes against efficiency depending the need. Maybe the plugin alone it will not be that noticeable, but if you have severals plugins not coded in an efficient way, it will be. What I have said is not my 'method' it's just an efficient method that people should be used as 'standart'.
Why do you use static ? Because you know it's more appropriate to use it on (large) array (or cells) in a function called often. It's the same with switch() or checking one letter instead of using if() elsif() with equal a lot of times. It's more efficient to use it when we can. ( common practice ). Like your check_flags function a lot of code when you may can it in on line.

Anyway it was just suggestions, I don't care if you ignore or not. I was just some help so you plugin can be more efficient. ( I will do my version as it should be and it will compare with profiler. It may be interesting. I will post my version here later, too )

[anxiro]

I disabled my own admin access on the server but I am still allowed to do /chatviewer -command? Why?

Anyway - Good plugin!

[MPNumB]

Originally Posted by arkshine Max name length is limited to 32 characters. I tried just now to be sure.

Damn, before protocol update it was 26 - 100% sure in it...

Originally Posted by arkshine I think I have misunderstood what you wanted to do. What I gave is to check if there are only theses flags. But if you want to check if theses flags are presents (not only one flags, all provided flags), you should do just : if ( i_Flags & ( ADMIN_KICK | ADMIN_BAN ) == ( ADMIN_KICK | ADMIN_BAN ) )

Anyway, changed it to this way (as I said before - didn't knew about this way).

Originally Posted by arkshine It would be more efficient to use severals register_clcmd() (/ .). client_command is called often. The support of 'a<->A' is for me not really necessary here ( I mean not enough useful to be prioritized on efficiency ). Well do what you want. Edit: if you still want to use equali(), register at least say and say_team instead of using client_command which will be called often others than chat messages.

I created this plugin long time ago. Just submitted it this week rewriting it to be more readable. Good idea to use register_clcmd(). Done.

Originally Posted by arkshine No, just few letters should be enough ; It will be more faster and efficient. ( It's always better to check only one character than using equal() and checking the whole string + switch() against if~elseif' )

Right now understood that I don't understand of what lines of source you are talking about. =P

Originally Posted by arkshine More Cpu/ram ? Not really, prove it. :p. it's just cells.. For that, it would more appropriate to use a safe method. Just my opinion.

Ok.

PHP Code:

while( contain(text, string) )
   replace(text, text_len, string, string2); // I think it's simple 


Now lets take a look at:

PHP Code:

stock replace_all(string[], len, const what[], const with[])
{
 new pos = 0;
 
 if ((pos = contain(string, what)) == -1)
 {
  return 0;
 }
 
 new total = 0;
 new with_len = strlen(with);
 new diff = strlen(what) - with_len;
 new total_len = strlen(string);
 new temp_pos = 0;
 
 while (replace(string[pos], len - pos, what, with) != 0)
 {
  /* jump to position after replacement */
  pos += with_len;
 
  /* update cached length of string */
  total_len -= diff;
 
  /* will the next call be operating on the last character? */
  if (pos >= total_len)
  {
   break;
  }
 
  /* find the next position from our offset */
  temp_pos = contain(string[pos], what);
 
  /* if it's invalid, we're done */
  if (temp_pos == -1)
  {
   break;
  }
 
  /* otherwise, reposition and update counters */
  pos += temp_pos;
  total++;
 }
 
 return total;
} 


If not visible by eye that replace_all takes more power I can also say it this way:

SayText event can be repeated really fast and often. Using variable what is not "static" or "global" (like "new" what this stock does), we can just end up in a server crash.

// edit:


Updated to 1.1 :
Fixed: max name length changed from 26 to 31.
Changed: some things in the code to make plugin work better.

[Arkshine]

About replace_all, he takes more power ( slighty ) but is more safe too. Though it may not a bad idea to include this stock in your plugin, changing new by static if the function is called often.

Anyway, I've just thought about your code, since you replace by a space ( not removing ), there is a much better method to do that, something that ( may need adjustments but you get the idea ):

    for ( new i = iLen; i <= iLen + iLen2; i++ )
    {
        if ( iMessage[i] == 'SOH
' || iMessage[i] == 'STX' || iMessage[i] == 'ETX' || iMessage[i] == 'EOT' || iMessage[i] == '%' )
            iMessage[i] = ' ';
    }

No native, no extra cpu/memory used. :p

EDIT : Arg, codes doesn't show ; I've written manually but you will understand.