[101]

Originally Posted by fysiks I've been told is much more efficient to use get_players() in most all cases

i think they were wrong , if u see my script that deals with CT,CT_A,T,T,A , then i had to call the native get_players 4 times in millisecond (a lot of work) . if u had a look of what Mr Bugsy wrote .
creating a loop by ur own is much better if u have to deal with data that should be refreshed every half-second .

Originally Posted by fysiks P.S. Whitespace is not your enemy

no it is , remove them make the code looks under control with contiguous homogeneous groups .

Thank u all for responding
I appreciate your replies

[fysiks]

Originally Posted by WATCH_D0GS UNITED It could be really better to see the source of all natives to see how many stuff they're using to get the results. After decompiling, you can get something like this:

Why would you try to decompile anything in AMX Mod X? It's all open source and freely available on GitHub.

Originally Posted by 101 i think they were wrong , if u see my script that deals with CT,CT_A,T,T,A , then i had to call the native get_players 4 times in millisecond (a lot of work) . if u had a look of what Mr Bugsy wrote . creating a loop by ur own is much better if u have to deal with data that should be refreshed every half-second .

I didn't say that get_players() was the prefect solution for this specific use case (I can't prove that without actually benchmarking both methods). You do know, though, that computers are very fast right? Calling something every 500 ms isn't really all that bad. A lot of people seem to want to unnecessarily optimize code that is not causing any actual problems. IMO, don't try to optimize something this hard unless it's actually causing a problem.

Regardless, it would be interesting if you could benchmark both methods to actually see if there is a significant difference instead of just assuming base on your feelings.

Originally Posted by 101 no it is , remove them make the code looks under control with contiguous homogeneous groups .

LOL, I guess you're a comedian.

[WATCH_D0GS UNITED]

Well... https://github.com/alliedmodders/amx...ns/compile.exe

Where to find things like https://www.amxmodx.org/api/cvars/get_pcvar_num (All the procedure)

[101]

Originally Posted by fysiks ...................

just shut the f up , and focus on learning so u could give people useful answers instead .

[mlibre]

get out of doubt with profiler

[HamletEagle]

Originally Posted by WATCH_D0GS UNITED Well... https://github.com/alliedmodders/amx...ns/compile.exe Where to find things like https://www.amxmodx.org/api/cvars/get_pcvar_num (All the procedure)

I find it funny that you linked to the compiler on github but didn't consider searching in the same place for the source code of get_pcvar_num. The full source code is available in the link you posted (https://github.com/alliedmodders/amxmodx), just search/browse the code by the name of the native.

[WATCH_D0GS UNITED]

0oh man, it's cvars.cpp not amxmodx.cpp. Thanks.
https://github.com/alliedmodders/amx...modx/cvars.cpp

Originally Posted by mlibre get out of doubt with profiler

https://forums.alliedmods.net/showthread.php?t=67752

1.8.2?

[Jhob94]

You really derailed such a basic topic..
@OP, hamelteagle first post says everything.
Basically if you use get_players you will end up making 2 loops. Yet it is better if you are reading many flags.

So if you want a simple check like knowing which users are alive you can simply do a normal loop and check inside for is_user_alive. But let’s say that you want alive players, from terrorist team and exclude bots. This way a get_players would fit better. But in the end of the day that becomes quite pointless. Like fysiks said, with the computers we have today this isn’t a problem.

[WATCH_D0GS UNITED]

Originally Posted by Jhob94 You really derailed such a basic topic.. @OP, hamelteagle first post says everything. Basically if you use get_players you will end up making 2 loops. Yet it is better if you are reading many flags. So if you want a simple check like knowing which users are alive you can simply do a normal loop and check inside for is_user_alive. But letÂ’s say that you want alive players, from terrorist team and exclude bots. This way a get_players would fit better. But in the end of the day that becomes quite pointless. Like fysiks said, with the computers we have today this isnÂ’t a problem.

What it makes you believe ()e will accept your argument more than the HamletEagle's ones?
101 could come back to say everyone in this thread is a f*cking bastard

Also, it's really weird to see you are caring about native calls in these threads while in your NightCrawler Remake plugin you are using the FM_AddToFullPack forward, which is called more than 30.000 times/sec. in a 30 players scenario with 3 natives checks, which their values should be cached in another event which is called less times.

[Jhob94]

The natives i use are get_orig_retval, is_user_alive and is_user_connected. There is no harm on doing that. Plus i have no idea what my plugins have to do with this topic.