Weapon Icon 1.0b

hkchild · **Plugin Info:**

Hello i'm come from hong kong , i notice a bug in the plugin

so i edit it and upload to here...

my english is so poor, don't publinsh me

I only Edit the flashbang icon bug, i use the other icon to use......

Now you can download to use and debug....

If you notice more bug or something wrong...

pls email to me

[email protected]

Author if i do something wrong (about the version) pls email to me.......
i will change it....

thank you~~~~~~~~

Roach · 09-23-2007 , 23:03 Re: Weapon Icon 1.0b

No need to upload the .amxx file, the forum compiles and uploads it for you.

Zenith77 · 09-23-2007 , 23:19 Re: Weapon Icon 1.0b

Okay I need to ask you some questions before I can take any further action:

What part of the plugin did you modify/fix?
Is this still in beta?
If not, have you tested this extensively?

Also, clean up your description of the plugin a bit as best you can (I know you don't speak English very well). For example, don't excessively use italics, etc. If you can't do this, use zenix's original post and modify that to fit the change log, etc.

M249-M4A1 · 09-23-2007 , 23:20 Re: Weapon Icon 1.0b

This is pretty cool; and for those of you who aren't quite sure what this plugin actually does, due to its lack of good description, I attached a screenshot so you can see. Take a look at the left side of the HUD.

BlackMilk · 09-24-2007 , 01:52 Re: Weapon Icon 1.0b

But the original is still in Approved section and already does that, M249-M4A1...

What's the fix?

He says something about flashbangs but I don't recall there being anything wrong with the original in that...

Zenith77 · 09-24-2007 , 08:06 Re: Weapon Icon 1.0b

(Pertaining to the original plugin): From user reports it appears to be broken, and it doesn't compile correctly with the on-line compiler. I've set a dead line for 2 weeks to fix it.

Wasn't there something wrong with the flashbangs going off the screen? I'm sorry, I'm just slowly trying to figure out what's going on here, his post here left me kind of confused as he didn't detail really anything.

But I'm begining to doubt if he's fixed anything, because the code from what I can see is 100% the same.

edit

http://forums.alliedmods.net/showpos...1&postcount=84

I'm still going to wait for the authors response to make sure if he actually did anything. But I'm only giving it a day or two.

ali_zkz · 09-25-2007 , 08:18 Re: Weapon Icon 1.0b

Quote:

Originally Posted by Zenith77

(Pertaining to the original plugin): From user reports it appears to be broken, and it doesn't compile correctly with the on-line compiler. I've set a dead line for 2 weeks to fix it.

Wasn't there something wrong with the flashbangs going off the screen? I'm sorry, I'm just slowly trying to figure out what's going on here, his post here left me kind of confused as he didn't detail really anything.

But I'm begining to doubt if he's fixed anything, because the code from what I can see is 100% the same.

edit

http://forums.alliedmods.net/showpos...1&postcount=84

I'm still going to wait for the authors response to make sure if he actually did anything. But I'm only giving it a day or two.

as u said :the original seems to be broken
but this one can be complied and used correctly
thats all lol

purple_pixie · 09-26-2007 , 04:55 Re: Weapon Icon 1.0b

Zenith - If you can't find the differences, try WinMerge.

Differences:
Original:

Code:

case CSW_FLASHBANG: sprite = "d_flashbang"

Now:

Code:

case CSW_FLASHBANG: sprite = "d_grenade"

Original:

Code:

            if (wclip == 0 && wammo == 0) icon_color = {0, 0, 255} // outta ammo!
                if (wclip == wammo || wclip > wammo) icon_color = {0, 160, 0} // last clip!
                if (wammo > 0 && wclip == 0) icon_color = {255, 100, 100} // almost out!

Now:

Code:

                if (wclip == 0 && wammo == 0) icon_color = {0, 255, 0} // outta ammo!
                if (wclip == wammo || wclip > wammo) icon_color = {0, 255, 0} // last clip!
                if (wammo > 0 && wclip == 0) icon_color = {0, 255, 0} // almost out!

And that's it, apart from the changelog, version and author.

Zenith77 · 09-26-2007 , 08:11 Re: Weapon Icon 1.0b

Quote:

Originally Posted by purple_pixie

Zenith - If you can't find the differences, try WinMerge.

Differences:
Original:

Code:

case CSW_FLASHBANG: sprite = "d_flashbang"

Now:

Code:

case CSW_FLASHBANG: sprite = "d_grenade"

Original:

Code:

            if (wclip == 0 && wammo == 0) icon_color = {0, 0, 255} // outta ammo!
                if (wclip == wammo || wclip > wammo) icon_color = {0, 160, 0} // last clip!
                if (wammo > 0 && wclip == 0) icon_color = {255, 100, 100} // almost out!

Now:

Code:

                if (wclip == 0 && wammo == 0) icon_color = {0, 255, 0} // outta ammo!
                if (wclip == wammo || wclip > wammo) icon_color = {0, 255, 0} // last clip!
                if (wammo > 0 && wclip == 0) icon_color = {0, 255, 0} // almost out!

And that's it, apart from the changelog, version and author.

Thanks. I saw the color part though ;)

Roach · 09-26-2007 , 10:39 Re: Weapon Icon 1.0b

Not much of a change apart from a color swap and a model fix, which hardly warrants a fresh release and plugin approval.

IMO, let the author know about the fix, and give this guy the credit for the bugfix in the plugin if the author decides to use it.

JM2c.