[Solved] Need some correction in code for giving nades - Page 2

TheSpaniard · 09-17-2017 , 11:01 Re: Need some correction in code for giving nades

Quote:

Originally Posted by wickedd

And what game is this for?

cs 1.6

DarthMan · 09-17-2017 , 11:09 Re: Need some correction in code for giving nades

Quote:

Originally Posted by TheSpaniard

cs 1.6

Yeah I know, I was just saying about TFC. Normally, this should not be required because register_event contains the flags autoamtically and is oinly registered if the user is connected.

TheSpaniard · 09-17-2017 , 11:17 Re: Need some correction in code for giving nades

Quote:

Originally Posted by DarthMan

Yeah I know, I was just saying about TFC. Normally, this should not be required because register_event contains the flags autoamtically and is oinly registered if the user is connected.

is this right it is compiling without errors

PHP Code:


			
/* Plugin generated by AMXX-Studio */



#include <amxmodx>

#include <amxmisc>

#include <cstrike>

#include <hamsandwich>

#include <fun>



#define PLUGIN "FreeNadesGiver"

#define VERSION "1.0"

#define AUTHOR "TheSpaniard"

#define TASKID 1440



public plugin_init() 

{

    register_plugin(PLUGIN, VERSION, AUTHOR)

    register_event("ResetHUD", "forwardResetHud", "be");

    register_clcmd("say /nade", "give_nades")

}



public forwardResetHud(i_Client)

{

    if(!(get_user_flags(i_Client) & ADMIN_LEVEL_H))

    {

        return PLUGIN_HANDLED

    }

    set_task(15.0, "give_nades", TASKID+i_Client, _, _, "b")

    return PLUGIN_CONTINUE

}



public give_nades(id) 

{

    new henade = user_has_weapon(id, 4, -1)

    new heammo = cs_get_user_bpammo(id, CSW_HEGRENADE)

    new smokenade = user_has_weapon(id, 9, -1)

    new smokeammo = cs_get_user_bpammo(id, CSW_SMOKEGRENADE)

    new flashnade = user_has_weapon(id, 25, -1)

    new flashammo = cs_get_user_bpammo(id, CSW_FLASHBANG)

    if(henade == 1 && heammo << 2)

    {

        cs_set_user_bpammo(id, CSW_HEGRENADE, 2)

    }

    else

    {

        give_item(id, "weapon_hegrenade")

        cs_set_user_bpammo(id, CSW_HEGRENADE, 2)

    }

    if(smokenade == 1 && smokeammo << 2)

    {

        cs_set_user_bpammo(id, CSW_SMOKEGRENADE, 2)

    }

    else

    {

        give_item(id, "weapon_smokegrenade")

        cs_set_user_bpammo(id, CSW_SMOKEGRENADE, 2)

    }

    if(flashnade == 1 && flashammo << 2)

    {

        cs_set_user_bpammo(id, CSW_FLASHBANG, 4)

    }

    else

    {

        give_item(id, "weapon_flashbang")

        cs_set_user_bpammo(id, CSW_FLASHBANG, 4)

    }

    

    return PLUGIN_HANDLED

}

DarthMan · *Last edited by DarthMan; 09-17-2017 at 11:38.*

Quote:

Originally Posted by TheSpaniard

is this right it is compiling without errors

PHP Code:


			
/* Plugin generated by AMXX-Studio */

#include <amxmodx>
#include <amxmisc>
#include <cstrike>
#include <hamsandwich>
#include <fun>

#define PLUGIN "FreeNadesGiver"
#define VERSION "1.0"
#define AUTHOR "TheSpaniard"
#define TASKID 1440

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    register_event("ResetHUD", "forwardResetHud", "be");
    register_clcmd("say /nade", "give_nades")
}

public forwardResetHud(i_Client)
{
    if(!(get_user_flags(i_Client) & ADMIN_LEVEL_H))
    {
        return PLUGIN_HANDLED
    }
    set_task(15.0, "give_nades", TASKID+i_Client, _, _, "b")
    return PLUGIN_CONTINUE
}

public give_nades(id) 
{
    new henade = user_has_weapon(id, 4, -1)
    new heammo = cs_get_user_bpammo(id, CSW_HEGRENADE)
    new smokenade = user_has_weapon(id, 9, -1)
    new smokeammo = cs_get_user_bpammo(id, CSW_SMOKEGRENADE)
    new flashnade = user_has_weapon(id, 25, -1)
    new flashammo = cs_get_user_bpammo(id, CSW_FLASHBANG)
    if(henade == 1 && heammo << 2)
    {
        cs_set_user_bpammo(id, CSW_HEGRENADE, 2)
    }
    else
    {
        give_item(id, "weapon_hegrenade")
        cs_set_user_bpammo(id, CSW_HEGRENADE, 2)
    }
    if(smokenade == 1 && smokeammo << 2)
    {
        cs_set_user_bpammo(id, CSW_SMOKEGRENADE, 2)
    }
    else
    {
        give_item(id, "weapon_smokegrenade")
        cs_set_user_bpammo(id, CSW_SMOKEGRENADE, 2)
    }
    if(flashnade == 1 && flashammo << 2)
    {
        cs_set_user_bpammo(id, CSW_FLASHBANG, 4)
    }
    else
    {
        give_item(id, "weapon_flashbang")
        cs_set_user_bpammo(id, CSW_FLASHBANG, 4)
    }
    
    return PLUGIN_HANDLED
}

Try < instead of <<, also replace public give_nades(id) with public give_nades(taskid) and on the enxt line after { type new id = taskid-TASKID. Before set_task(15.0, "give_nades", TASKID+i_Client, _, _, "b") do a if(!task_exists(TASKID+i_Client)).

For public client_disconnect(id) check if task exists, remove_task(TASKID+id).
Also, remvoe this: #include <hamsandwich> .

TheSpaniard · 09-17-2017 , 11:55 Re: Need some correction in code for giving nades

Quote:

Originally Posted by DarthMan

Try < instead of <<, also replace public give_nades(id) with public give_nades(taskid) and on the enxt line after { type new id = taskid-TASKID. Before set_task(15.0, "give_nades", TASKID+i_Client, _, _, "b") do a if(!task_exists(TASKID+i_Client)).

For public client_disconnect(id) check if task exists, remove_task(TASKID+id).
Also, remvoe this: #include <hamsandwich> .

PHP Code:


			
/* Plugin generated by AMXX-Studio */



#include <amxmodx>

#include <amxmisc>

#include <cstrike>

#include <fun>



#define PLUGIN "FreeNadesGiver"

#define VERSION "1.0"

#define AUTHOR "TheSpaniard"

#define TASKID 1440



public plugin_init() 

{

    register_plugin(PLUGIN, VERSION, AUTHOR)

    register_event("ResetHUD", "forwardResetHud", "be");

    register_clcmd("say /nade", "give_nades")

}



public forwardResetHud(i_Client)

{

    if((!(get_user_flags(i_Client) & ADMIN_LEVEL_H)))

    {

        return PLUGIN_HANDLED

    }

    return PLUGIN_CONTINUE

}



public client_putinserver(id)

{

    if(is_user_connected(id)) 

        set_task(15.0, "give_nades", id + TASKID)

}



public client_disconnect(id)

{

    remove_task(id + TASKID);

}



public give_nades(id) 

{

    new henade = user_has_weapon(id - TASKID, 4, -1)

    new heammo = cs_get_user_bpammo(id - TASKID, CSW_HEGRENADE)

    new smokenade = user_has_weapon(id - TASKID, 9, -1)

    new smokeammo = cs_get_user_bpammo(id - TASKID, CSW_SMOKEGRENADE)

    new flashnade = user_has_weapon(id - TASKID, 25, -1)

    new flashammo = cs_get_user_bpammo(id - TASKID, CSW_FLASHBANG)

    if(henade == 1 && heammo << 2)

    {

        cs_set_user_bpammo(id - TASKID, CSW_HEGRENADE, 2)

    }

    else

    {

        give_item(id - TASKID, "weapon_hegrenade")

        cs_set_user_bpammo(id - TASKID, CSW_HEGRENADE, 2)

    }

    if(smokenade == 1 && smokeammo << 2)

    {

        cs_set_user_bpammo(id - TASKID, CSW_SMOKEGRENADE, 2)

    }

    else

    {

        give_item(id - TASKID, "weapon_smokegrenade")

        cs_set_user_bpammo(id - TASKID, CSW_SMOKEGRENADE, 2)

    }

    if(flashnade == 1 && flashammo << 2)

    {

        cs_set_user_bpammo(id - TASKID, CSW_FLASHBANG, 4)

    }

    else

    {

        give_item(id - TASKID, "weapon_flashbang")

        cs_set_user_bpammo(id - TASKID, CSW_FLASHBANG, 4)

    }

    

    return PLUGIN_HANDLED

}

This Worked for me

TheSpaniard · 09-17-2017 , 11:56 Re: Need some correction in code for giving nades

Any Way thanks for your help man

TheSpaniard · 09-17-2017 , 11:56 Re: Need some correction in code for giving nades

+karma for your help

Natsheh · 09-18-2017 , 02:09 Re: Need some correction in code for giving nades

Quote:

Originally Posted by DarthMan

Try < instead of <<, also replace public give_nades(id) with public give_nades(taskid) and on the enxt line after { type new id = taskid-TASKID. Before set_task(15.0, "give_nades", TASKID+i_Client, _, _, "b") do a if(!task_exists(TASKID+i_Client)).

For public client_disconnect(id) check if task exists, remove_task(TASKID+id).
Also, remvoe this: #include <hamsandwich> .

You do realize that what you are posting is a total bullshit....

Please if you dont know nothing just shush stop spreading the bullshit...

Natsheh · *Last edited by Natsheh; 09-18-2017 at 02:23.*

Here you go...

PHP Code:


			
/* Plugin generated by AMXX-Studio */ 

#include <amxmodx> 
#include <amxmisc> 
#include <cstrike> 
#include <hamsandwich> 
#include <fun> 

#define PLUGIN "FreeNadesGiver" 
#define VERSION "1.0" 
#define AUTHOR "TheSpaniard" 

public plugin_init()  
{ 
    register_plugin(PLUGIN, VERSION, AUTHOR) 
    RegisterHam(Ham_Spawn, "player", "Fwd_PlayerSpawn_Post", 1); 
    register_clcmd("say /nade", "Fwd_PlayerSpawn_Post") 
} 

public Fwd_PlayerSpawn_Post(id) 
{ 
    if(!is_user_alive(id) || !(get_user_flags(id) & ADMIN_LEVEL_H)) 
    { 
        return 0 
    } 
    set_task(1.0, "give_nades", id) 
    return 1 
} 

public give_nades(id)  
{
    if(!is_user_alive(id)) return;
    give_item(id, "weapon_hegranade") 
    cs_set_user_bpammo(id, CSW_HEGRENADE, 2) 
    give_item(id, "weapon_smokegranade") 
    cs_set_user_bpammo(id, CSW_SMOKEGRENADE, 2) 
    give_item(id, "weapon_flashbang") 
    cs_set_user_bpammo(id, CSW_FLASHBANG, 4) 
}

TheSpaniard · *Last edited by TheSpaniard; 09-18-2017 at 04:32.*

Quote:

Originally Posted by Natsheh

Here you go...

PHP Code:


			
/* Plugin generated by AMXX-Studio */ 

#include <amxmodx> 
#include <amxmisc> 
#include <cstrike> 
#include <hamsandwich> 
#include <fun> 

#define PLUGIN "FreeNadesGiver" 
#define VERSION "1.0" 
#define AUTHOR "TheSpaniard" 

public plugin_init()  
{ 
    register_plugin(PLUGIN, VERSION, AUTHOR) 
    RegisterHam(Ham_Spawn, "player", "Fwd_PlayerSpawn_Post", 1); 
    register_clcmd("say /nade", "Fwd_PlayerSpawn_Post") 
} 

public Fwd_PlayerSpawn_Post(id) 
{ 
    if(!is_user_alive(id) || !(get_user_flags(id) & ADMIN_LEVEL_H)) 
    { 
        return 0 
    } 
    set_task(1.0, "give_nades", id) 
    return 1 
} 

public give_nades(id)  
{
    if(!is_user_alive(id)) return;
    give_item(id, "weapon_hegranade") 
    cs_set_user_bpammo(id, CSW_HEGRENADE, 2) 
    give_item(id, "weapon_smokegranade") 
    cs_set_user_bpammo(id, CSW_SMOKEGRENADE, 2) 
    give_item(id, "weapon_flashbang") 
    cs_set_user_bpammo(id, CSW_FLASHBANG, 4) 
}

The code given by DearthMan is very efficient you can check it for yourself at My posted plugin
the code you posted is very small but it can result in crash as it wont check user ammo and add grenades every 15 seconds and if weapon strip is not included in any loaded plugin the player who did not die that round would have huge no of grenades at round start and server can crash. Although the edit you quoted is wrong but before that he gave me right directions.