[Exolent[jNr]]

PHP Code:

    set_user_noclip( plr, get_user_noclip( plr ) ? 0 : 1 ); 


Why not:

PHP Code:

    set_user_noclip( plr, !get_user_noclip( plr ) ); 


[ConnorMcLeod]

This seems to work :

PHP Code:

/*    Formatright © 2009, ConnorMcLeod

    NoClip is free software;
    you can redistribute it and/or modify it under the terms of the
    GNU General Public License as published by the Free Software Foundation.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with NoClip; if not, write to the
    Free Software Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.
*/

#include <amxmodx>
#include <engine>
#include <fun>
#include <hamsandwich>

#define VERSION "0.0.1"

#define MAX_PLAYERS    32

enum {
    NoClipNone,
    NoClipRemove,
    NoClipSet
}

const IN_SOLID_AREA    = (1<<TR_StartSolid)

new g_iNoClip[MAX_PLAYERS+1]

public plugin_init()
{
    register_plugin("NoClip", VERSION, "ConnorMcLeod")

    RegisterHam(Ham_Spawn, "player", "Player_Spawn_Post", 1)
    RegisterHam(Ham_Killed, "player", "Player_Killed_Post", 1)

    register_clcmd("+noclip", "ClientCommand_NoClipOn")
    register_clcmd("-noclip", "ClientCommand_NoClipOff")
}

public Player_Spawn_Post( id )
{
    if( is_user_alive( id ) )
    {
        g_iNoClip[id] = NoClipNone
    }
}

public Player_Killed_Post( id )
{
    g_iNoClip[id] = NoClipNone
}

public ClientCommand_NoClipOn( id )
{
    if( g_iNoClip[id] != NoClipSet && is_user_alive(id) )
    {
        set_user_noclip(id, 1)
        g_iNoClip[id] = NoClipSet
        client_print(id, print_chat, " ** NoClip ON")
    }
    return PLUGIN_HANDLED_MAIN
}

public ClientCommand_NoClipOff( id )
{
    if( g_iNoClip[id] == NoClipSet && is_user_alive(id) )
    {
        g_iNoClip[id] = NoClipRemove
        client_print(id, print_chat, " ** NoClip On Removal")
    }
    return PLUGIN_HANDLED_MAIN
}

public client_PreThink( id )
{
    if( g_iNoClip[id] == NoClipRemove && is_user_alive(id) )
    {
        static Float:vecOrigin[3]
        entity_get_vector(id, EV_VEC_origin, vecOrigin)
        if( !(trace_hull(vecOrigin, entity_get_int(id, EV_INT_flags) & FL_DUCKING ? HULL_HEAD : HULL_HUMAN, id) & IN_SOLID_AREA) )
        {
            set_user_noclip(id, 0)
            g_iNoClip[id] = NoClipNone
            client_print(id, print_chat, " ** NoClip Off")
        }
    }
} 


[Scherzo]

omg i give you simple, engfunc() free way to check it, but you must post your own to prove "I can do it with different method", this with prethink added is the best for me

bravo

[ConnorMcLeod]

The code you provided just sucks.
The code i made just check the best time to remove player noclip, it's just an example, but works fine.
trace_hull method just works fine, feel free to use it or not.

Best regards.

[SchlumPF*]

Originally Posted by Scherzo omg i give you simple, engfunc() free way to check it, but you must post your own to prove "I can do it with different method", this with prethink added is the best for me bravo

omg we post improvements, TraceHull way to check it (more efficient then you did or do now) and youre crying.
i just posted the idea about using tracehull which works great and connor put it in an working plugin, kkthxbye.

(this is the code snippets/ tutorials forum which means ppl SHOULD look at the codes and write suggestions etc to have perfect examples here)

[Scherzo]

if tested and don`t work just remove it and replace with your, any my word more there