[nikhilgupta345]

PHP Code:


enum _:Achievements
{
    Achievement_Name[ 256 ],
    Achievement_Progress[ 33 ],
    Achievement_Requirement,
    Achievement_Reward,
    Achievement_Type
}


public client_putinserver( id )
{
    new aData[ Achievements ];
    
    new iProgress[ 33 ];
    
    for( new i = 0; i < g_iTotalAchievements; i++ )
    {
        ArrayGetArray( g_aAchievements, i, aData );
        iProgress = aData[ Achievement_Progress ];
        
        iProgress[ id ] = 0;
        
        aData[ Achievement_Progress ] = iProgress;
        ArraySetArray( g_aAchievements, i, aData );
    }
    
    LoadData( id );
}

public SaveData( id )
{
    new szSteamID[ 35 ];
    get_user_authid( id, szSteamID, charsmax( szSteamID ) );
    
    new aData[ Achievements ];
    
    new iProgress[ 33 ], szProgress[ 6 ];
    
    new szKey[ 512 ];
    
    for( new i = 0; i < g_iTotalAchievements; i++ )
    {
        ArrayGetArray( g_aAchievements, i, aData );
        
        iProgress = aData[ Achievement_Progress ];
        num_to_str( iProgress[ id ], szProgress, charsmax( szProgress ) );
        
        formatex( szKey, charsmax( szKey ), "%s-%s", aData[ Achievement_Name ], szSteamID );
        
        nvault_set( g_hVault, szKey, szProgress );
        
        server_print( "NVAULT DEBUG SAVE - %s - %i", aData[ Achievement_Name ], iProgress[ id ] );
    }
}  

public LoadData( id )
{
    new szSteamID[ 35 ];
    get_user_authid( id, szSteamID, charsmax( szSteamID ) );
    
    new aData[ Achievements ];
    
    new iAchievementProgress[ 33 ], iPlayerProgress;
    
    new szKey[ 512 ];
    
    for( new i = 0; i < g_iTotalAchievements; i++ )
    {
        ArrayGetArray( g_aAchievements, i, aData );
        
        formatex( szKey, charsmax( szKey ), "%s-%s", aData[ Achievement_Name ], szSteamID );
        iPlayerProgress = nvault_get( g_hVault, szKey );

        iAchievementProgress = aData[ Achievement_Progress ];
        iAchievementProgress[ id ] = iPlayerProgress;
        aData[ Achievement_Progress ] = iAchievementProgress;
        
        ArraySetArray( g_aAchievements, i, aData );
        
        server_print( "NVAULT DEBUG - %s - %i", aData[ Achievement_Name ], iPlayerProgress );
    }
} 


For some reason, even if there is no vault data beforehand, the player always has all cells in Achievement_Progress for all achievements set to 16.

Any ideas?

[Exolent[jNr]]

Not sure, though you could reduce this:

PHP Code:

        iAchievementProgress = aData[ Achievement_Progress ]; 
        iAchievementProgress[ id ] = iPlayerProgress; 
        aData[ Achievement_Progress ] = iAchievementProgress; 


to this:

PHP Code:

        aData[ Achievement_Progress ][ id ] = iPlayerProgress; 


[nikhilgupta345]

Originally Posted by Exolent[jNr] Not sure, though you could reduce this: PHP Code:         iAchievementProgress = aData[ Achievement_Progress ];          iAchievementProgress[ id ] = iPlayerProgress;          aData[ Achievement_Progress ] = iAchievementProgress;  to this: PHP Code:         aData[ Achievement_Progress ][ id ] = iPlayerProgress;

Hmm just realized I've been doing that in the whole plugin. Thanks for the optimization

I have no idea why it's automatically starting at 16. I stop the server, delete the vault file, and then restart it, and when I first create an achievement, I logged it to be equal to 0, but then when I join the server, it gets set to 16.

[wrecked_]

16 is a weird number, considering you have no constant integers (as far as I can see) being assigned in the code shown. Perhaps the issue is coming from another bit.

What is the value of g_iTotalAchievements? Does the server you're testing it on have a maximum of 16 slots (get_maxplayers())?

[nikhilgupta345]

Yes the server has 16 slots.

The value of g_iTotalAchievements is 15.


But none of those numbers are related, because I just tested it again, and now the number is 84..

[nikhilgupta345]

Seemed to have fixed it by using nvault_lookup instead of nvault_get and checking if they key existed beforehand, and if it didn't, then I would set it to 0.