[Werewolf_UK]

Just tested votebanning myself then tried to rejoin, I was sucessfully banned.

[Dr. McKay]

I just updated the plugin earlier in the thread, try it now.

[Werewolf_UK]

Re-downloaded both files, and uploaded both to the proper respective folders. Restarted the server, connected and votebaned myself.

I now have 81 separate, 5-minutes bans, all issued at the same time! They all also list our servers website as the ban reason, not "Banned by Vote"

EDIT: Correction, one of the bans was for 30 minutes, but I only noticed it as I was mass-deleting the bans and didn't get a chance to check its listed reason

[Dr. McKay]

Originally Posted by sgt_phsco Re-downloaded both files, and uploaded both to the proper respective folders. Restarted the server, connected and votebaned myself. I now have 81 separate, 5-minutes bans, all issued at the same time! They all also list our servers website as the ban reason, not "Banned by Vote" EDIT: Correction, one of the bans was for 30 minutes, but I only noticed it as I was mass-deleting the bans and didn't get a chance to check its listed reason

I see absolutely no reason why this should happen, unless the server itself was banning you 81 times.

[Werewolf_UK]

At first I thought I could have been some kind of backlog from previous times I had been votekicked/banned because I've often used those commands on myself when testing.

However I just used voteban on 2 other players and both of them had 81 extra bans. I'm going to remove the plugin for now, but I hope this can get fixed soon

[melaf]

[Potatofactory]

Originally Posted by Dr. McKay This should work.

I tried this and it spams the ban a huge amount of times

[Walliski]

Wild guess since I am in no way a Sourcemod plugins developer: The sourcebans plugin also calls a function named BanClient, which means that when you ban a client with the plugin, the plugin will trigger itself?

[Werewolf_UK]

I thought I'd give this another try with latest SourceBans and SourceMod.

I get this:

L 12/28/2013 - 173:46: [SM] Plugin encountered error 8: Not enough space on the stack L 12/28/2013 - 173:46: [SM] Displaying call stack trace for plugin "sourcebans.smx": L 12/28/2013 - 173:46: [SM] [0] Line 2294, D:\scripting\sourcebans.sp::UTIL_InsertBan() L 12/28/2013 - 173:46: [SM] [1] Line 2274, D:\scripting\sourcebans.sp::CreateBan() L 12/28/2013 - 173:46: [SM] [2] Line 2389, D:\scripting\sourcebans.sp:repareBan() L 12/28/2013 - 173:46: [SM] [3] Line 2198, D:\scripting\sourcebans.sp::Native_SBBanPlaye r() L 12/28/2013 - 173:46: [SM] Plugin encountered error 8: Not enough space on the stack L 12/28/2013 - 173:46: [SM] Native "SBBanPlayer" reported: Error encountered while processing a dynamic native L 12/28/2013 - 173:46: [SM] Displaying call stack trace for plugin "sourcebans_listener.smx": L 12/28/2013 - 173:46: [SM] [0] Line 21, /home/groups/alliedmodders/forums/files/1/5/0/8/4/5/110631.attach::OnBanClient()

[DJ Tsunami]

SBBanPlayer eventually calls banid, which calls OnBanClient again, causing an infinite loop. I think it should be more along these lines:

PHP Code:

public Action:OnBanClient(client, time, flags, const String:reason[], const String:kick_message[], const String:command[], any:source) {
    if(StrEqual(command, "banid")) {
        return Plugin_Continue;
    }
    if(source < 0 || source > MaxClients) {
        return Plugin_Continue;
    }
    if(source > 0 && (!IsClientInGame(source) || GetUserAdmin(source) == INVALID_ADMIN_ID)) {
        return Plugin_Continue;
    }
    
    SBBanPlayer(source, client, time, reason);
    return Plugin_Handled;
}