[T1MOXA]

Yes, I know that 7z didn't you.
But unfortunately I did not find a solution to my problem in the network, so I decided to ask you.
Yes, I wrote the plugin for myself.
I'll try a lower compression level.

[694372459]

Hi, I've tested FTP download feature, after finish the downloaded file is 0kb (empty), can you check it?

P.S the legacy ftp download native works fine

[dordnung]

Hey,
can you show me the part of your code, as it works fine for me?

[694372459]

Originally Posted by dordnung Hey, can you show me the part of your code, as it works fine for me?

Hi, thanks for replying

here's my code:

PHP Code:

#include <sourcemod>
#include <system2>

#define FTP_HOST ""
#define FTP_PORT
#define FTP_USER ""
#define FTP_PWD ""
#define FTP_REQUEST_FILE ""

public OnPluginStart()
{
    RegServerCmd("test_ftp_download", Command_TestDownload);
}

public Action:Command_TestDownload(args)
{
    System2FTPRequest ftpRequest = new System2FTPRequest(FtpResponseCallback, FTP_REQUEST_FILE);
    ftpRequest.SetAuthentication(FTP_USER, FTP_PWD);
    ftpRequest.SetPort(FTP_PORT);
    ftpRequest.SetOutputFile("addons/sourcemod/data/test_ftp_download.txt");
    ftpRequest.StartRequest(); 
    delete ftpRequest;
    
    return Plugin_Handled;
}

public void FtpResponseCallback(bool success, const char[] error, System2FTPRequest request, System2FTPResponse response) {
    if (success) {
        char file[PLATFORM_MAX_PATH];
        request.GetInputFile(file, sizeof(file));

        if (strlen(file) > 0) {
            PrintToServer("Download Finished");    
        }
    }
} 


[Papero]

Originally Posted by 694372459 Hi, thanks for replying here's my code: PHP Code: #include <sourcemod> #include <system2> #define FTP_HOST "" #define FTP_PORT #define FTP_USER "" #define FTP_PWD "" #define FTP_REQUEST_FILE "" public OnPluginStart() {     RegServerCmd("test_ftp_download", Command_TestDownload); } public Action:Command_TestDownload(args) {     System2FTPRequest ftpRequest = new System2FTPRequest(FtpResponseCallback, FTP_REQUEST_FILE);     ftpRequest.SetAuthentication(FTP_USER, FTP_PWD);     ftpRequest.SetPort(FTP_PORT);     ftpRequest.SetOutputFile("addons/sourcemod/data/test_ftp_download.txt");     ftpRequest.StartRequest();      delete ftpRequest;          return Plugin_Handled; } public void FtpResponseCallback(bool success, const char[] error, System2FTPRequest request, System2FTPResponse response) {     if (success) {         char file[PLATFORM_MAX_PATH];         request.GetInputFile(file, sizeof(file));         if (strlen(file) > 0) {             PrintToServer("Download Finished");             }     } }

Shouldn't you close (delete) the FTP request handle (only) in the callback?

Also avoid mixing old and new syntax

[dordnung]

Shouldn't you close (delete) the FTP request handle (only) in the callback?

No it should not be deleted in the callback, as a copy is used there which will be deleted automatically after the callback. It should be deleted after making a request or when not used anymore.

Thanks for reporting it, I found the problem. I've forgot to close the file after downloading, thats why it was empty. This is fixed now.
But the "GetInputFile" part does not make sense. The input file is only set when uploading stuff to a FTP server.

Update to System2 v3.2.1

- Automatically use 32-Bit 7-ZIP when 64-Bit is not executable
- Fix incomplete file when downloading files with FTP
- Added libcurl certificate file for SSL instead of using system's certificate file
- Updated to the latest libcurl version

[T1MOXA]

For some reason, files are not always archived on the same server, there are no problems with manual compression.
How to understand the cause of the error ?

[NanoC]

Originally Posted by T1MOXA For some reason, files are not always archived on the same server, there are no problems with manual compression. How to understand the cause of the error ?

something like this?
https://github.com/dordnung/System2/issues/9

[ph]

Originally Posted by nomy [SM] Unable to load extension "system2.ext": Could not find interface: IPluginManager Game: CS:S

Can this be fixed?

TF2

[TandelK]

How do we use Passive FTP Method with this plugin ? I have unlimited Web Hosting and they are using Passive FTP Hosting and i tried it using a plugin via FTP directly but it seems it is not working properly. I am trying to upload Demos after matches are completed.