Raised This Month: $51 Target: $400
 12% 

Survivor


Post New Thread Reply   
 
Thread Tools Display Modes
Brad
AMX Mod X Team Member
Join Date: Jun 2004
Old 07-21-2009 , 15:33   Re: Survivor
Reply With Quote #11

These need to be fixed before this plugin gets approved:
  • You apparently have some debug code left in the source code. Either don't include debug code in a final release or do so, but have it disabled by default, and allow the server op to turn it on. Following is one example of where you have debug code:
PHP Code:
public client_disconnect(Index) {
       
/*
     * In survivor mode, catch survivor diconnection.
    */
    
    
if(g_survivormode) {
        
// If current survivor disconnects, select another one.
        
if(Index==g_survivor_user) {
            
log_amx("Survivor %d disconnects."Index);
            
g_survivor_user PrepareSurvivor(10);
            
log_amx("New survivor index: %d"g_survivor_user);
        }
    }

  • If you're going to use the ML system, which I recommend everyone does, then make sure your entire plugin uses it. Following is one example that isn't using the ML system:
PHP Code:
console_print(Id"No way. Round is finished. Try again in 2 seconds, please."); 
  • Be consistent in how you program. For instance, on function calls you use two different variations, for example:
PHP Code:
eventOnRoundEnd 
PHP Code:
eventOnRoundEnd(); 
Failure to respond to these concerns within a week will cause the plugin to be unapproved. If it becomes unapproved, and you feel that you've addressed these concerns adequately, you can PM any plugin approver to have it reviewed again.

One other concern that doesn't involve approval, but is a best-practice... If you are ending your lines with semicolons, then you should put the following line after the last #include line:
Code:
#pragma semicolon 1
That will enforce that aspect of your coding standard.
Brad is offline
Kukulis :*
Member
Join Date: Apr 2009
Location: www.godlike.lt
Old 07-21-2009 , 16:01   Re: Survivor
Reply With Quote #12

Lithuanian translation.
Code:
[lt]
MSG_ROUNDEND = Jokiu budu, raundas nepasibaige. Prasom pabandyti dar karta po 2 sekundziu.
MSG_NOMINATION_OK = Gerai. %s buvo paskirtas sekmingai, kad taptu kitu isgyventoju.
MSG_PLAYER_NOTFOUND = %s nebuvo surastas.
ROUNDSTART_SURVIVOR = Jus galite Isgyventi? Jus galite pirkti ir panaudoti granata (as).
ROUNDSTART_ENEMIES = Catch-n-Slave Isgyventojas! Dumu granatos vartojimas yra leistas.
ROUNDEND_ALL = Isgyventojo raundas baigtas! Isgyventojo fragai: %d.
Kukulis :* is offline
Send a message via Skype™ to Kukulis :*
kernelInspired
Junior Member
Join Date: Apr 2009
Old 07-28-2009 , 18:36   Re: Survivor
Reply With Quote #13

Kukulis :*, thank you for lithuanian translation.

I've also updated plugin source code according to the hints - thanx for such a detailed description!

Current version is 1.0
kernelInspired is offline
Hawk552
AMX Mod X Moderator
Join Date: Aug 2005
Old 08-14-2009 , 16:14   Re: Survivor
Reply With Quote #14

There are a few mistakes and optimizations that can be made, however it is acceptable.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Approved.
__________________
Hawk552 is offline
Send a message via AIM to Hawk552
thebarry1394
Junior Member
Join Date: Mar 2010
Old 03-24-2010 , 20:05   Re: Survivor
Reply With Quote #15

is there a way to set all the bots (when playing with bots) with knife, and the non-bot players use guns to kill them, like zombie swarm?
thebarry1394 is offline
NucL3ra
Veteran Member
Join Date: Sep 2008
Location: Bucuresti , Romania
Old 03-24-2010 , 22:33   Re: Survivor
Reply With Quote #16

What about if you win the round as a survivor you will still be a survivor. The one who kills you becomes a survivor next round ?
Like a DeathRun ... with guns
NucL3ra is offline
Send a message via Yahoo to NucL3ra
DruGzOG
Veteran Member
Join Date: Nov 2007
Location: Unknown
Old 03-29-2010 , 22:11   Re: Survivor
Reply With Quote #17

There is another plugin around here that does that. + This plugin's idea is completely different.
__________________
DruGzOG is offline
Send a message via AIM to DruGzOG
xClaw
Member
Join Date: Feb 2010
Old 04-05-2010 , 15:18   Re: Survivor
Reply With Quote #18

Hi,

I've been using this mod on my server to add another fun element to it.

There's only a small request I would like to make.

Is it possible to make it so that the survivor can't buy any weapons?

I ask this because most players will espontaneously either press F1 or buy a new weapon when the round is started and they drop the AWP they get and they can't switch back to the weapon they bought because the plugin doesn't allow it.
xClaw is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 07:16.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode