[Sanjay Singh]

someone optimize code for me

PHP Code:

#include <amxmodx>
#include <amxmisc>
#include <cstrike>
#include <fakemeta>
#include <hamsandwich>
#include <csx>

#define TASK_PRESENTS 1337
#define TASK_SHOWHUD 2674

#define ID_PRESENTS (TaskIndex - TASK_PRESENTS)
#define ID_SHOWHUD (TaskIndex - TASK_SHOWHUD)


// Variabile
new MesajSync;


// Cvaruri
new cvar_hudenable

public plugin_init()
{
   register_plugin("Hud Info", "1.1", "")
   
   // Register Cvars
   cvar_hudenable = register_cvar("credits_hudstats", "1")
   
   // Register Messages
   MesajSync = CreateHudSyncObj()
   
   register_message(get_user_msgid("SayText"), "message")
   register_logevent("round_start", 2, "1=Round_Start")

   
}

public client_putinserver(id)
{
   set_task(1.0, "MesajHUD", id+TASK_SHOWHUD, .flags = "b")
}


public MesajHUD(TaskIndex)
{
   static id
   id = ID_SHOWHUD;
   
   if (!is_user_alive(id))
   {
      id = pev(id, pev_iuser2)
      
      if(!is_user_alive(id)) return;
   }
   
   if (get_pcvar_num(cvar_hudenable))
   {
      if(id != ID_SHOWHUD)
      {
        new name[32];
        get_user_name(id, name, 31)

        new stats[ 8 ], body[ 8 ];

           new rank_pos = get_user_stats( id, stats, body )
        new rank_max = get_statsnum( )

        set_hudmessage(0, 100, 250, -1.0, 0.78, 0, 6.0, 1.1, 0.0, 0.0, -1)
        ShowSyncHudMsg(ID_SHOWHUD, MesajSync, "[ Spectating %s | Rank: %d/%d ]", name, rank_pos, rank_max)
     }
   }
} 


[Napoleon_be]

Untested. Could probably be done more efficient using Ham_Killed etc.

PHP Code:

/* Plugin generated by AMXX-Studio */

#include <amxmodx>
#include <csstats>
#include <fakemeta_util>

#define PLUGIN "ShowSpecInfo"
#define VERSION "1.0"
#define AUTHOR "NapoleoN#"

#define TASKID 546873

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR);
}

public client_putinserver(id)
{
    set_task(1.0, "ShowSpecInfo", id + TASKID, _, _, "b");
}

public client_disconnect(id)
{
    if(task_exists(id + TASKID))
        remove_task(id + TASKID)
}

public ShowSpecInfo(id)
{
    id -= TASKID
    if(!is_user_alive(id))
    {
        new iPlayers[32], iNum, iSpecPlayer, szName[33], iRank, iMaxRank, iStats[8], iBodyHits[8];
        get_players(iPlayers, iNum, "ch");
        
        iMaxRank = get_statsnum();
        
        for(new i; i < iNum; i++)
        {
            iSpecPlayer = pev(iPlayers[i], pev_iuser2);
            
            if(is_user_alive(iSpecPlayer))
            {
                get_user_name(iSpecPlayer, szName, charsmax(szName));
                
                iRank = get_user_stats(iSpecPlayer, iStats, iBodyHits);
            }
        }
        set_hudmessage(180, 180, 180, -1.0, 0.0, 0, 6.0, 1.1, 0.0,0.0, -1);
        show_hudmessage(id, "Spectating [%s] | [Rank: %i / %i]", szName, iRank, iMaxRank);
    }
} 


[HamletEagle]

Originally Posted by Napoleon_be Untested. Could probably be done more efficient using Ham_Killed etc. PHP Code: /* Plugin generated by AMXX-Studio */ #include <amxmodx> #include <csstats> #include <fakemeta_util> #define PLUGIN "ShowSpecInfo" #define VERSION "1.0" #define AUTHOR "NapoleoN#" #define TASKID 546873 public plugin_init()  {     register_plugin(PLUGIN, VERSION, AUTHOR); } public client_putinserver(id) {     set_task(1.0, "ShowSpecInfo", id + TASKID, _, _, "b"); } public client_disconnect(id) {     if(task_exists(id + TASKID))         remove_task(id + TASKID) } public ShowSpecInfo(id) {     id -= TASKID     if(!is_user_alive(id))     {         new iPlayers[32], iNum, iSpecPlayer, szName[33], iRank, iMaxRank, iStats[8], iBodyHits[8];         get_players(iPlayers, iNum, "ch");                  iMaxRank = get_statsnum();                  for(new i; i < iNum; i++)         {             iSpecPlayer = pev(iPlayers[i], pev_iuser2);                          if(is_user_alive(iSpecPlayer))             {                 get_user_name(iSpecPlayer, szName, charsmax(szName));                                  iRank = get_user_stats(iSpecPlayer, iStats, iBodyHits);             }         }         set_hudmessage(180, 180, 180, -1.0, 0.0, 0, 6.0, 1.1, 0.0,0.0, -1);         show_hudmessage(id, "Spectating [%s] | [Rank: %i / %i]", szName, iRank, iMaxRank);     } }

Why is that get_players loop in there? iRank and szName will contain the values for the last player that's being spectated, not the one the current player(with id "id") is currently spectating. There's no need to loop.

This is enough(basically what op had before):

PHP Code:

iSpecPlayer = pev(id, pev_iuser2);
get_user_name(iSpecPlayer, szName, charsmax(szName));
iRank = get_user_stats(iSpecPlayer, iStats, iBodyHits);

set_hudmessage(180, 180, 180, -1.0, 0.0, 0, 6.0, 1.1, 0.0,0.0, -1);
show_hudmessage(id, "Spectating [%s] | [Rank: %i / %i]", szName, iRank, iMaxRank); 


The only thing that's worth "optimizing" is to create only one task in plugin_init instead of creating a task for each player. Then inside the global task you would use get_players as you tried to, get all dead players(use flag b, don't check with is_user_alive), retrieve iuser2 and show the hud.

[Sanjay Singh]

bdw why TASKID is used ?

[Napoleon_be]

https://forums.alliedmods.net/showthread.php?t=125638

[Sanjay Singh]

so if i remove taskid it wont affect any thing and work fine .

[Napoleon_be]

Originally Posted by Sanjay Singh so if i remove taskid it wont affect any thing and work fine .

In this case yes, cause you're only using 1 task. If you're using multiple tasks in a plugin you should use TASKID's to seperate each task from the player.

Also, is the plugin doing the job or is it not?

[georgik57]

Wanted to make it better but then I remembered you could just add this line in your addons/amxmodx/configs/stats.ini file and have the same functionality so I dropped it:

PHP Code:

SpecRankInfo             ;Spec. Rank Info 


PHP Code:

#include <amxmodx>
#include <csstats>
#include <fakemeta>
#include <hamsandwich>

// Cvaruri
new g_iIDPCVarHudEnable;

public plugin_init()
{
    register_plugin("Hud Info", "1.1", "")
    register_dictionary("statscfg.txt")
    
    // Register Cvars
    g_iIDPCVarHudEnable = register_cvar("credits_hudstats", "1");
    
    RegisterHam(Ham_Spawn, "player", "fwHamSpawnPlayer", 1)
    RegisterHam(Ham_Killed, "player", "fwHamKilledPlayer", 1)
}

public client_putinserver(iID)
{
    set_task(1.0, "fwTaskShowHud", iID, .flags = "b")
}

public fwHamSpawnPlayer(const iID)
{
    if (!is_user_alive(iID))
        return;
    
    remove_task(iID)
}

public fwHamKilledPlayer(const iID)
{
    set_task(1.0, "fwTaskShowHud", iID, .flags = "b")
}

#if AMXX_VERSION_NUM <= 182
public client_disconnect(iID)
#else
public client_disconnected(iID)
#endif
{
    remove_task(iID)
}

public fwTaskShowHud(const iID)
{
    if (!get_pcvar_num(g_iIDPCVarHudEnable))
        return;
    
    // AMXX 182 and lower have issues and client disconnect forwards don't trigger for
    // all the cases so we need to "manually" check if client is still connected too
    #if AMXX_VERSION_NUM <= 182
    if (!is_user_connected(iID))
    {
        remove_task(iID)
        
        return;
    }
    #endif
    
    new iIDSpec = pev(iID, pev_iuser2);
    
    if(!iIDSpec || iIDSpec == iID)
        return;
    
    // Player max name length is 31
    new szName[31];
    get_user_name(iID, szName, charsmax(szName))
    
    new iTemp[8], iRankSpec;
    iRankSpec = get_user_stats(iIDSpec, iTemp, iTemp);
    
    iTemp[0] = get_statsnum();
    
    // Avoid using automatic channel and/or hud sync because they create hud flicker issues
    set_hudmessage(0, 100, 250, -1.0, 0.78, 0, 0.0, 1.05, 0.0, 0.0, 2)
    show_hudmessage(iIDSpec, "[ %L ^"%s^": %d/%d ]", iID, "ST_SPEC_RANK", szName, iRankSpec, iTemp[0])
} 


[Napoleon_be]

Well this was my original code, so i guess i fucked it up even more than trying to optimize it lol

PHP Code:

/* Plugin generated by AMXX-Studio */

#include <amxmodx>
#include <csstats>
#include <fakemeta_util>
#include <hamsandwich>

#define PLUGIN "ShowSpecInfo"
#define VERSION "1.0"
#define AUTHOR "NapoleoN#"

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR);
    
    set_task(1.0, "ShowSpecInfo", .flags = "b");
}

public ShowSpecInfo()
{
    new iPlayers[32], iNum, iSpecPlayer, szName[33], iRank, iMaxRank, iStats[8], iBodyhits[8];
    get_players(iPlayers, iNum, "bch");
    
    iMaxRank = get_statsnum();
    
    for(new i; i < iNum; i++)
    {
        iSpecPlayer = pev(iPlayers[i], pev_iuser2);
        
        get_user_name(iSpecPlayer, szName, charsmax(szName));
            
        iRank = get_user_stats(iSpecPlayer, iStats, iBodyhits);
            
        set_hudmessage(180, 180, 180, -1.0, 0.0, 0, 6.0, 1.1, 0.0,0.0, -1);
        show_hudmessage(iPlayers[i], "Spectating [%s] | [Rank: %i / %i]", szName, iRank, iMaxRank);
            
    }
}