[Begineer Programmer]

Hi All !!!
i need little help when mapname cfg file not found its should return 0 and if file exist and have no value of mp_maxrounds then should also return 0 and printed to 0 but it print 1 why ? [Where i have done mistake !!!] [See Red Highlighted One !!!]

PHP Code:

#include <amxmodx> 
#include <cstrike>
#include <amxmisc>
#pragma semicolon 1
#pragma tabsize 4
new runde = 0;
new prefix[32] = "AMXX";
new TerrScore, CTScore;
public plugin_init()  
{ 
    register_plugin( "Info Top", "1.4", "->UrOS<-");    
    register_event("HLTV", "round_start", "a", "1=0", "2=0");
    register_event("TextMsg", "round_restart", "a", "2=#Game_will_restart_in", "2=#Game_Commencing");
    register_event("TeamScore", "terr_score", "a", "1=TERRORIST");
    register_event("TeamScore", "ct_score", "a", "1=CT");
} 
public round_restart()
{
    runde = 0;
    TerrScore=0;
    CTScore=0;
}
public terr_score()
{
    TerrScore = read_data(2);
}
public ct_score()
{
    CTScore = read_data(2);
}
public round_start() 
{ 
    
    
    new mapname[32], nextmap[32], players[32], player ,maxrundi, maxplayers,maxroundsCvar;
    
    maxrundi=get_cvar_num("mp_maxrounds");
    maxplayers=get_maxplayers();
    get_cvar_string("amx_nextmap",nextmap,31); 
    get_mapname(mapname,31);
    get_players(players, player);
    maxroundsCvar=get_map_maxrounds(mapname);
    client_print_color(0,print_team_default,"^4[%s]^3 Rounds:^4 %d^3/^4%d ^1|^3 Score:^3 Ts:^4%i^3 -^3 CTs:^4%i ^1|^3 Map:^4 %s^3/^4%s [%i] ^1|^3 Players:^4 %d^3/^4%d",prefix, runde,maxrundi,TerrScore,CTScore,mapname, nextmap,maxroundsCvar, player,maxplayers); 
    runde++;
}

get_map_maxrounds(szMapname[])
{
    new szConfigsDir[64], szFilePath[128];
    get_configsdir(szConfigsDir, charsmax(szConfigsDir));
    format(szFilePath, charsmax(szFilePath), "%s/maps/%s.cfg",szConfigsDir, szMapname);
    new f = fopen(szFilePath, "rt");
    if( f )
    {
        new szCvar[32], szValue[32], szCfgData[64],iValue;
    
        while(fgets(f, szCfgData, charsmax(szCfgData)))
        {
            parse(szCfgData, szCvar, charsmax(szCvar), szValue, charsmax(szValue));
        
            if(equali(szCvar, "mp_maxrounds"))
            {
                iValue = str_to_num(szValue);    
            }
            
        }
        fclose(f);
        return iValue==1?iValue:0;
    }
    return PLUGIN_HANDLED;
} 


[jimaway]

PLUGIN_HANDLED is 1, you're returning it if the file couldn't be opened

[Begineer Programmer]

Originally Posted by jimaway PLUGIN_HANDLED is 1, you're returning it if the file couldn't be opened

I rename it as PLUGIN_CONTINUE !!!

PHP Code:

#include <amxmodx> 
#include <cstrike>
#include <amxmisc>
#pragma semicolon 1
#pragma tabsize 4
new runde = 0;
new prefix[32] = "AMXX";
new TerrScore, CTScore;
public plugin_init()  
{ 
    register_plugin( "Info Top", "1.4", "->UrOS<-");    
    register_event("HLTV", "round_start", "a", "1=0", "2=0");
    register_event("TextMsg", "round_restart", "a", "2=#Game_will_restart_in", "2=#Game_Commencing");
    register_event("TeamScore", "terr_score", "a", "1=TERRORIST");
    register_event("TeamScore", "ct_score", "a", "1=CT");
} 
public round_restart()
{
    runde = 0;
    TerrScore=0;
    CTScore=0;
}
public terr_score()
{
    TerrScore = read_data(2);
}
public ct_score()
{
    CTScore = read_data(2);
}
public round_start() 
{ 
    
    
    new mapname[32], nextmap[32], players[32], player ,maxrundi, maxplayers,maxroundsCvar;
    
    maxrundi=get_cvar_num("mp_maxrounds");
    maxplayers=get_maxplayers();
    get_cvar_string("amx_nextmap",nextmap,31); 
    get_mapname(mapname,31);
    get_players(players, player);
    maxroundsCvar=get_map_maxrounds(mapname);
    if (maxroundsCvar==0)
    {
        client_print_color(0,print_team_default,"^4[%s]^3 Rounds:^4 %d^3/^4%d ^1|^3 Score:^3 Ts:^4%i^3 -^3 CTs:^4%i ^1|^3 Map:^4 %s^3/^4%s [No Round Limit] ^1|^3 Players:^4 %d^3/^4%d",prefix, runde,maxrundi,TerrScore,CTScore,mapname, nextmap, player,maxplayers);
    }
    else
    {
        client_print_color(0,print_team_default,"^4[%s]^3 Rounds:^4 %d^3/^4%d ^1|^3 Score:^3 Ts:^4%i^3 -^3 CTs:^4%i ^1|^3 Map:^4 %s^3/^4%s [%i] ^1|^3 Players:^4 %d^3/^4%d",prefix, runde,maxrundi,TerrScore,CTScore,mapname, nextmap,maxroundsCvar, player,maxplayers);
    }
     
    runde++;
}

get_map_maxrounds(szMapname[])
{
    new szConfigsDir[64], szFilePath[128];
    get_configsdir(szConfigsDir, charsmax(szConfigsDir));
    format(szFilePath, charsmax(szFilePath), "%s/maps/%s.cfg",szConfigsDir, szMapname);
    new f = fopen(szFilePath, "rt");
    if( f )
    {
        new szCvar[32], szValue[32], szCfgData[64],iValue;
    
        while(fgets(f, szCfgData, charsmax(szCfgData)))
        {
            parse(szCfgData, szCvar, charsmax(szCvar), szValue, charsmax(szValue));
        
            if(equali(szCvar, "mp_maxrounds"))
            {
                iValue = str_to_num(szValue);    
            }
            
        }
        fclose(f);
        return iValue;
    }
    return PLUGIN_CONTINUE;
} 


[fysiks]

Do NOT use PLUGIN_CONTINUE because it makes no sense in the context. You should simply return a 0.

[Begineer Programmer]

Originally Posted by fysiks Do NOT use PLUGIN_CONTINUE because it makes no sense in the context. You should simply return a 0.

Thanks and Updated !!!

PHP Code:

#include <amxmodx> 
#include <cstrike>
#include <amxmisc>
#pragma semicolon 1
#pragma tabsize 4
new runde = 0;
new prefix[32] = "AMXX";
new TerrScore, CTScore;
public plugin_init()  
{ 
    register_plugin( "Info Top", "1.4", "->UrOS<-");    
    register_event("HLTV", "round_start", "a", "1=0", "2=0");
    register_event("TextMsg", "round_restart", "a", "2=#Game_will_restart_in", "2=#Game_Commencing");
    register_event("TeamScore", "terr_score", "a", "1=TERRORIST");
    register_event("TeamScore", "ct_score", "a", "1=CT");
} 
public round_restart()
{
    runde = 0;
    TerrScore=0;
    CTScore=0;
}
public terr_score()
{
    TerrScore = read_data(2);
}
public ct_score()
{
    CTScore = read_data(2);
}
public round_start() 
{ 
    
    
    new mapname[32], nextmap[32], players[32], player ,maxrundi, maxplayers,maxroundsCvar;
    
    maxrundi=get_cvar_num("mp_maxrounds");
    maxplayers=get_maxplayers();
    get_cvar_string("amx_nextmap",nextmap,31); 
    get_mapname(mapname,31);
    get_players(players, player);
    maxroundsCvar=get_map_maxrounds(mapname);
    if (maxroundsCvar==0)
    {
        client_print_color(0,print_team_default,"^4[%s]^3 Rounds:^4 %d^3/^4%d ^1|^3 Score:^3 Ts:^4%i^3 -^3 CTs:^4%i ^1|^3 Map:^4 %s^3/^4%s ^1[^4No Round Limit^1] ^1|^3 Players:^4 %d^3/^4%d",prefix, runde,maxrundi,TerrScore,CTScore,mapname, nextmap, player,maxplayers);
    }
    else
    {
        client_print_color(0,print_team_default,"^4[%s]^3 Rounds:^4 %d^3/^4%d ^1|^3 Score:^3 Ts:^4%i^3 -^3 CTs:^4%i ^1|^3 Map:^4 %s^3/^4%s ^1[^4%i^1] ^1|^3 Players:^4 %d^3/^4%d",prefix, runde,maxrundi,TerrScore,CTScore,mapname, nextmap,maxroundsCvar, player,maxplayers);
    }
     
    runde++;
}
get_map_maxrounds(szMapname[])
{
    new szConfigsDir[64], szFilePath[128];
    get_configsdir(szConfigsDir, charsmax(szConfigsDir));
    format(szFilePath, charsmax(szFilePath), "%s/maps/%s.cfg",szConfigsDir, szMapname);
    new f = fopen(szFilePath, "rt");
    if( f )
    {
        new szCvar[32], szValue[32], szCfgData[64],iValue;
    
        while(fgets(f, szCfgData, charsmax(szCfgData)))
        {
            parse(szCfgData, szCvar, charsmax(szCvar), szValue, charsmax(szValue));
        
            if(equali(szCvar, "mp_maxrounds"))
            {
                iValue = str_to_num(szValue);    
            }
            
        }
        fclose(f);
        return iValue;
    }
    return 0;
} 


[Natsheh]

Btw you should return a negative numbers when an error occur, it help understanding the problem...