[retsam]

Im not sure whats easier to do but, one thing I noticed is the sm_orgasm_fireworks_trigger "6.0" obviously is set to go off after 6 streaks right. You might consider it happening every 6 streaks instead of just one? So in the off chance they get another 6 or so after, it plays the particle again, rather than just 1 time.

Its not really necessary but, just something I noticed. That would have to be alot of damn killing before dying but....im sure its possible on some servers.

[BrutalGoerge]

Whoever downloaded it, there was a mistake in the code, and you should download it again now.

[retsam]

The only thing I can see that might be improved now is, attaching the particle to players head. It plays from the players head, but its not attached. Thus, any moving player will emit the particle but itll be hoving in mid air if they move any distance.

Im not sure if you wanted it that way, but its fairly easy to attach it to a players head. Personally I think it would look better attached.

This is a little cut from a plugin that I use.

new String:gName[128]
    if (IsValidEdict(particle))
    {
          new Float:pos[3];
          
          GetEntPropVector(ent, Prop_Send, "m_vecOrigin", pos);
          
          pos[2] += Zpos; //this is the z coordinate for the particle..moves it up or down
          
          TeleportEntity(particle, pos, NULL_VECTOR, NULL_VECTOR)
          Format(gName, sizeof(gName), "target%i", ent)
          DispatchKeyValue(ent, "targetname", gName)
          
          DispatchKeyValue(particle, "targetname", "tf2particle")
          DispatchKeyValue(particle, "parentname", gName)
          DispatchKeyValue(particle, "effect_name", particleType)
          
          DispatchSpawn(particle)
          SetVariantString(gName)
          AcceptEntityInput(particle, "SetParent", particle, particle, 0)
          
          SetVariantString("head");
          AcceptEntityInput(particle, "SetParentAttachment", particle, particle, 0)
          ActivateEntity(particle)
          AcceptEntityInput(particle, "start")
          
          g_Ent2[ent] = particle
  }

[BrutalGoerge]

kewlio

[retsam]

One other small detail I noticed poking around.

I dont think youre deleting the particles. Or at least, it doesnt look like it. I was told you should always delete any particle you attach to a player. I see you got the DeleteParticle section, but it doesnt look like its ever called. It might be smart to delete the particles after they are played. Or perhaps on death? Im not an expert so heh.


Also, you can choose not to do it but, for mine I changed the way it plays the particles. I think it looks way better this way. That will play the thing twice fully instead of stopping the animation of the previous loop. By default you have the delay set way too high too. It displays the msg and plays the birthday sound, but the particle doesnt get played for a while, just doesnt look right to me. Anyways....thats how I did it for mine.

StartLooper(client)
{
    CreateTimer(0.3, Timer_Particles, client);
    CreateTimer(1.3, Timer_Particles, client);
    g_iLoops = 2;
}

If you can figure out how to attach the particle to players head(I couldnt get it to compile for me), and properly delete it after its played, I think this plugin will be perfect. I got 4 tf2 servers that are full 24/7 that I cant wait to add it onto.

[BrutalGoerge]

the thing disappears after it runs, so i don't see the point. :\

I'm though a noob at particle crap, so if there is actually a reason to delete it, i'll look at it


edit
i put it in, who made the code you posted?

[retsam]

I know that. Maybe someone more experienced can talk on that. I was told that even though a particle is only briefly played and is no longer "seen", it should still be removed from the player. That could be wrong tho. It may make no difference. : /

I guess might be best to ask around for that. I know if the deleting of particles isnt needed, it should be kicking out a console error msg about something related to the particle system...so maybe keep an eye out for that. I dont know : /


Which code are you referring to? The timer part or the particle attaching to player head part? Well, a friend on this forum did the particle part, but ive seen many examples in other plugins. I use it in my rtd plugin. I attach particles to players heads with it, so I know it works.

Anyways. Thanks man. I see you added that already.

[OziOn]

The "First blood" announcement sound needs to be turned off when in Arena mode...

[BrutalGoerge]

Originally Posted by OziOn The "First blood" announcement sound needs to be turned off when in Arena mode...

k

[retsam]

Hey....Just a few updates.

One of our linux servers is crashign from something. I dont necessarily think its this plugin, but there are some errors that need fixing. Check this out. Hope this helps? If you could fix those, it would be greatly appreciated.

05/19/2009 - 02:41:45: SourceMod error session started
L 05/19/2009 - 02:41:45: Info (map "cp_orange_x3") (file "errors_20090519.log")
L 05/19/2009 - 02:41:45: [SM] Native "IsFakeClient" reported: Client index 0 is invalid
L 05/19/2009 - 02:41:45: [SM] Displaying call stack trace for plugin "orgasm_mcgedit.smx":
L 05/19/2009 - 02:41:45: [SM] [0] Line 159, orgasm_mcgedit.sp::hook_Death()
L 05/19/2009 - 02:515: [SM] Native "EmitSound" reported: Client index 0 is invalid
L 05/19/2009 - 02:515: [SM] Displaying call stack trace for plugin "orgasm_mcgedit.smx":
L 05/19/2009 - 02:515: [SM] [0] Line 370, C:\Game_Servers\TF2_SERVER\orangebox\tf\addon s\sourcemod\scripting\include\sdktools_sound. inc::EmitSoundToClient()
L 05/19/2009 - 02:515: [SM] [1] Line 272, orgasm_mcgedit.sp::hook_Death()
L 05/19/2009 - 05:04:12: [SM] Native "IsFakeClient" reported: Client index 0 is invalid
L 05/19/2009 - 05:04:12: [SM] Displaying call stack trace for plugin "orgasm_mcgedit.smx":
L 05/19/2009 - 05:04:12: [SM] [0] Line 159, orgasm_mcgedit.sp::hook_Death()
L 05/19/2009 - 11:17:11: Error log file session closed.
L 05/19/2009 - 19:08:19: SourceMod error session started
L 05/19/2009 - 19:08:19: Info (map "cp_orange_x3_rd_7") (file "errors_20090519.log")
L 05/19/2009 - 19:08:19: [SM] Native "IsFakeClient" reported: Client index 0 is invalid
L 05/19/2009 - 19:08:19: [SM] Displaying call stack trace for plugin "orgasm_mcgedit.smx":
L 05/19/2009 - 19:08:19: [SM] [0] Line 159, orgasm_mcgedit.sp::hook_Death()
L 05/19/2009 - 21:08:44: [SM] Native "IsFakeClient" reported: Client index 0 is invalid
L 05/19/2009 - 21:08:44: [SM] Displaying call stack trace for plugin "orgasm_mcgedit.smx":
L 05/19/2009 - 21:08:44: [SM] [0] Line 159, orgasm_mcgedit.sp::hook_Death()
L 05/19/2009 - 230:15: [SM] Native "IsFakeClient" reported: Client index 0 is invalid
L 05/19/2009 - 230:15: [SM] Displaying call stack trace for plugin "orgasm_mcgedit.smx":
L 05/19/2009 - 230:15: [SM] [0] Line 159, orgasm_mcgedit.sp::hook_Death()