[D3XT3R]

Originally Posted by EFFx You have my permission for edit my furien to whatever you want. Gl

Here i go thanx so mutch D:

[kristi]

1. Originally Posted by EFFx Released the version v0.5.6:

   You forgot to change:
   
   PHP Code:

   #define PLUGIN                "Furien Mod v0.5.4" 

   
   
2. PHP Code:

       set_user_frags(id, 0)
    cs_set_user_deaths(id, 0)
    set_user_frags(id, 0)
    cs_set_user_deaths(id, 0) 

   Why're you doing that?
   
   
   
3. PHP Code:

       for(new i;i < iNum;i++)
    {
        id = iPlayers[i]
           ...
    
        if(isTeam(id))
        {
            cs_set_user_team(id, cs_get_user_team(id) == CS_TEAM_CT ? CS_TEAM_T : CS_TEAM_CT)
            set_pev(id,pev_takedamage,DAMAGE_NO)
        }
    } 

   That will kick all players on 32/32 or even less.
   Use sth like:
   
   this

   PHP Code:

   #define      TASK_SWITCH      73582
..
            if(isTeam(id))
            {
                BeginDelayedTeamChange(id)
                set_pev(id,pev_takedamage,DAMAGE_NO)
            }

public BeginDelayedTeamChange(id)
{
   
   switch(id)
   {
     
      case  1..6:  set_task(0.1, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)
      case  7..13:  set_task(0.2, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)
      case  14..20:  set_task(0.3, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)
      case  21..26:  set_task(0.4, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)
      case  27..32:  set_task(0.5, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)
   }
}
 
public ChangeUserTeamWithDelay(id)
{
   
   id  -=  TASK_SWITCH;
   if(!is_user_connected(id))  return 1
   
   switch(cs_get_user_team(id))
   {
      
      case  CS_TEAM_T:cs_set_user_team(id,  CS_TEAM_CT)
      case  CS_TEAM_CT:cs_set_user_team(id,  CS_TEAM_T)
         
   }
   
   return 0;
} 

   
   
   
   
4. PHP Code:

   if(!SpecialItemActivated[id][g_bActived_Hanged])
        {
            if(isWithAvaliableWeapons[id])
            {
                new Float:fVec[3], iSpeed
                entity_get_vector(id, EV_VEC_velocity, fVec)
                iSpeed = floatround(vector_length(fVec))
                        
                if(iSpeed < 255)
                {
                    set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, get_user_flags(id) & ADMIN_SVIP ? (iSpeed / 2) : iSpeed) 
                }
                else 
                {
                    set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)
                }
            } 
            else 
            {
                set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)
            }
        }
        else
        {
            if(isWithAvaliableWeapons[id])
            {
                set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, 0)
            }
            else
            {
                set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)
            }
        } 

   
   
   PHP Code:

   if(isWithAvaliableWeapons[id])
        {
            if(!SpecialItemActivated[id][g_bActived_Hanged])
            {
            
                new Float:fVec[3], iSpeed
                entity_get_vector(id, EV_VEC_velocity, fVec)
                iSpeed = floatround(vector_length(fVec))
                        
                if(iSpeed < 255)
                    set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, (iSpeed / 2)) 
                else 
                    set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)
                
            } 
            else
            {
                set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, 0)
            }
        }
        else
        {
            set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)
        } 

5. You use a lot
   
   PHP Code:

   if(a)
{    
    if(b)
    {
        // h
    }
} 

   instead of
   
   PHP Code:

   if(a && b)
{
    // h
} 

6. Compiling

   
   

   AMX Mod X Compiler 1.8.3-manual
   Copyright (c) 1997-2006 ITB CompuPhase
   Copyright (c) 2004-2013 AMX Mod X Team
   
   plugin.sma(20) : warning 201: redefinition of constant/macro (symbol "MAX_PLAYERS")
   plugin.sma(1166) : error 017: undefined symbol "color_chat"
   plugin.sma(2030) : error 017: undefined symbol "color_chat"
   plugin.sma(2630) : error 017: undefined symbol "color_chat"
   plugin.sma(2662) : error 017: undefined symbol "color_chat"
   plugin.sma(2703) : error 017: undefined symbol "color_chat"
   plugin.sma(2710) : error 017: undefined symbol "color_chat"
   plugin.sma(2726) : error 017: undefined symbol "color_chat"
   plugin.sma(2733) : error 017: undefined symbol "color_chat"
   plugin.sma(2825) : error 017: undefined symbol "color_chat"
   plugin.sma(3422) : error 017: undefined symbol "color_chat"
   plugin.sma(3423) : error 017: undefined symbol "color_chat"
   plugin.sma(3436) : error 017: undefined symbol "color_chat"
   plugin.sma(3459) : error 017: undefined symbol "color_chat"
   plugin.sma(3487) : error 017: undefined symbol "color_chat"
   plugin.sma(3654) : error 017: undefined symbol "color_chat"
   plugin.sma(3682) : error 017: undefined symbol "color_chat"
   plugin.sma(3714) : error 017: undefined symbol "color_chat"
   plugin.sma(3769) : error 017: undefined symbol "color_chat"
   plugin.sma(3942) : error 017: undefined symbol "color_chat"
   plugin.sma(4617) : error 017: undefined symbol "color_chat"
   plugin.sma(4714) : error 017: undefined symbol "color_chat"
   plugin.sma(4785) : error 017: undefined symbol "color_chat"
   plugin.sma(4801) : error 017: undefined symbol "color_chat"
   plugin.sma(5139) : error 017: undefined symbol "color_chat"
   plugin.sma(5516) : error 017: undefined symbol "color_chat"
   plugin.sma(5517) : error 017: undefined symbol "color_chat"
   
   Compilation aborted.
   26 Errors.

   
   

[edon1337]

Originally Posted by kristi You forgot to change: PHP Code: #define PLUGIN                "Furien Mod v0.5.4"  PHP Code:     set_user_frags(id, 0)     cs_set_user_deaths(id, 0)     set_user_frags(id, 0)     cs_set_user_deaths(id, 0)  Why're you doing that? PHP Code:     for(new i;i < iNum;i++)     {         id = iPlayers[i]            ...              if(isTeam(id))         {             cs_set_user_team(id, cs_get_user_team(id) == CS_TEAM_CT ? CS_TEAM_T : CS_TEAM_CT)             set_pev(id,pev_takedamage,DAMAGE_NO)         }     }  That will kick all players on 32/32 or even less. Use sth like: this PHP Code: #define      TASK_SWITCH      73582 ..             if(isTeam(id))             {                 BeginDelayedTeamChange(id)                 set_pev(id,pev_takedamage,DAMAGE_NO)             } public BeginDelayedTeamChange(id) {        switch(id)    {             case  1..6:  set_task(0.1, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)       case  7..13:  set_task(0.2, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)       case  14..20:  set_task(0.3, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)       case  21..26:  set_task(0.4, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)       case  27..32:  set_task(0.5, "ChangeUserTeamWithDelay",  id  + TASK_SWITCH)    } }   public ChangeUserTeamWithDelay(id) {        id  -=  TASK_SWITCH;    if(!is_user_connected(id))  return 1        switch(cs_get_user_team(id))    {              case  CS_TEAM_T:cs_set_user_team(id,  CS_TEAM_CT)       case  CS_TEAM_CT:cs_set_user_team(id,  CS_TEAM_T)              }        return 0; }  PHP Code: if(!SpecialItemActivated[id][g_bActived_Hanged])         {             if(isWithAvaliableWeapons[id])             {                 new Float:fVec[3], iSpeed                 entity_get_vector(id, EV_VEC_velocity, fVec)                 iSpeed = floatround(vector_length(fVec))                                          if(iSpeed < 255)                 {                     set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, get_user_flags(id) & ADMIN_SVIP ? (iSpeed / 2) : iSpeed)                  }                 else                  {                     set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)                 }             }              else              {                 set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)             }         }         else         {             if(isWithAvaliableWeapons[id])             {                 set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, 0)             }             else             {                 set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)             }         }  PHP Code: if(isWithAvaliableWeapons[id])         {             if(!SpecialItemActivated[id][g_bActived_Hanged])             {                              new Float:fVec[3], iSpeed                 entity_get_vector(id, EV_VEC_velocity, fVec)                 iSpeed = floatround(vector_length(fVec))                                          if(iSpeed < 255)                     set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, (iSpeed / 2))                  else                      set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)                              }              else             {                 set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderTransAlpha, 0)             }         }         else         {             set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 0)         }  You use a lot PHP Code: if(a) {         if(b)     {         // h     } }  instead of PHP Code: if(a && b) {     // h }  Compiling AMX Mod X Compiler 1.8.3-manual Copyright (c) 1997-2006 ITB CompuPhase Copyright (c) 2004-2013 AMX Mod X Team plugin.sma(20) : warning 201: redefinition of constant/macro (symbol "MAX_PLAYERS") plugin.sma(1166) : error 017: undefined symbol "color_chat" plugin.sma(2030) : error 017: undefined symbol "color_chat" plugin.sma(2630) : error 017: undefined symbol "color_chat" plugin.sma(2662) : error 017: undefined symbol "color_chat" plugin.sma(2703) : error 017: undefined symbol "color_chat" plugin.sma(2710) : error 017: undefined symbol "color_chat" plugin.sma(2726) : error 017: undefined symbol "color_chat" plugin.sma(2733) : error 017: undefined symbol "color_chat" plugin.sma(2825) : error 017: undefined symbol "color_chat" plugin.sma(3422) : error 017: undefined symbol "color_chat" plugin.sma(3423) : error 017: undefined symbol "color_chat" plugin.sma(3436) : error 017: undefined symbol "color_chat" plugin.sma(3459) : error 017: undefined symbol "color_chat" plugin.sma(3487) : error 017: undefined symbol "color_chat" plugin.sma(3654) : error 017: undefined symbol "color_chat" plugin.sma(3682) : error 017: undefined symbol "color_chat" plugin.sma(3714) : error 017: undefined symbol "color_chat" plugin.sma(3769) : error 017: undefined symbol "color_chat" plugin.sma(3942) : error 017: undefined symbol "color_chat" plugin.sma(4617) : error 017: undefined symbol "color_chat" plugin.sma(4714) : error 017: undefined symbol "color_chat" plugin.sma(4785) : error 017: undefined symbol "color_chat" plugin.sma(4801) : error 017: undefined symbol "color_chat" plugin.sma(5139) : error 017: undefined symbol "color_chat" plugin.sma(5516) : error 017: undefined symbol "color_chat" plugin.sma(5517) : error 017: undefined symbol "color_chat" Compilation aborted. 26 Errors.

1. It's just a technical mistake, why make it a big deal ?
3. That code you provided is horrible.
4. You're giving bad advice, it's better to use brackets.
5. It's his coding style, doesn't matter.

[kristi]

3. Yeah, but he should not change all the players' teams at the same time.
4. It's not about not using brackets. He's checking if(isWithAvaliableWeapons[id]) twice.

[HamletEagle]

About 3, kristi is right, you need some kind of delay for amxx < 183 when changing team(models) for many players.

[EFFx]

Even if it's bad or not, i'll consider all your suggestions. I have so much things to update on this plugin, I want make a global update instead of little per little things. Thank you for your corrections even if it's correct or no.

1. Edon said all.
2. I'll change that score reset format.
3. I'll change it too.
4. Yes
5. Edon said all.
6. I don't know what are you talking about, just I forgot the color_chat() stock? I'll check.

[design42magazine]

Truly this post is very nice and interesting. Thanks for sharing such a useful article.

[EFFx]

I appreciate you bruh

[DrWarpMan]

ㅤㅤ

[EFFx]

Just don't compile them. About the error with color_chat(), I must forgot something. I'll check.