[snelvuur]

I would like to see the player locations and the option in the menu, that would be great if possible.

[DarthNinja]

I'm unapproving this until the author fixes the potential SQL injection that is possible because the comment string is not escaped.

Anyone running the plugin should remove it.

[ecca]

Updated 1.3 fixed all problems and darthninjas requestes

[DarthNinja]

I'll approve this once these changes are made:

• Your bool on line 15 isn't needed, you can just check if(db == INVALID_HANDLE).
  This will also have the side effect of having the plugin fall back to file logging if the connection is dropped.
• Your if statement on line 51 should be trashed and the connection code moved to the if statement on line 35.
• Your cvar check on line 45 will always return true, because calling it in OnPluginStart doesn't give it an option to be changed.
  You should ether check it right before printing the message, or hook the cvar for changes and set a global bool to toggle the advert.
  Also you should be using GetConVarBool not Int.
• You should also escape szMapName, although that isn't nearly as dangerous as szComment.
• Your escaped string sizes should be larger then your un-escaped ones. You risk overflowing the string otherwise.
• Your insert string is also too small since it could be as large as 445 characters if all your other strings are filled (even before what I said about the escaped strings).

That's all I see at the moment.

[ecca]

Updated 1.4, fixed darthninjas stuff

[DarthNinja]

Originally Posted by ecca Updated 1.4, fixed darthninjas stuff

It looks like you forgot to upload the plugin file

By the way: You don't have to retain the old versions (and it's probably less confusing if you only have the latest posted).

[ecca]

Uploaded file, forgotted to press upload :O

[DarthNinja]

Version 1.4 looks fine; approved.

Some suggestions:

• You could check and log sql errors in your SQL_Insert callback. (If const String:error isn't empty, log it).
• Your GetConVarInt in RoundStart should really be a GetConVarBool.

[ecca]

Updated 1.5 fixed error logs on the insert query

also added det getconvarbool instead

[claudiuhks]

I think you should add a spam protection. A player should report a map once.