[busy.orange]

Using SQL_UnlockDatabase(g_hDatabase); without SQL_LockDatabase
can crash server?
What do you think about my code?

PHP Code:

public OnClientPostAdminCheck(client)
{
    if (IsFakeClient(client)) return;
    if (SQLConnect())//Try connect to DB
    {
             SQL_TQuery(g_hDatabase, T_IgnoreResults, "bla bla");
    }
}
public T_IgnoreResults(Handle:owner, Handle:hndl, const String:error[], any:data)
{
    if (hndl == INVALID_HANDLE)
    {
        LogError("Query failed! %s", error);
    } 
} 
bool:SQLConnect()
{
    // connect to the database if needed
    if (g_hDatabase == INVALID_HANDLE)
    {
        new Handle:KV = INVALID_HANDLE;            
        KV=CreateKeyValues("pishpish");
        KvSetString(KV,"driver","mysql");
        KvSetString(KV,"host","remotehost");
        KvSetString(KV,"database","DB");
        KvSetString(KV,"user","user");
        KvSetString(KV,"pass","pass");
        KvSetString(KV,"port","3306");
        decl String:error[255];
        g_hDatabase = SQL_ConnectCustom(KV,error,sizeof(error),true);
        if (g_hDatabase != INVALID_HANDLE)
        {
            SQL_UnlockDatabase(g_hDatabase);
            return true
        }
        LogMessage("Failed to connect to database, error: %s", error);
        return false;
    }
    else return true;
} 


[recon0]

Let's apply the logic test: Why would you call UnlockDatabase before LockDatabase? Secondly, database locking is only used when mixing threaded and non threaded DB operations.

[busy.orange]

SQL_ConnectCustom is only non threaded
is that source i only connect via non threaded. but use only threaded mysql

[BAILOPAN]

There is an open bug on this, bug 3554.

[busy.orange]

PHP Code:

new Handle:hDatabase = INVALID_HANDLE;
 
StartSQL()
{
    SQL_TConnect(GotDatabase);
}
 
public GotDatabase(Handle:owner, Handle:hndl, const String:error[], any:data)
{
    if (hndl == INVALID_HANDLE)
    {
        LogError("Database failure: %s", error);
    } else {
        hDatabase = hndl;
    }
}

CheckSteamID(userid, const String:auth[])
{
    decl String:query[255];
    Format(query, sizeof(query), "SELECT userid FROM users WHERE steamid = '%s'", auth);
    SQL_TQuery(hdatabase, T_CheckSteamID, query, userid)
}
 
public T_CheckSteamID(Handle:owner, Handle:hndl, const String:error[], any:data)
{
    new client;
 
    /* Make sure the client didn't disconnect while the thread was running */
    if ((client = GetClientOfUserId(data)) == 0)
    {
        return;
    }
 
    if (hndl == INVALID_HANDLE)
    {
        LogError("Query failed! %s", error);
        KickClient(client, "Authorization failed");
    } else if (!SQL_GetRowCount(hndl)) {
        KickClient(client, "You are not a member");
    }
} 


I whant CheckSteamID in OnClientPostAdminCheck.
but i have problem:
How proces new players, when have no DB connection?

[DJ Tsunami]

When you don't have a database connection, you can't process any players of course. So make a database connection before you process them (in OnPluginStart).

[busy.orange]

DJ Tsunami
DB can be autodisconneced if it idle? (10-30 minutes)

How proces new players, when have no DB connection?
i mean how to connect DB(if need) before query

[DJ Tsunami]

I've never seen the database auto-disconnect, you maintain the connection so you decide when it disconnects. Again you can't make a connection before the query, because the connection is threaded. You'll have to store the queries somewhere, connect, and then fire them afterwards (hoping they're not invalid anymore).