[lazarev]

Hi, I need you to move those functions to client_command.

PHP Code:

// =========== the commands are ============
register_clcmd( "__SETKILLS", "CMD_SETKILLS", ADMIN_LEVEL );
register_clcmd( "__SETHEADSHOTS", "CMD_SETHEADSHOTS", ADMIN_LEVEL );
register_clcmd( "__SETSURVIVES", "CMD_SETSURVIVES", ADMIN_LEVEL );
// ======================================

public CMD_SETKILLS( id, level, cid )
{
    if ( !cmd_access( id, level, cid, 2 ) )
        return PLUGIN_HANDLED;
        
    new szArg[ 33 ];
    read_argv( 1, szArg, 32 );
    
    if( !equal( szArg, "" ) )
    g_GlobalScore[ KILLS ] = str_to_num( szArg );
    ShowEventMenu( id );
    
    return PLUGIN_HANDLED;
}

public CMD_SETHEADSHOTS( id, level, cid )
{
    if ( !cmd_access( id, level, cid, 2 ) )
        return PLUGIN_HANDLED;
    
    new szArg[ 33 ];
    read_argv( 1, szArg, 32 );
    if( !equal( szArg, "" ) )
    g_GlobalScore[ HEADSHOTS ] = str_to_num( szArg );
    ShowEventMenu( id );
    
    return PLUGIN_HANDLED;
}

public CMD_SETSURVIVES( id, level, cid )
{
    if ( !cmd_access( id, level, cid, 2 ) )
        return PLUGIN_HANDLED;
        
    new szArg[ 33 ];
    read_argv( 1, szArg, 32 );
    
    if( !equal( szArg, "" ) )
    g_GlobalScore[ SURVIVES ] = str_to_num( szArg );
    ShowEventMenu( id );
    
    return PLUGIN_HANDLED;
} 


[Arkshine]

why ?

[joaquimandrade]

You want to avoid code duplication?

You have to find what is different and take it out of the code:

PHP Code:

set_stuff(id,level,cid,type)
{
    if ( !cmd_access( id, level, cid, 2 ) )
        return PLUGIN_HANDLED;
        
    new szArg[ 33 ];
    read_argv( 1, szArg, 32 );
    
    if( !equal( szArg, "" ) )
    g_GlobalScore[ type ] = str_to_num( szArg );
    ShowEventMenu( id );
    
    return PLUGIN_HANDLED;
}

public CMD_SETKILLS( id, level, cid )
{
    return set_stuff(id,level,cid,KILLS) 
} 


[Bugsy]

Read the command and do a switch based off of that?

__SETKILLS
__SETHEADSHOTS
__SETSURVIVE

PHP Code:

// code...

new iSet;
switch ( szCmd[ 5 ] )
{
     case 'K': iSet = KILLS;
     case 'H': iSet = HEADSHOTS;
     case 'S': iSet = SURVIVES;
}

g_GlobalScore[ iSet ] = str_to_num( szArg );

// code... 


[joaquimandrade]

[lazarev]

thanks, Bugsy & joaquimandrade. both works