[Fr33m@n]

This is what i call an optimized version.

If it was me i would find another hero name and use this version for hoping a chance of approval.

[Jelle]

I was never aiming for approval, just a new hero.

[Fr33m@n]

optimized again.

[slamx]

Originally Posted by Fr33m@n optimized again.

What did you optimize? I'm not sure what you mean.

[Fr33m@n]

the code. more efficient, use less ressources.

[G-Dog]

I would suggest moving the get_pcvar_num(gPcvarAmmoToAdd) outside the loop and caching to a variable to optimize further, something I should point out to both you and Jelle is that the purpose of using SH_MAXSLOTS in the coding is so server ops can open superheroconst.inc and change the const to the number of slots they have on their server to do a quick optimization of all their scripts, but your usage of it with your players array will throw an error if they do that because get_players requires an array of exactly 32 cells so instead of doing players[SH_MAXSLOTS] you should have players[32].

[Fr33m@n]

done.

I know it need a 32 cells arrays for loop but i never considered this kind of view for players loop.

I used players[SH_MAXSLOTS] as a reference in my heroes because it was the way used in base package heroes.

I'm agree, i will change it.

Edit : Bug Repport done.

[The Art of War]

Originally Posted by Jelle I was never aiming for approval, just a new hero.

Then post it in off topic so it wont get thrashed?

But this hero should get approved, atleast the idea. Punisher is too powerful for "soft" sh servers.

[Jelle]

Originally Posted by The Art of War Then post it in off topic so it wont get thrashed? But this hero should get approved, atleast the idea. Punisher is too powerful for "soft" sh servers.

You can also just set the cvar for punisher to drop current weapon and get a new one with full clip. Then it takes some time to drop current and get a new, so you wont be spraying all the time.

[The Art of War]

Originally Posted by Jelle You can also just set the cvar for punisher to drop current weapon and get a new one with full clip. Then it takes some time to drop current and get a new, so you wont be spraying all the time.

Hmm yes indeed, but I recall there's a line saying (not recommended) after that mode, and I prefer not to use things vittu are saying are not recommended, though of course it is possible.

Still, the idea is brilliant, and Fr33 really optimised the whole code, but I havent seen vittu around for a while but I hope at some point some version gets approved.