[Solved] Ham_Weapon_SecondaryAttack on elites, for example

baneado · **Author**

Is it possible to make Ham_Weapon_SecondaryAttack working for weapons that haven't zoom or silencer?

I just put this code and it doesn't display the print

PHP Code:


			
RegisterHam(Ham_Weapon_SecondaryAttack, "weapon_elite", "fw_Weapon_SecondaryAttack")



public fw_Weapon_SecondaryAttack(ent)

{

    client_print(0, print_chat, "Hey")

}

The other way is hook FM_CmdStart and check for IN_ATTACK2... but I prefer the previous code.

Some way to make it possible? Just a offset or something?

gabuch2 · *Last edited by gabuch2; 06-30-2017 at 10:18.*

https://github.com/s1lentq/ReGameDLL.../wpn_elite.cpp

Elites don't have a secondary attack registered. (as in, the method SecondaryAttack)

Your options are either use a custom version of ReGameDLL to add this method, or hook the button attack2 while the player is holding the elites.

Craxor · *Last edited by Craxor; 06-30-2017 at 11:29.*

1. Ham_Weapon_SecondaryAttack is called just for weapons who already have an secondary attack as GabbyIggy told you ( Zoom, USP-Silencer, Glock/Famasa/Galil Shoot burst style, etc. )

2. The good way of dealing with index is doing:

PHP Code:


			
new OwnerId = pev( ent, pev_owner);

3. You can also make a special command like "+myoption" and users can bind click-right(replacing +attack2) with your command like:

Code:

bind mouse2 "+myoption"

klippy · 06-30-2017 , 11:44 Re: Ham_Weapon_SecondaryAttack on elites, for example

Quote:

Originally Posted by Gabe Iggy

https://github.com/s1lentq/ReGameDLL.../wpn_elite.cpp

Elites don't have a secondary attack registered. (as in, the method SecondaryAttack)

That's not the issue. It's a virtual function and it's inherited from CBasePlayerWeapon, so all weapons do have the SecondaryAttack() method. The thing is that it's never called for weapons that aren't meant to have a secondary attack. Take a look here.

Quote:

hook the button attack2 while the player is holding the elites.

That seems like a valid option.

What would probably be the best thing to do is to hook bool CBasePlayerWeapon::HasSecondaryAttack() and to return true from it. You can hook it with Orpheu, Okapi or ReAPI.

**HamletEagle** · *Last edited by HamletEagle; 06-30-2017 at 15:59.*

Quote:

Originally Posted by KliPPy

What would probably be the best thing to do is to hook bool CBasePlayerWeapon::HasSecondaryAttack() and to return true from it. You can hook it with Orpheu, Okapi or ReAPI.

He could try to hook ItemPostFrame with hamsandwich and add IN_ATTACK2 to pev_button. Tho this could mess up things, I'm not sure if it's a good ideea.
But yeah, hooking HasSecondaryAttack and altering the return value is by far the best and safest way in case the function is not copied by the compiler where it's used. It's called only from ItemPostFrame, and from what I saw while working with similar functions, some times the compiler just copy/paste the function, so hooking it does nothing, because the original function is never called. If this is the case, then hooking ItemPostFrame and handling that function at a plugin level(redoing the code) would be the solution.

NiHiLaNTh · 06-30-2017 , 15:58 Re: Ham_Weapon_SecondaryAttack on elites, for example

Best way is hooking HasSecondaryAttack as Klippy said, but you also can do it the way how game actually does it too

Code:

public plugin_init()
{
      ....
      RegisterHam(Ham_Item_PostFrame, "weapon_elite", "OnItemPostFrame");
      ....
}

.......

public OnItemPostFrame(weapon)
{
     .... checks here

     static player;
     player = get_ent_data_entity(weapon, "CBasePlayerItem", "m_pPlayer");

     static buttons;
     buttons = pev(player, pev_button, buttons);

     if ((buttons & IN_ATTACK2) && (get_ent_data_float(weapon, "CBasePlayerWeapon", "m_flNextSecondaryAttack") <= 0.0))
     {
          //Your attack goes here
          // Or you can do this ExecuteHamB(Ham_Weapon_SecondaryAttack, weapon);
          set_pev(player, pev_button, buttons &= ~IN_ATTACK2);
     }
}