[gilmon]

Hello i'm writing a plugin for L4D2 anti player TK,everything can work but the log file always show errors like this:

PHP Code:

L 01/07/2014 - 14:06:52: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:52: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:52: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:06:53: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:53: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:53: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:06:53: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:53: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:53: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:06:54: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:54: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:54: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:06:54: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:54: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:54: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:06:54: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:54: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:54: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:06:59: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:06:59: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:06:59: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt()
L 01/07/2014 - 14:07:00: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
L 01/07/2014 - 14:07:00: [SM] Displaying call stack trace for plugin "l4d2_zantiTK.smx":
L 01/07/2014 - 14:07:00: [SM]   [0]  Line 32, l4d2_antiTK.sp::Player_Hurt() 


My sourcecode is here,any help?

PHP Code:

#include <sdktools>
#include <sourcemod>
#include <sdkhooks>
#pragma semicolon 1

#define CVAR_FLAGS FCVAR_PLUGIN|FCVAR_SPONLY|FCVAR_NOTIFY

#define IsValidClient(%1)        (1 <= %1 <= MaxClients && IsClientInGame(%1))

#define PLUGIN_VERSION "1.0"

public Plugin:myinfo = 
{
    name = "Anti TK",
    author = "xxx",
    description = "Regen and TK",
    version = PLUGIN_VERSION,
    url = "http://www.sourcemod.net/"
}

public OnPluginStart()
{
    HookEvent("player_hurt", Player_Hurt);
}

public Action:Player_Hurt(Handle:event, const String:name[], bool:dontBroadcast)
{
    new attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    new victim = GetEventInt(event, "userid");
    
    if(IsValidClient(victim))
    {
        if(GetClientTeam(attacker) == 2 && GetClientTeam(victim) == 2)
        {
            new dmg_health = GetEventInt(event, "dmg_health");     // get the amount of damage done
                new health = GetEntProp(attacker, Prop_Data, "m_iHealth") - dmg_health;
                SetEntProp(attacker, Prop_Data, "m_iHealth", health);
        }
    }
} 


Also there's a littile bug: when player health is 0,player won't incapacitate still stand there?

[Dr. Greg House]

What is "IsValidClient" doing/NOT doing?

Error's description is kind of, well, obvious.

[yokomo]

You should check valid attacker too:

PHP Code:

if(IsValidClient(attacker) && IsValidClient(victim))
{
    //attcker is player and victim is player too.
} 


[gilmon]

ok after remove it still like that(thanks)

also 0 health is a problem

[ReFlexPoison]

If you're using ...

PHP Code:

stock bool:IsValidClient(iClient)
{
    if(iClient <= 0 || iClient > MaxClients || !IsClientInGame(iClient))
        return false;
    return true;
} 


... you should check if the attacker is valid as-well.
That should fix your problem.
Note: Client index 0, is the world-spawn, not an actual player index.

Edit: 3 Posts in a minute...

[gilmon]

Originally Posted by yokomo You should check valid attacker too: PHP Code: if(IsValidClient(attacker) && IsValidClient(victim)) {     //attcker is player and victim is player too. }

Thanks,no more client 0 error now

Thanks everyone here,now the only problem is health 0,any fix?

I tried something like this but no luck(no error)

PHP Code:

new iDmgEntity = CreateEntityByName("point_hurt");
SetEntityHealth(attacker, 1);
DispatchKeyValue(attacker, "targetname", "bm_target");
DispatchKeyValue(iDmgEntity, "DamageTarget", "bm_target");
DispatchKeyValue(iDmgEntity, "Damage", "100");
DispatchKeyValue(iDmgEntity, "DamageType", "0");
DispatchSpawn(iDmgEntity);
AcceptEntityInput(iDmgEntity, "Hurt", attacker);
DispatchKeyValue(attacker, "targetname", "bm_targetoff");
RemoveEdict(iDmgEntity); 


[TnTSCS]

Take a look at SMLib's Entity_Hurt code.

PHP Code:

/**
 * Does damage to an entity.
 * This is a powerful function that allows you to specify
 * who the attacker is, the damage type and also what weapon
 * should be displayed in the hud kill message.
 * Note that for entities that fire another entity (RPG's, Crossbow's,
 * you have to pass the bullet's class, not the weapon's class !
 * It hasn't been tested how expensive this function is, as it
 * uses the entity point_hurt.
 * If you need a cheaper function use Entity_RemoveHealth().
 *
 * @param entity            Entity index.
 * @param damage            Amount of damage.
 * @param attacker        Entity Index of the attacker.
 * @param damageType        Use the DMG_ definations.
 * @param fakeClassName    Classname to fake, you can set this if you
 *                         want a specific weapon to be shown in the HUD kill message.
 * @return                 True on success, false otherwise.
 */
stock bool:Entity_Hurt(entity, damage, attacker=0, damageType=DMG_GENERIC, const String:fakeClassName[]="") 


[Root_]

SDKHooks_TakeDamage

[Mathias.]

I don't see why people check if the victim is valid, the event can't be called if there is no victim, it just logical.

[ReFlexPoison]

Originally Posted by Black-Rabbit I don't see why people check if the victim is valid, the event can't be called if there is no victim, it just logical.

Cuz valve

Cuz whynot

Cuz does it really matter?

You can just recompile the plugin to your liking if you are going to use it.