[King_OXO]

someone help me please i'm having several errors in scripting, I'm trying to create a rainbow dynamic light, but it has a lot of bugs and I can't fix them, I'm having a crash in the game and the dynamic light doesn't show.

Errors

(66) : error 017: undefined symbol "color"
(66) : error 001: expected token: ";", but found "]"
(66) : error 029: invalid expression, assumed zero
(66) : fatal error 190: too many error messages on one line

Scripting

PHP Code:

#pragma semicolon 1
#pragma newdecls required
#include <sourcemod>
#include <sdktools>
#include <sdkhooks>
#include <sdktools_functions>

#define ATTACH_GRENADE        "grenade"

int Ent;

public Plugin myinfo =
{
    name = "[L4D2]Rainbow Flashlight",
    author = "King",
    description = "",
    version = "3.0.0",
    url = "www.sourcemod.net"
};

public void OnPluginStart()
{
    RegConsoleCmd("sm_lightrain", Rainbow, "rainbow light for players");
}

void GetCvars()
{
    char sTemp[16];
}

public Action Rainbow(int client, int args)
{
    float vOrigin[3], vAngles[3];
    vOrigin = view_as<float>({ 0.5, -1.5, -7.5 });
    vAngles = view_as<float>({ -45.0, -45.0, 90.0 });
    
    Ent = MakeLightDynamic(vOrigin, vAngles, client);
}

public void OnPlayerThink(int client)
{
    if (!(0 < client <= MaxClients && IsClientInGame(client) && IsPlayerAlive(client)))
    {
        SDKUnhook(client, SDKHook_PreThink, OnPlayerThink);

        return;
    }

    int color[3];
    color[0] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 0) * 127.5 + 127.5);
    color[1] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 2) * 127.5 + 127.5);
    color[2] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 4) * 127.5 + 127.5);
}

int MakeLightDynamic(const float vOrigin[3], const float vAngles[3], int client)
{
    int Ent = CreateEntityByName("light_dynamic");
    if( Ent == -1)
    {
        LogError("Failed to create 'light_dynamic'");
        return 0;
    }

    SDKHook(client, SDKHook_PreThink, OnPlayerThink);
    char sTemp[16];
    Format(sTemp, sizeof(sTemp), "%d %d %d %d", color[0], color[1], color[2], color[3]);
    DispatchKeyValue(Ent, "_light", sTemp);
    DispatchKeyValue(Ent, "brightness", "3");
    DispatchKeyValueFloat(Ent, "spotlight_radius", 32.0);
    DispatchKeyValueFloat(Ent, "distance", 255.0);
    DispatchKeyValue(Ent, "style", "0");
    DispatchSpawn(Ent);
    AcceptEntInput(Ent, "TurnOn");

    // Attach to survivor
    SetVariantString("!activator");
    AcceptEntInput(Ent, "SetParent", client);

    if( GetClientTeam(client) == 2 && GetClientTeam(client) == 3 )
    {
        SetVariantString(ATTACH_GRENADE);
        AcceptEntInput(Ent, "SetParentAttachment");
    }

    TeleportEnt(Ent, vOrigin, vAngles, NULL_VECTOR);
    return Ent;
} 


[Marttt]

Well, try like this.
But you should go for a timer instead of prethink in the final version.
Also the color may be per client and not global (e.g. iColor[MAXPLAYERS+1][3])
Btw the color from prethink doesn't have the alpha (4th parameter in the light parameter), I fixed it at 255

Spoiler

PHP Code:

#pragma semicolon 1
#pragma newdecls required
#include <sourcemod>
#include <sdktools>
#include <sdkhooks>
#include <sdktools_functions>

#define ATTACH_GRENADE        "grenade"

int Ent;
int iColor[3];

public Plugin myinfo =
{
    name = "[L4D2]Rainbow Flashlight",
    author = "King",
    description = "",
    version = "3.0.0",
    url = "www.sourcemod.net"
};

public void OnPluginStart()
{
    RegConsoleCmd("sm_lightrain", Rainbow, "rainbow light for players");
}

void GetCvars()
{
    char sTemp[16];
}

public Action Rainbow(int client, int args)
{
    float vOrigin[3], vAngles[3];
    vOrigin = view_as<float>({ 0.5, -1.5, -7.5 });
    vAngles = view_as<float>({ -45.0, -45.0, 90.0 });
    
    Ent = MakeLightDynamic(vOrigin, vAngles, client);
}

public void OnPlayerThink(int client)
{
    if (!(0 < client <= MaxClients && IsClientInGame(client) && IsPlayerAlive(client)))
    {
        SDKUnhook(client, SDKHook_PreThink, OnPlayerThink);

        return;
    }

    
    iColor[0] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 0) * 127.5 + 127.5);
    iColor[1] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 2) * 127.5 + 127.5);
    iColor[2] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 4) * 127.5 + 127.5);
}

int MakeLightDynamic(const float vOrigin[3], const float vAngles[3], int client)
{
    int Ent = CreateEntityByName("light_dynamic");
    if( Ent == -1)
    {
        LogError("Failed to create 'light_dynamic'");
        return 0;
    }

    SDKHook(client, SDKHook_PreThink, OnPlayerThink);
    char sTemp[16];
    Format(sTemp, sizeof(sTemp), "%d %d %d %d", iColor[0], iColor[1], iColor[2], 255);
    DispatchKeyValue(Ent, "_light", sTemp);
    DispatchKeyValue(Ent, "brightness", "3");
    DispatchKeyValueFloat(Ent, "spotlight_radius", 32.0);
    DispatchKeyValueFloat(Ent, "distance", 255.0);
    DispatchKeyValue(Ent, "style", "0");
    DispatchSpawn(Ent);
    AcceptEntityInput(Ent, "TurnOn");

    // Attach to survivor
    SetVariantString("!activator");
    AcceptEntityInput(Ent, "SetParent", client);

    if( GetClientTeam(client) == 2 && GetClientTeam(client) == 3 )
    {
        SetVariantString(ATTACH_GRENADE);
        AcceptEntityInput(Ent, "SetParentAttachment");
    }

    TeleportEntity(Ent, vOrigin, vAngles, NULL_VECTOR);
    return Ent;
} 


[King_OXO]

Originally Posted by Marttt Well, try like this. But you should go for a timer instead of prethink in the final version. Also the color may be per client and not global (e.g. iColor[MAXPLAYERS+1][3]) Btw the color from prethink doesn't have the alpha (4th parameter in the light parameter), I fixed it at 255 Spoiler PHP Code: #pragma semicolon 1 #pragma newdecls required #include <sourcemod> #include <sdktools> #include <sdkhooks> #include <sdktools_functions> #define ATTACH_GRENADE        "grenade" int Ent; int iColor[3]; public Plugin myinfo = {     name = "[L4D2]Rainbow Flashlight",     author = "King",     description = "",     version = "3.0.0",     url = "www.sourcemod.net" }; public void OnPluginStart() {     RegConsoleCmd("sm_lightrain", Rainbow, "rainbow light for players"); } void GetCvars() {     char sTemp[16]; } public Action Rainbow(int client, int args) {     float vOrigin[3], vAngles[3];     vOrigin = view_as<float>({ 0.5, -1.5, -7.5 });     vAngles = view_as<float>({ -45.0, -45.0, 90.0 });          Ent = MakeLightDynamic(vOrigin, vAngles, client); } public void OnPlayerThink(int client) {     if (!(0 < client <= MaxClients && IsClientInGame(client) && IsPlayerAlive(client)))     {         SDKUnhook(client, SDKHook_PreThink, OnPlayerThink);         return;     }          iColor[0] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 0) * 127.5 + 127.5);     iColor[1] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 2) * 127.5 + 127.5);     iColor[2] = RoundToNearest(Cosine((GetGameTime() * 2.0) + client + 4) * 127.5 + 127.5); } int MakeLightDynamic(const float vOrigin[3], const float vAngles[3], int client) {     int Ent = CreateEntityByName("light_dynamic");     if( Ent == -1)     {         LogError("Failed to create 'light_dynamic'");         return 0;     }     SDKHook(client, SDKHook_PreThink, OnPlayerThink);     char sTemp[16];     Format(sTemp, sizeof(sTemp), "%d %d %d %d", iColor[0], iColor[1], iColor[2], 255);     DispatchKeyValue(Ent, "_light", sTemp);     DispatchKeyValue(Ent, "brightness", "3");     DispatchKeyValueFloat(Ent, "spotlight_radius", 32.0);     DispatchKeyValueFloat(Ent, "distance", 255.0);     DispatchKeyValue(Ent, "style", "0");     DispatchSpawn(Ent);     AcceptEntityInput(Ent, "TurnOn");     // Attach to survivor     SetVariantString("!activator");     AcceptEntityInput(Ent, "SetParent", client);     if( GetClientTeam(client) == 2 && GetClientTeam(client) == 3 )     {         SetVariantString(ATTACH_GRENADE);         AcceptEntityInput(Ent, "SetParentAttachment");     }     TeleportEntity(Ent, vOrigin, vAngles, NULL_VECTOR);     return Ent; }

Thank you, Marttt

[braslevall]

haven't setup the type variable of i simply add this to your for loop instead of what you have for










192.168.100.1 192.168.1.1