Xalus did not say "do not use pcvars", he said fXPos, fYPos, fHoldTime variables do not have to be global since they are used in only one function.
You should do:
PHP Code:
//In PostTakeDamage: new fXPos = get_pcvar_float(pXPosition); new fYPos = get_pcvar_float(pYPosition); new fHoldTime = get_pcvar_float(pHoldTime);
Quote:
Half-Life, Gearbox, CS 1.6. Your code. Anytime get_user_team is introduced without the cstrike_running() other mods are no longer compatible. Take 'get_user_team' out, they work. Put it back with cstrike_running() it bridges the gap. It then works on more than 1 mod.
This doesn't make any sense. get_user_teamIS NOT CS specific. cs_get_user_team is. By adding cstrike_running the only thing you did is prevent the code from running in any other mod because the point of the native is to check if cstrike is running. If it isn't, then the if check will fail and no code will be executed.
Reads as: if user is connected, plugin is on, MOD IS CSTRIKE, and victim and attacker are on different teams do something. If mod is not cstrike the entire if fails and nothing is executed and the plugin is as good as disabled.
@OP, remove that check.
Quote:
He can use static variable to hold the value which will more optimized but the cvar change won't be set immediately. Need to change the map.
No, it won't be any more optimized.
Quote:
cvars are there to be changed immediatly, i won't be changing my code which will lead the plugin to require a map change in order for the cvars to change, even though that would optimize my code.
You are right about one thing: cvars are there to be changed immediately. Plus you are not losing any performance by not caching the cvars so there's literally 0 point in doing so in this case(and in most if not all cases).
P.S: having 2 versions for a small change seems overkill. Add a cvar and have only one version.
Thanks for the suggestions HamletEagle, Everything is ready to get updated, only for one thing where i'm having trouble with. Which is the cvar for snipers.
This is the check i currently have but it doesn't work, can i get some on help this one?
Napoleon_be, why don't you make it easier? I think, there's no need to make 2 especial SMAs, 'cause it just make cvar to select a group of weapons for which the hitmarker is available.
Napoleon_be, why don't you make it easier? I think, there's no need to make 2 especial SMAs, 'cause it just make cvar to select a group of weapons for which the hitmarker is available.
That's what i'm trying to do in the check i posted above, but with no succes.
Thanks for the suggestions HamletEagle, Everything is ready to get updated, only for one thing where i'm having trouble with. Which is the cvar for snipers.
This is the check i currently have but it doesn't work, can i get some on help this one?
Huh... this is next-level stuff right here. Now seriously, don't duplicate if checks like that: it is not needed and makes your code ugly and hard to read.
Also, don't be afraid to split your checks in multiple if statements.
Your code didn't work because inside an if check that looks like if(A || B) A is firstly checked. If A is false, B is checked. If A is true, B is not checked.
So it firstly checks
and the if check passes without ever checking for pSnipersOnly cvar(and whenever A fails B will fail too because both A and B share the above check)
PHP Code:
//we are doing the main checks first - the part that you duplicated. We need them to be true to proceed no matter the value of pSnipersOnly if(is_user_connected(iAttacker) && get_pcvar_num(pPlugin) && get_user_team(iVictim) != get_user_team(iAttacker)) { //controls whether we will show a hit marker or not new bool:showHitMarker;
if(get_pcvar_num(pSnipersOnly)) //snipers only { if(gWeaponList & (1 << get_user_weapon(iAttacker))) //we are holding a sniper { showHitMarker = true; //show hit marker } } else { showHitMarker = true; //no restrictions on current weapon, show hit marker }
if(showHitMarker) { //hit marker logic } }
You could write it as an one-liner but as I said before, it's horrible:
I was able to remove a lot of redundant code. I started doing comments line-by-line to help you learn but it was getting messy. Compare this to your current code to see what I did. I didn't implement all of what others have suggested. Not tested.
Spoiler
Code:
#include <amxmodx>
#include <amxmisc>
#include <hamsandwich>
#define PLUGIN "COD: Hitmarkers"
#define VERSION "1.2"
#define AUTHOR "NapoleoN#"
#define iRainbow random_num(10, 255)
new g_pPlugin;
new g_pRainbow;
new g_pRandomHitmarkers;
new g_pColorRed , g_pColorGreen , g_pColorBlue , g_pXPosition , g_pYPosition , g_pHoldTime;
new const g_szSymbols[][] =
{
"-",
"\",
"|",
"/",
"*",
"+",
"x"
};
public plugin_init()
{
register_plugin(PLUGIN, VERSION, AUTHOR);
RegisterHam(Ham_TakeDamage, "player", "PostTakeDamage", 1);
g_pPlugin = register_cvar("amx_hitmarkers", "1"); // Enables/disables plugin
g_pRainbow = register_cvar("amx_hmrainbow", "1"); // Enables/disables random colors on every hit.
g_pRandomHitmarkers = register_cvar("amx_hmrandom", "1"); //Enables/disables random hit markers.
g_pColorRed = register_cvar("amx_hmrcolor", "165"); // RGB - Red (This won't work when amx_hmrainbow = 1)
g_pColorGreen = register_cvar("amx_hmgcolor", "165"); // RGB - Green (This won't work when amx_hmrainbow = 1)
g_pColorBlue = register_cvar("amx_hmbcolor", "165"); // RGB - Blue (This won't work when amx_hmrainbow = 1)
g_pXPosition = register_cvar("amx_hmxpos", "-1.0"); // x pos
g_pYPosition = register_cvar("amx_hmypos", "-1.0"); // y pos
g_pHoldTime = register_cvar("amx_hmholdtime", "0.5"); // hud hold time
}
public PostTakeDamage(iVictim, iInflictor, iAttacker, Float:iDamage, iDamagebits)
{
new iRed , iGreen , iBlue;
if ( get_pcvar_num( g_pPlugin ) && is_user_connected( iAttacker ) && ( get_user_team( iVictim ) != get_user_team( iAttacker ) ) )
{
if ( get_pcvar_num( g_pRainbow ) )
{
iRed = iRainbow;
iGreen = iRainbow;
iBlue = iRainbow;
}
else
{
iRed = get_pcvar_num(g_pColorRed);
iGreen = get_pcvar_num(g_pColorGreen);
iBlue = get_pcvar_num(g_pColorBlue);
}
set_hudmessage(iRed, iGreen, iBlue, get_pcvar_float(g_pXPosition), get_pcvar_float(g_pYPosition) , 0, 2.0, get_pcvar_float(g_pHoldTime) , 0.0, 0.0, -1);
show_hudmessage(iAttacker, "%s" , get_pcvar_num(g_pRandomHitmarkers) ? g_szSymbols[ random( sizeof( g_szSymbols ) ) ] : "x" );
}
}
Linear Mode
