[EFFx]

I'm trying to learn a little bit SourceMod, thats my first job on this language.
I"m trying to show the player that has the most kills of the round. But I got a little problem with SortCustom1D

SourcePawn Compiler 1.7.1
Copyright (c) 1997-2006 ITB CompuPhase
Copyright (c) 2004-2014 AlliedModders LLC

/groups/sourcemod/upload_tmp/textCB4RVp.sp(86) : warning 213: tag mismatch
/groups/sourcemod/upload_tmp/textCB4RVp.sp(86) : error 178: cannot coerce char[] to int[]; storage classes differ

1 Error.

Code:

PHP Code:

#include <sourcemod>

public Plugin:myinfo = 
{
    name = "My first official plugin",
    author = "EFFx",
    description = "Not know yet",
    version = "1.0",
    url = "www.nourl.com"
}

int MaxPlayers

char PlayerKills[MAXPLAYERS+1]
char PlayerDmg[MAXPLAYERS+1]

public OnPluginStart()
{
    HookEvent("player_death", smPlayerDeath)
    HookEvent("player_spawn", smPlayerSpawn)
    HookEvent("player_hurt", smPlayerDmg)
    HookEvent("round_end", smRoundEnd, EventHookMode_Post)
    
    MaxPlayers = GetMaxClients()
}

public Action:smPlayerSpawn(Event:event, const char[] name, bool:dontBroadCast)
{
    int id_spawner = GetEventInt(event, "userid")
    int client = GetClientOfUserId(id_spawner)
    
    PlayerKills[client] = 0
}

public Action:smPlayerDmg(Event:event, const char[] name, bool:dontBroadCast)
{
    int id_attacker = event.GetInt("attacker")
    int id_victim = event.GetInt("userid")

    int iAttacker = GetClientOfUserId(id_attacker)
    int iVictim = GetClientOfUserId(id_victim)
    
    int health_damage = event.GetInt("dmg_health")

    if(IsClientValid(iAttacker) && IsClientValid(iVictim))
    {
        PlayerDmg[iAttacker] += health_damage
    }
}
public Action:smPlayerDeath(Event:event, const char[] name, bool:dontBroadCast)
{
    int id_attacker = event.GetInt("attacker")
    int id_victim = event.GetInt("userid")
    
    int iAttacker = GetClientOfUserId(id_attacker)
    int iVictim = GetClientOfUserId(id_victim)
    
    if(iVictim != iAttacker && GetClientTeam(iAttacker) != GetClientTeam(iVictim))
    {
        PlayerKills[iAttacker]++
    }
}
public Action:smRoundEnd(Event:event, const char[] name, bool:dontBroadCast)
{
    int BestPlayer = GetTopPlayer()
    
    char BestPlayerName[32]
    GetClientName(BestPlayer, BestPlayerName, sizeof(BestPlayerName))
    
    PrintToChatAll("\x04[BestPlayer] \x01The best player of the round is \x06%s\x01 with\x06 %d\x01 kill%s (\x04 %d dmg\01 )", BestPlayerName, PlayerKills[BestPlayer], (PlayerKills[BestPlayer] >= 2) ? "s" : "", PlayerDmg[BestPlayer])
}

GetTopPlayer()
{
    char players[MAXPLAYERS]
    int PlayersNum
    int i
    for(i = 1;i <= MaxPlayers;i++)
    {
        if(IsClientInGame(i))
        {
            players[PlayersNum] = i
            PlayersNum++
        }
    }
    SortCustom1D(players, PlayersNum, smTakeBestPlayer)
    return players[0]
}

public smTakeBestPlayer(int client1, int client2)
{
    if(PlayerKills[client1] > PlayerKills[client2])
        return -1
    
    else if(PlayerKills[client1] < PlayerKills[client2])
        return 1
        
    return 0
}

stock bool IsClientValid(int client)
{
    if (client >= 1 && client <= MaxClients && IsClientConnected(client) && IsClientInGame(client) && !IsFakeClient(client))
        return true

    return false
} 


[fakuivan]

    char players[MAXPLAYERS]

why char tho?

[Mitchell]

the lack of semicolons are disturbing me.

[sdz]

Originally Posted by EFFx I'm trying to learn a little bit SourceMod, thats my first job on this language. I"m trying to show the player that has the most kills of the round. But I got a little problem with SortCustom1D

use int not char. char is just 1 character ("letter") such as: a, #, 9 h, v, $, 1. Almost any one key on the keyboard. Though formerly known as String, albeit String in sourcepawn is just a char array.
also players are viewed upon as integers, so you'd want int players[MAXPLAYERS + 1]; or some other index deal

also please #pragma semicolon 1;

[Addicted.]

Originally Posted by EasSidezz use int not char. char is just 1 character ("letter") such as: a, #, 9 h, v, $, 1. Almost any one key on the keyboard. Though formerly known as String, albeit String in sourcepawn is just a char array. also players are viewed upon as integers, so you'd want int players[MAXPLAYERS + 1]; or some other index deal also please #pragma semicolon 1;

char is used to declare a string in the new syntax

[Kolapsicle]

Originally Posted by oaaron99 char is used to declare a string in the new syntax

A char declares a char, Sourcemod doesn't support real strings. In Sourcemod it used to be that String declared what was really a char.

[headline]

Originally Posted by Kolapsicle A char declares a char, Sourcemod doesn't support real strings. In Sourcemod it used to be that String declared what was really a char.

Originally Posted by oaaron99 char is used to declare a string in the new syntax

Yes. It's very important to underline that

PHP Code:

char playername[MAX_NAME_LENGTH]; 


is not a string, but rather a simple array of characters.

[good_live]

Originally Posted by Headline not a string, but rather a simple array of characters.

What's your definition of a String? In my eyes a char array is a String.

[headline]

Originally Posted by good_live What's your definition of a String? In my eyes a char array is a String.

A string generally is a data structure. I believe most languages a string type uses a char array but handles that array for you.

[EFFx]

Why should I use semicolon? Do it something special?

And I did not see any help about my code, just replies about what's a string or an interger.

Ok, I'm using int instead of char, my mistake. In amxx it's an interger as well.

Should PlayerKills and PlayerDmg be int instead of char?