[Natsheh]

PHP Code:

stock is_str_number(const str[])
{
    new szValue[20];
    copy(szValue, charsmax(szValue), str);
    trim(szValue);
    
    if(szValue[ 0 ] == '-') szValue[0] = '0';
    return is_str_num(szValue);
} 


Use this stock instead.

[georgik57]

Originally Posted by Napoleon_be why does everyone still hardcore their arrays when charsmax' there to make it easy for you?

Mine is old code. Doesn't really matter anyway pretty much.

[Bugsy]

Originally Posted by Natsheh PHP Code: stock is_str_number(const str[]) {     new szValue[20];     copy(szValue, charsmax(szValue), str);     trim(szValue);     new X = contain(str, "-");     if(X > -1) szValue[X] = 0;     return is_str_num(szValue); }  Use this stock instead.

This is null-terminating the string on the first character if it's a negative number (0 == EOS).

PHP Code:

if(X > -1) szValue[X] = 0; 


Change this line to:

PHP Code:

if(X > -1) szValue[X] = '0'; 


Not even sure if contain() is needed, why not just do this? The expectation is someone is passing a string holding a number. A trim() is being executed so the minus sign would only be at the left-most position.

PHP Code:

if ( szValue[ 0 ] == '-' ) 
    szValue[ 0 ] = '0'; 


[Natsheh]

Originally Posted by Bugsy This is null-terminating the string on the first character if it's a negative number (0 == EOS). PHP Code: if(X > -1) szValue[X] = 0;  Change this line to: PHP Code: if(X > -1) szValue[X] = '0';  Not even sure if contain() is needed, why not just do this? The expectation is someone is passing a string holding a number. A trim() is being executed so the minus sign would only be at the left-most position. PHP Code: if ( szValue[ 0 ] == '-' )      szValue[ 0 ] = '0';

Thanks bugs for some reason I had more possibilities in mind, code optimized.

[fysiks]

Originally Posted by OnePL eg. -1, -2, -545335 or 0

is_str_num("0") returns true properly. For negative numbers, it looks like this is a bug that should be reported here.

[Bugsy]

Originally Posted by fysiks is_str_num("0") returns true properly. For negative numbers, it looks like this is a bug that should be reported here.

This is a stock in string_stocks and the description states it returns true if the string contains only digits, so it's 'technically' working as described. An entirely new stock would be needed to maintain reverse compatibility, or an optional 'NegativeSupport' boolean defaulted to false should be added. This should have been written to consider negative numbers.

PHP Code:

/**
 * Returns whether a given string contains only digits.
 * This returns false for zero-length strings.
 *
 * @param sString       Character to test.
 * @return              True if string contains only digit, otherwise false.
 */
stock bool:is_str_num(const sString[])
{
    new i = 0;

    while (sString[i] && isdigit(sString[i]))
    {
        ++i;
    }

    return sString[i] == 0 && i != 0;
} 


PHP Code:

stock bool:is_str_num(const sString[] , bool:bNegativeSupport=false)
{
    new i = 0 , szTempStr[ 13 ];
    
    copy( szTempStr , charsmax( szTempStr ) , sString );
    
    if ( bNegativeSupport && ( szTempStr[ 0 ] == '-' ) )
    {
        szTempStr[ i++ ] = '0';
    }
    
    while ( szTempStr[i] && isdigit(szTempStr[i] ) ) 
    {
        ++i;
    }

    return szTempStr[i] == 0 && i != 0;
} 


[fysiks]

Ah, I see. I guess thinking that the function names are logical doesn't always work .