[Lodar]

Hi. i have problem with save data on change map.

This is not work:

public void OnMapEnd()
{
	for (int i = 1; i <= MaxClients; i++)
	{
		if(IsValidClient(i)) SaveData(i);
	}
}
stock bool IsValidClient(int client)
{		
    if (!(1 <= client <= MaxClients) || !IsClientInGame(client) || IsFakeClient(client) || IsClientSourceTV(client) || IsClientReplay(client))
    {
        return false;
    }
    return true;
}

This work fine, so save function is good:

public Action Event_Disconnect(Handle event, const char[] name, bool dontBroadcast)
{
	int client = GetClientOfUserId(GetEventInt(event, "userid"));
	SaveData(client);
}

IsValidClient just copy from https://forums.alliedmods.net/showthread.php?p=2530794

What i must do? I need to save data all client to database on end map.
Now i use on round end event, but this make high server loads.
To save i use mysql on external sever (not localhost).

[8guawong]

use OnClientDisconnect since player disconnects when map ends as well

[eyal282]

Consider saving only when the data changes, and just never save on disconnect.

[XiLuo]

eyal282 is right ,disconnect is not best idea

[Lodar]

Originally Posted by eyal282 Consider saving only when the data changes, and just never save on disconnect.

The plugin works so that for each kill you get a gift that you can open.
So data change very often (each kill and each gift open).

[CliptonHeist]

Originally Posted by Lodar The plugin works so that for each kill you get a gift that you can open. So data change very often (each kill and each gift open).

That's perfectly fine as long as the plugin is using threaded queries, a roleplay plugin I helped develop performs multiple queries every time a player is killed (updating deathmatch table, updating money/drugs lost and inserting a log about the event) which has no impact on the server whatsoever.

[Lodar]

I never use threaded queries But i read about it and looks fine. But as i say, never use this before so please help me with that
How use it?
So far i use this (fragment of code):

DB = SQL_Connect("prezent", true, Error, sizeof(Error));
	if(DB == INVALID_HANDLE)
	{
		PrintToServer("MySQL: %s", Error);
		CloseHandle(DB);
	}
	else
	{
		PrintToServer("Connected to MySQL");
	}

Format(query, 500, "SELECT prezenty FROM PrezentyDB WHERE steamid = '%s'", steamid); 
DBResultSet querys = SQL_Query(DB, query);
if (SQL_FetchRow(querys))
{	

}

Format(query, 500, "UPDATE PrezentyDB SET prezenty = prezenty - 1 WHERE steamid = '%s'", steamid); 
SQL_Query(DB, query);

[eyal282]

Originally Posted by Lodar I never use threaded queries But i read about it and looks fine. But as i say, never use this before so please help me with that How use it? So far i use this (fragment of code): DB = SQL_Connect("prezent", true, Error, sizeof(Error)); if(DB == INVALID_HANDLE) { PrintToServer("MySQL: %s", Error); CloseHandle(DB); } else { PrintToServer("Connected to MySQL"); } Format(query, 500, "SELECT prezenty FROM PrezentyDB WHERE steamid = '%s'", steamid); DBResultSet querys = SQL_Query(DB, query); if (SQL_FetchRow(querys)) { } Format(query, 500, "UPDATE PrezentyDB SET prezenty = prezenty - 1 WHERE steamid = '%s'", steamid); SQL_Query(DB, query);

https://wiki.alliedmods.net/SQL_(SourceMod_Scripting)

Found this on google.