[tonykaram1993]

Originally Posted by hornet Okay, at the moment this is the brief / quick review ( mainly let's start with how to not blow up your CPU ): All CPU consuming forwards such as AddToFullPack, PreThink, and CmdStart should be registered only when they are in use, and unregistered when they are not. FM_Touch is a big nono . Use hamsandwich to detect touch and then like above, disable the forward when its not in use. Disable all other Touch forwards when they are not in use. You only use SetModel forward for Last Request purposes, so you should only have it registered during that time. Filter your CurWeapon event to only be triggered on knife deploy or hook Deploy with hamsandwich. To catch players text in chat you should instead register SayText message, but only when it your going to use it and then unregister it. To get the friendly fire effect in FFA, you only need to change player private data in TraceAttack, not TakeDamage aswell. You also should not need to do that in Killed forward either. You should use a multilingual file since JailBreak is popular world wide. When setting render FX on a player or other entity you should 100% be using engine module to do so instead of fakemeta. You have a stock called PlaySound() but you still use client_cmd() elsewhere. You have a macro for is_user() but you still use its defined code elsewere. You include xs but you have made your own macros for some of its functionality. You don't need to check is_user() in SetClientListening forward since you are also checking for player connected. All of your player and entity private data offsets should be defined for easy reading . example 116 instead define m_fHasPrimary. Do not hardcode string lengths or other array lengths for that matter. I don't think hardcoded models, sounds or other resources should be a problem since they are part of the mod, so long as they can be changed globally. It would be customizable of course to use a config file or something, but not required. So for now, that's just the main ones I've noticed. Further down the track we'll explore all of your other functions and systems etc. And lastly I very highly recommend you make this compatible with 1.8.2 compiler.

Will do so.

For /open to work, you have to go to the cell doors button and look at it. Then type amx_set_button.

[GuskiS]

I think you should make each functionality to seperate file because it will be easier to disable, test and work for yourself. That would also force you to make an API and that will also make it possible to add custom plugins, like that blackjack, without HARDLY editing it or including it in main plugin.

[GhostMan]

Looks nice.

[happy_2012]

Originally Posted by GuskiS I think you should make each functionality to seperate file because it will be easier to disable, test and work for yourself. That would also force you to make an API and that will also make it possible to add custom plugins, like that blackjack, without HARDLY editing it or including it in main plugin.

An API module JB mod is highly recommended, I would agree with you

[Fuck For Fun]

looks good ^^.
um I have an idea for you

Add to battle LR
Bazookas with a model (click on button you will zoom intention then you will be able the fire(rocket) bazooka) to player

change the HE Grenade to Fire on floor.

[hgavdv]

there is problem if we were 3

and if i do amx_cvar sv_restart 1 or Round 2 starts

one of us will get auto-Transfer to CT ( Even if he got banned from CT or He Didn't Pass the CT time )

because 3:T 0:CT

and i am using UltimatePlugin if i do amx_revive T's get Glock

and Ball mode any CT can abuse it

EDIT : auto-transfer Fixed by mp_autoteambalance 0

[tonykaram1993]

Originally Posted by hgavdv there is problem if we were 3 and if i do amx_cvar sv_restart 1 or Round 2 starts one of us will get auto-Transfer to CT ( Even if he got banned from CT or He Didn't Pass the CT time ) because 3:T 0:CT and i am using UltimatePlugin if i do amx_revive T's get Glock and Ball mode any CT can abuse it EDIT : auto-transfer Fixed by mp_autoteambalance 0

In UltimatePlugin, you can disable giving weapons when reviving.
The ball is supposed to be used by everyone not only Prisoners.

Couldn't upload the code to github yet. Tomorrow for sure I will do so.

[hgavdv]

Originally Posted by tonykaram1993 In UltimatePlugin, you can disable giving weapons when reviving. The ball is supposed to be used by everyone not only Prisoners. Couldn't upload the code to github yet. Tomorrow for sure I will do so.

Can you give me command to disable Glock

and The ball i want make access Flag because everyone can abuse it

[tonykaram1993]

Code has been uploaded to GitHub, check it here.

All updates will be there as a form of commits. I will probably not post here everytime I make an update. I will not update the code here on this forums until I feel it's ready.

[happy_2012]

What is so new in UltimateJailBreak_New?