[didoWEE]

Pro Become V.I.P.
by didoWEE

*Supported again after 2 years*
Version: re1.0.4 (nvault only)

[Description]
When someone reaches certain number of kills he becomes V.I.P.
Kills are saved in nVault file by Name, IP address or SteamID (default: SteamID)
The goal of this plugin is to make the players more regular by rewarding them with V.I.P. privileges.

[Settings]
* Defines

PHP Code:

#define SAVE_TYPE  3         // Save type (1 - Name / 2 - IP address / 3 - SteamID)
#define MSG_TAG   "FREE VIP"      // Chat Tag (prefix) 


* Cvars

PHP Code:

amx_vip_kills 1500      // Required kills for every player to become V.I.P.
amx_vip_flags "abc"      // Admin flags granted when someone becomes V.I.P. 


*IMPORTANT*
This plugin must be put JUST BEFORE the admin slot reservation plugin
In plugins.ini

PHP Code:

pb_vip.amxx
adminslots.amxx      ; slot reservation 


[HamletEagle]

PHP Code:

    if(!is_user_connected(id))
        return HAM_IGNORED;
    if(!is_user_alive(id))
        return HAM_IGNORED; 


For your information, only is_user_alive is needed, as it does all the other checks.
Also, name max len is 32, not 33. Also in UpdateData read_flags should be cached.
In vformat charsmax should be used for getting string array size.

I am not sure what to do with this. Considering plugin purpose and ignoring the code, does something like this worth to be approved? I have to think.

[didoWEE]

Originally Posted by HamletEagle PHP Code:     if(!is_user_connected(id))         return HAM_IGNORED;     if(!is_user_alive(id))         return HAM_IGNORED;  For your information, only is_user_alive is needed, as it does all the other checks. Also, name max len is 32, not 33. Also in UpdateData read_flags should be cached. In vformat charsmax should be used for getting string array size. I am not sure what to do with this. Considering plugin purpose and ignoring the code, does something like this worth to be approved? I have to think.

All considered - updated!

[crnova]

PHP Code:

if(!is_user_connected(killer))
        return HAM_IGNORED;
if(killer == victim)
        return HAM_IGNORED;
if(!is_real_player(killer))
        return HAM_IGNORED;
if(g_bFlagged[killer])
        return HAM_IGNORED; 


->

PHP Code:

if(!is_user_connected(killer) || killer == victim || !is_real_player(killer) || g_bFlagged[killer])
     return HAM_IGNORED 


PHP Code:

if(!is_user_alive(id))
        return HAM_IGNORED;
if(!is_real_player(id))
        return HAM_IGNORED;
if(g_bFlagged[id])
        return HAM_IGNORED; 


->

PHP Code:

if(!is_user_alive(id) || !is_real_player(id) || g_bFlagged[id])
               return HAM_IGNORED 


[didoWEE]

Originally Posted by crnova PHP Code: if(!is_user_connected(killer))         return HAM_IGNORED; if(killer == victim)         return HAM_IGNORED; if(!is_real_player(killer))         return HAM_IGNORED; if(g_bFlagged[killer])         return HAM_IGNORED;  -> PHP Code: if(!is_user_connected(killer) || killer == victim || !is_real_player(killer) || g_bFlagged[killer])      return HAM_IGNORED  PHP Code: if(!is_user_alive(id))         return HAM_IGNORED; if(!is_real_player(id))         return HAM_IGNORED; if(g_bFlagged[id])         return HAM_IGNORED;  -> PHP Code: if(!is_user_alive(id) || !is_real_player(id) || g_bFlagged[id])                return HAM_IGNORED

nope

[crnova]

Why not? less lines, but same functionality

[EFFx]

PHP Code:

public client_infochanged(id)
 set_task(0.1, "UpdateData", id); 


->

PHP Code:

public client_infochanged(id)
 UpdateData(id); 


PHP Code:

 if(g_iKills[id] == 0)
  SayText(id, "^4[%s] ^1Players who play ^3regularly ^1are rewarded with ^4V.I.P. ^1privileges", MSG_TAG); 


->

PHP Code:

 if(g_iKills[id] <= 10) // Wil be better
  SayText(id, "^4[%s] ^1Players who play ^3regularly ^1are rewarded with ^4V.I.P. ^1privileges",MSG_TAG); 


And how crnova wrote:

Originally Posted by crnova PHP Code: if(!is_user_connected(killer))          return HAM_IGNORED;  if(killer == victim)          return HAM_IGNORED;  if(!is_real_player(killer))          return HAM_IGNORED;  if(g_bFlagged[killer])          return HAM_IGNORED;  -> PHP Code: if(!is_user_connected(killer) || killer == victim || !is_real_player(killer) || g_bFlagged[killer])       return HAM_IGNORED  PHP Code: if(!is_user_alive(id))          return HAM_IGNORED;  if(!is_real_player(id))          return HAM_IGNORED;  if(g_bFlagged[id])          return HAM_IGNORED;  -> PHP Code: if(!is_user_alive(id) || !is_real_player(id) || g_bFlagged[id])                 return HAM_IGNORED

Suggestion:

Add translate. Its a simple and good plugin.

[didoWEE]

Originally Posted by crnova Why not? less lines, but same functionality

Functionality is not the same!

My way

PHP Code:

    if(!is_user_connected(killer))
        return HAM_IGNORED; // if true - function stops --> 1 if
    if(killer == victim)
        return HAM_IGNORED; // if true - function stops --> 2 ifs
    if(!is_real_player(killer))
        return HAM_IGNORED; // if true - function stops --> 3 ifs
    if(g_bFlagged[killer])
        return HAM_IGNORED; // if true - function stops --> 4 ifs 


Your way

PHP Code:

if(!is_user_connected(killer) || killer == victim || !is_real_player(killer) || g_bFlagged[killer])
      return HAM_IGNORED; // if true - function stops -> Always 4 ifs 


I am not sure about client_infochanged()
I have to check


Stop spamming my thread, please!

[EFFx]

Spam? Its suggestion, if do you want your plugin be approved, ok. We will stop given suggestion for your simple plugin that i can make in 10 minutes. And a better format

[HamletEagle]

Originally Posted by EFFx Spam? Its suggestion, if do you want your plugin be approved, ok. We will stop given suggestion for your simple plugin that i can make in 10 minutes. And a better format

Stop talking about approved or unapproved plugins.