[GuStAvOS]

hello again :v
someone could help me compile the
CollisionHook.ext.so for the SourceMod v1.7.3-dev + 5290
on l4d2 ... thanks in advance

[Spirit_12]

What error do you get? The extension should work on L4D2, unless you get the symbol error.

[GuStAvOS]

I see this error ...

<FAILED> file "collisionhook.ext.so": /home/gustavo/serverfiles/left4dead2/addons/sourcemod/extensions/collisionhook.ext.so: undefined symbol: g_pMemAlloc


[SM] Unable to load plugin "l4d2_collision_adjustments.smx": Required extension "CollisionHook" file("collisionhook.ext") not running

help me please

[Spirit_12]

Haven’t used this in a while, but try the one from my repo.

https://github.com/Satanic-Spirit/Co....ext.2.l4d2.so

[Morell]

We need a gamedata update.

[hmmmmm]

I did a bit of investigation on why this doesn't work on CS:GO windows, the gamedata itself is fine but the entity pointer values passed into the detour seem to be messed up.
I noticed that the function is actually a fastcall so the entity pointers are passed in through the ecx/edx registers, I'm guessing thats why the detour "fails".

EDIT: I tested this and that seems to have been the issue. After changing the detour function into a fastcall it all works fine.

Source for the fix: https://github.com/SlidyBat/CollisionHook
Windows binary also attached

[Spirit_12]

Hmm, interesting! Is the function static on Linux and fastcall on windows? If that's true, then I wonder, if that's the same reason why the extension stopped working on l4d2.

[hmmmmm]

Yeah it seems like only windows is troublesome with these optimisations, not sure why. Easiest way to check if it's a different calling convention in L4D2 is to crack open the binary in IDA and find the function to see how it works, very likely that it's the same reason (or the gamedata actually changed).

[Spirit_12]

Originally Posted by hmmmmm Yeah it seems like only windows is troublesome with these optimisations, not sure why. Easiest way to check if it's a different calling convention in L4D2 is to crack open the binary in IDA and find the function to see how it works, very likely that it's the same reason (or the gamedata actually changed).

Tried both of them and couldn't figure out the reason. Mind you, the game data is accurate and the extensions works like a charm on Linux. Just Windows is crashing. This is the function from disassembly.

PHP Code:

.text:10208280
.text:10208280 ; =============== S U B R O U T I N E =======================================
.text:10208280
.text:10208280 ; Attributes: bp-based frame
.text:10208280
.text:10208280 sub_10208280    proc near               ; CODE XREF: sub_1003CC70+28p
.text:10208280                                         ; sub_1019D5A0+28p ...
.text:10208280
.text:10208280 arg_0           = dword ptr  8
.text:10208280 arg_4           = dword ptr  0Ch
.text:10208280
.text:10208280                 push    ebp
.text:10208281                 mov     ebp, esp
.text:10208283                 push    edi
.text:10208284                 mov     edi, [ebp+arg_4]
.text:10208287                 test    edi, edi
.text:10208289                 jnz     short loc_10208290
.text:1020828B                 mov     al, 1
.text:1020828D                 pop     edi
.text:1020828E                 pop     ebp
.text:1020828F                 retn
.text:10208290 ; ---------------------------------------------------------------------------
.text:10208290
.text:10208290 loc_10208290:                           ; CODE XREF: sub_10208280+9j
.text:10208290                 push    esi
.text:10208291                 mov     esi, [ebp+arg_0]
.text:10208294                 cmp     esi, edi
.text:10208296                 jnz     short loc_1020829E
.text:10208298                 pop     esi
.text:10208299                 xor     al, al
.text:1020829B                 pop     edi
.text:1020829C                 pop     ebp
.text:1020829D                 retn
.text:1020829E ; ---------------------------------------------------------------------------
.text:1020829E
.text:1020829E loc_1020829E:                           ; CODE XREF: sub_10208280+16j
.text:1020829E                 mov     ecx, dword_107D1C00
.text:102082A4                 mov     eax, [ecx]
.text:102082A6                 mov     edx, [eax+0Ch]
.text:102082A9                 push    ebx
.text:102082AA                 push    esi
.text:102082AB                 call    edx
.text:102082AD                 test    al, al
.text:102082AF                 jz      short loc_102082B5
.text:102082B1                 xor     ebx, ebx
.text:102082B3                 jmp     short loc_102082C0
.text:102082B5 ; ---------------------------------------------------------------------------
.text:102082B5
.text:102082B5 loc_102082B5:                           ; CODE XREF: sub_10208280+2Fj
.text:102082B5                 mov     eax, [esi]
.text:102082B7                 mov     edx, [eax+14h]
.text:102082BA                 mov     ecx, esi
.text:102082BC                 call    edx
.text:102082BE                 mov     ebx, eax
.text:102082C0
.text:102082C0 loc_102082C0:                           ; CODE XREF: sub_10208280+33j
.text:102082C0                 mov     ecx, dword_107D1C00
.text:102082C6                 mov     eax, [ecx]
.text:102082C8                 mov     edx, [eax+0Ch]
.text:102082CB                 push    edi
.text:102082CC                 call    edx
.text:102082CE                 test    al, al
.text:102082D0                 jz      short loc_102082D6
.text:102082D2                 xor     esi, esi
.text:102082D4                 jmp     short loc_102082E1
.text:102082D6 ; ---------------------------------------------------------------------------
.text:102082D6
.text:102082D6 loc_102082D6:                           ; CODE XREF: sub_10208280+50j
.text:102082D6                 mov     eax, [edi]
.text:102082D8                 mov     edx, [eax+14h]
.text:102082DB                 mov     ecx, edi
.text:102082DD                 call    edx
.text:102082DF                 mov     esi, eax
.text:102082E1
.text:102082E1 loc_102082E1:                           ; CODE XREF: sub_10208280+54j
.text:102082E1                 test    ebx, ebx
.text:102082E3                 jz      short loc_1020830C
.text:102082E5                 test    esi, esi
.text:102082E7                 jz      short loc_1020830C
.text:102082E9                 mov     ecx, ebx
.text:102082EB                 call    sub_1003BCE0
.text:102082F0                 cmp     eax, esi
.text:102082F2                 jnz     short loc_102082FB
.text:102082F4                 pop     ebx
.text:102082F5                 pop     esi
.text:102082F6                 xor     al, al
.text:102082F8                 pop     edi
.text:102082F9                 pop     ebp
.text:102082FA                 retn
.text:102082FB ; ---------------------------------------------------------------------------
.text:102082FB
.text:102082FB loc_102082FB:                           ; CODE XREF: sub_10208280+72j
.text:102082FB                 mov     ecx, esi
.text:102082FD                 call    sub_1003BCE0
.text:10208302                 cmp     eax, ebx
.text:10208304                 pop     ebx
.text:10208305                 pop     esi
.text:10208306                 setnz   al
.text:10208309                 pop     edi
.text:1020830A                 pop     ebp
.text:1020830B                 retn
.text:1020830C ; ---------------------------------------------------------------------------
.text:1020830C
.text:1020830C loc_1020830C:                           ; CODE XREF: sub_10208280+63j
.text:1020830C                                         ; sub_10208280+67j
.text:1020830C                 pop     ebx
.text:1020830D                 pop     esi
.text:1020830E                 mov     al, 1
.text:10208310                 pop     edi
.text:10208311                 pop     ebp
.text:10208312                 retn
.text:10208312 sub_10208280    endp
.text:10208312 


[hmmmmm]

I don't have the game or the binary myself, but you'll have to attach a debugger to see where its failing. The function assembly looks normal to me, no weird calling convention or anything.